Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
Jefffrey closed issue #5: Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case URL: https://github.com/apache/datafusion/issues/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
adriangb commented on issue #5: URL: https://github.com/apache/datafusion/issues/5#issuecomment-4467939994 Hi @BipashaBi, a link to the PR would be much more helpful than a screenshot. For what it’s worth I also suggest to not ask for things “ASAP”: reviewers have limited time and nowadays especially with so much AI generated code are under a lot of pressure. Wording like “when you have time” will land a lot smoother. @puneetdixit200 I agree that adding benchmarks first as an isolated PR is the way to go. Since @comphead already said they’d work on this I suggest we wait to see what they come up with. Maybe @puneetdixit200 @BipashaBi can help with code review of that PR? Time spent on code review is much more valuable than code submissions, it’s a much more limited resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
puneetdixit200 commented on issue #5: URL: https://github.com/apache/datafusion/issues/5#issuecomment-4467919670 I’d like to work on this optimization. I can add a benchmark for the perfect-zip case, avoid row-by-row copying where input arrays align, and verify output compatibility with existing nested-array tests. Please assign this to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
BipashaBi commented on issue #5: URL: https://github.com/apache/datafusion/issues/5#issuecomment-4466517441 greetings @adriangb ! i have a PR which solves this issue. Please kindly check it ASAP. https://github.com/user-attachments/assets/0a4b39fb-0ed8-419b-9960-0a76c404d037"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
comphead commented on issue #5: URL: https://github.com/apache/datafusion/issues/5#issuecomment-4464551979 > No, I am happy to have someone else handle it! Okie, we'll probably pick it up later next week as this function is heavily used in some of our workloads -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
adriangb commented on issue #5: URL: https://github.com/apache/datafusion/issues/5#issuecomment-4464537213 No, I am happy to have someone else handle it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Optimize `arrays_zip` to avoid row-by-row copying in the perfect-zip case [datafusion]
comphead commented on issue #5: URL: https://github.com/apache/datafusion/issues/5#issuecomment-4464403405 @adriangb are you planning to work on that? @hsiang-c cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
