Re: [I] Support coercsion from `FixedSizeBinary` to `BinaryView` [datafusion]

2025-05-21 Thread via GitHub


alamb closed issue #15755: Support coercsion from `FixedSizeBinary` to 
`BinaryView` 
URL: https://github.com/apache/datafusion/issues/15755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Support coercsion from `FixedSizeBinary` to `BinaryView` [datafusion]

2025-04-20 Thread via GitHub


jayzhan211 commented on issue #15755:
URL: https://github.com/apache/datafusion/issues/15755#issuecomment-2817104010

   > @jayzhan211  could you please give me an example sql? I tried to construct 
test sql. but 
   > 
   > 
https://github.com/apache/datafusion/blob/8a193c22f6c3f771bff16cb8f9608d764d268c59/datafusion/expr/src/expr_schema.rs#L497
   > 
   > An error is thrown.
   > 
   > ```
   > Cannot automatically convert FixedSizeBinary(3) to BinaryView
   > ```
   > 
   > `can_cast_types` is from arrow, should we modify arrow? or maybe I 
misunderstand something.
   
   It seems like we need to support arrow, fixed size to view type for binary 
type


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Support coercsion from `FixedSizeBinary` to `BinaryView` [datafusion]

2025-04-20 Thread via GitHub


chenkovsky commented on issue #15755:
URL: https://github.com/apache/datafusion/issues/15755#issuecomment-2817103271

   @jayzhan211  could you please give me an example sql? I tried to construct 
test sql. but 
   
   
https://github.com/apache/datafusion/blob/8a193c22f6c3f771bff16cb8f9608d764d268c59/datafusion/expr/src/expr_schema.rs#L497
   
   An error is thrown.
   
   ```
   Cannot automatically convert FixedSizeBinary(3) to BinaryView
   ```
   
   `can_cast_types` is from arrow, should we modify arrow? or maybe I 
misunderstand something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [I] Support coercsion from `FixedSizeBinary` to `BinaryView` [datafusion]

2025-04-19 Thread via GitHub


chenkovsky commented on issue #15755:
URL: https://github.com/apache/datafusion/issues/15755#issuecomment-2816757278

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]