Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
andygrove commented on PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#issuecomment-3001260436 Working on this has not been a priority lately, so I'll close this for now. Thanks for the collaboration @anuragmantri. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
andygrove closed pull request #1654: [wip] Add scripts for running benchmarks on EC2 URL: https://github.com/apache/datafusion-comet/pull/1654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
andygrove commented on code in PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#discussion_r2073781405 ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp Review Comment: I implemented your feedback to only download if it is not already downloaded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
andygrove commented on code in PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#discussion_r2073780545 ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" Review Comment: Added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
andygrove commented on code in PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#discussion_r2073775557 ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp Review Comment: No, the intent was to install Spark in the default working directory (`/home/ec2-user/`). We need to create the `/home/ec2-user/tmp` folder so that we can use tmp storage on the primary EBS volume rather than in `/tmp` which is mounted on a small volume. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
anuragmantri commented on code in PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#discussion_r2069180747 ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp Review Comment: Is the intention here to download and run Spark from `/home/ec2-user/tmp`? If so, we need to change the below lines to work from the /tmp directory. I would also download only if spark does not exist. How about this? ``` # Create tmp directory and install Spark if not already present mkdir -p /home/ec2-user/tmp cd /home/ec2-user/tmp if [ ! -d "spark-3.5.5-bin-hadoop3" ]; then wget https://dlcdn.apache.org/spark/spark-3.5.5/spark-3.5.5-bin-hadoop3.tgz tar xzf spark-3.5.5-bin-hadoop3.tgz fi ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
anuragmantri commented on code in PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#discussion_r2069177697 ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" Review Comment: My RHEL9 EC2 instance did not have `wget`. May be we should add `yum install wget --y`? ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp +wget https://dlcdn.apache.org/spark/spark-3.5.5/spark-3.5.5-bin-hadoop3.tgz +tar xzf spark-3.5.5-bin-hadoop3.tgz +cp spark-env.sh spark-3.5.5-bin-hadoop3/conf +export SPARK_HOME=/home/ec2-user/spark-3.5.5-bin-hadoop3/ Review Comment: this line has a trailing `/` ## dev/benchmarks/setup.sh: ## @@ -0,0 +1,44 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Install Rust +sudo yum groupinstall -y "Development Tools" +curl https://sh.rustup.rs -sSf | sh -s -- -y +. "$HOME/.cargo/env" + +# Install Java +sudo yum install -y java-17-amazon-corretto-headless java-17-amazon-corretto-devel +export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto + +# Build Comet +make release PROFILES="-Pspark-3.5" + +# Clone datafusion-benchmarks repo, which has the queries +git clone https://github.com/apache/datafusion-benchmarks.git + +# Install Spark +mkdir /home/ec2-user/tmp Review Comment: Is the intention here to download and run Spark from `/home/ec2-user/tmp`? If so, we need to change the below lines to work from the /tmp directory. I would also do it only if it does not exist. How about this? ``` # Create tmp directory and install Spark if not already present mkdir -p /home/ec2-user/tmp cd /home/ec2-user/tmp if [ ! -d "spark-3.5.5-bin-hadoop3" ]; then wget https://dlcdn.apache.org/spark/spark-3.5.5/spark-3.5.5-bin-hadoop3.tgz tar xzf spark-3.5.5-bin-hadoop3.tgz fi ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
parthchandra commented on PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#issuecomment-2810825234 That is very odd. We don't see the same in an EKS cluster with S3 storage. Is this consistently bad? Not a noisy neighbor issue, I hope? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
andygrove commented on PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#issuecomment-2810381769 The current status is that Comet is slower than Spark. Both Spark and Comet take an extremely long time to complete the benchmark (~50 minutes compared to 10 minutes for Spark and 5 minutes for Comet when running on my local workstation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [wip] Add scripts for running benchmarks on EC2 [datafusion-comet]
codecov-commenter commented on PR #1654: URL: https://github.com/apache/datafusion-comet/pull/1654#issuecomment-2809855816 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1654?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 57.61%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f363227`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f3632271b5ddebe30267b0b3102e9f312364c1b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 145 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1654 +/- ## + Coverage 56.12% 57.61% +1.48% - Complexity 976 1019 +43 Files 119 125 +6 Lines 1174312496 +753 Branches 2251 2352 +101 + Hits 6591 7199 +608 - Misses 4012 4105 +93 - Partials 1140 1192 +52 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1654?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
