Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-12-04 Thread via GitHub 


github-actions[bot] closed pull request #16541: Adds script to detect breaking 
API changes/ semver
URL: https://github.com/apache/datafusion/pull/16541


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-11-27 Thread via GitHub 


github-actions[bot] commented on PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#issuecomment-3587695348

   Thank you for your contribution. Unfortunately, this pull request is stale 
because it has been open 60 days with no activity. Please remove the stale 
label or comment or this will be closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-10-18 Thread via GitHub 


alamb commented on PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#issuecomment-3318165668

   DataFusion doesn't currently maintain  semver (we crank out major releases 
with semver breaking changes every month or two). So maybe we just need to 
ensure that are flagging each PR that has breaking changes appropriately 
(rather than blog the CI)
   
   cargo-semver-checks sounds good to me , though we need to make sure it is on 
the ASF approved list
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-09-22 Thread via GitHub 


Jefffrey commented on PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#issuecomment-3319447315

   It seems we also have #15408 and #13665 :eyes:
   
   I guess we need to centralize this discussion again
   
   > though we need to make sure it is on the ASF approved list
   
   I'll admit I was thinking of this from the POV of running 
`cargo-semver-checks` manually before a release instead of it being an 
automated CI check; though it would increase the workload for performing 
releases 🙁 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-09-21 Thread via GitHub 


Jefffrey commented on PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#issuecomment-3316430976

   Have we considered using a tool like 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks)? It 
might be better to offload this semver checking logic to a tool dedicated for 
that purpose rather than rolling our own shell script.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-07-21 Thread via GitHub 


lucqui commented on code in PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#discussion_r2221148945


##
.github/workflows/dev.yml:
##
@@ -35,6 +80,9 @@ jobs:
 runs-on: ubuntu-latest
 steps:
   - uses: actions/checkout@v4
+with:

Review Comment:
   We need the full history I believe. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-06-30 Thread via GitHub 


alamb commented on code in PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#discussion_r2175739884


##
.github/workflows/dev.yml:
##
@@ -16,13 +16,58 @@
 # under the License.
 
 name: Dev
-on: [push, pull_request]
+on: [push, pull_request, workflow_dispatch]
 
 concurrency:
   group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ 
github.workflow }}
   cancel-in-progress: true
 
 jobs:
+  breaking-changes:
+name: Breaking Changes Detection
+runs-on: ubuntu-latest
+if: github.event_name == 'pull_request'
+permissions:
+  contents: read
+  pull-requests: write
+  issues: write
+steps:
+  - name: Checkout code
+uses: actions/checkout@v4
+with:
+  fetch-depth: 0
+  token: ${{ secrets.GITHUB_TOKEN }}
+
+  - name: Install Rust toolchain

Review Comment:
   The other actions already have actions to setup rust -- can we reuse the 
same one please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Adds script to detect breaking API changes/ semver [datafusion]

2025-06-30 Thread via GitHub 


alamb commented on code in PR #16541:
URL: https://github.com/apache/datafusion/pull/16541#discussion_r2175736700


##
.github/workflows/dev.yml:
##
@@ -35,6 +80,9 @@ jobs:
 runs-on: ubuntu-latest
 steps:
   - uses: actions/checkout@v4
+with:

Review Comment:
   why is this needed?



##
.github/workflows/dev.yml:
##
@@ -16,13 +16,58 @@
 # under the License.
 
 name: Dev
-on: [push, pull_request]
+on: [push, pull_request, workflow_dispatch]
 
 concurrency:
   group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ 
github.workflow }}
   cancel-in-progress: true
 
 jobs:
+  breaking-changes:
+name: Breaking Changes Detection
+runs-on: ubuntu-latest
+if: github.event_name == 'pull_request'
+permissions:
+  contents: read
+  pull-requests: write
+  issues: write
+steps:
+  - name: Checkout code
+uses: actions/checkout@v4
+with:
+  fetch-depth: 0
+  token: ${{ secrets.GITHUB_TOKEN }}
+
+  - name: Install Rust toolchain
+uses: dtolnay/rust-toolchain@stable
+
+  - name: Install GitHub CLI
+run: |
+  if ! command -v gh &> /dev/null; then

Review Comment:
   As I understood it the Github hosted runners already have `gh` installed on 
them -- thus this command to setup and install apt-get seems unecessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]