Re: [PR] Allow unparser to override the alias name for the specific dialect [datafusion]
goldmedal commented on PR #16540: URL: https://github.com/apache/datafusion/pull/16540#issuecomment-3006609720 Thanks @alamb 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Allow unparser to override the alias name for the specific dialect [datafusion]
alamb commented on PR #16540: URL: https://github.com/apache/datafusion/pull/16540#issuecomment-3005916488 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Allow unparser to override the alias name for the specific dialect [datafusion]
alamb merged PR #16540: URL: https://github.com/apache/datafusion/pull/16540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Allow unparser to override the alias name for the specific dialect [datafusion]
alamb commented on code in PR #16540:
URL: https://github.com/apache/datafusion/pull/16540#discussion_r2164780443
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -923,6 +923,35 @@ fn roundtrip_statement_with_dialect_45() -> Result<(),
DataFusionError> {
Ok(())
}
+#[test]
+fn roundtrip_statement_with_dialect_special_char_alias() -> Result<(),
DataFusionError> {
+roundtrip_statement_with_dialect_helper!(
Review Comment:
it might also help to add a test case here with unparser_dialect
`GenericDialect` too to show the difference in dialects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
