Re: [PR] Implement tree explain for LazyMemoryExec [datafusion]
Weijun-H commented on PR #15187: URL: https://github.com/apache/datafusion/pull/15187#issuecomment-2720518855 Ship it and improve it in the follow-up. Thanks @zebsme and @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Implement tree explain for LazyMemoryExec [datafusion]
Weijun-H merged PR #15187: URL: https://github.com/apache/datafusion/pull/15187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Implement tree explain for LazyMemoryExec [datafusion]
zebsme commented on PR #15187: URL: https://github.com/apache/datafusion/pull/15187#issuecomment-2720041739 hi @alamb Added TODO comment and conflicts resolved Thanks for suggestion :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Implement tree explain for LazyMemoryExec [datafusion]
alamb commented on code in PR #15187: URL: https://github.com/apache/datafusion/pull/15187#discussion_r1992212383 ## datafusion/sqllogictest/test_files/explain_tree.slt: ## @@ -725,7 +725,12 @@ physical_plan 32)└─┬─┘ 33)┌─┴─┐ 34)│ LazyMemoryExec │ -35)└───┘ +35)│ │ +36)│ batch_generators: │ +37)│ generate_series: start=1, │ +38)│end=1000, batch_size │ Review Comment: my recommendation is to avoid printing the batch size here if possible And maybe we could add one line per generator 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Implement tree explain for LazyMemoryExec [datafusion]
zebsme commented on PR #15187: URL: https://github.com/apache/datafusion/pull/15187#issuecomment-2718417560 hi @alamb should this formatting looks better? ``` +-+-+ | LazyMemoryExec | | | | generate_series: | | start=1, end=1000,| | batch_size=8192 | +---+ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
