Re: [PR] Improve the DML / DDL Documentation [datafusion]
alamb merged PR #16115: URL: https://github.com/apache/datafusion/pull/16115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Improve the DML / DDL Documentation [datafusion]
alamb commented on PR #16115: URL: https://github.com/apache/datafusion/pull/16115#issuecomment-2898881322 Thanks again @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Improve the DML / DDL Documentation [datafusion]
comphead commented on code in PR #16115:
URL: https://github.com/apache/datafusion/pull/16115#discussion_r2098353174
##
datafusion/expr/src/logical_plan/dml.rs:
##
@@ -89,8 +89,27 @@ impl Hash for CopyTo {
}
}
-/// The operator that modifies the content of a database (adapted from
-/// substrait WriteRel)
+/// Modifies the content of a database
+///
+/// This operator is used to perform DML operations such as INSERT, DELETE,
+/// UPDATE, and CTAS (CREATE TABLE AS SELECT).
+///
+/// * `INSERT` - Appends new rows to the existing table. Calls
+/// [`TableProvider::insert_into`]
+///
+/// * `DELETE` - Removes rows from the table. NOT currently supported by the
+/// [`TableProvider`] trait or builtin sources.
+///
+/// * `UPDATE` - Modifies existing rows in the table. NOT currently supported
by
Review Comment:
```suggestion
/// * `UPDATE` - Modifies existing rows in the table. Currently NOT
supported by
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Improve the DML / DDL Documentation [datafusion]
comphead commented on code in PR #16115:
URL: https://github.com/apache/datafusion/pull/16115#discussion_r2098352617
##
datafusion/expr/src/logical_plan/dml.rs:
##
@@ -89,8 +89,27 @@ impl Hash for CopyTo {
}
}
-/// The operator that modifies the content of a database (adapted from
-/// substrait WriteRel)
+/// Modifies the content of a database
+///
+/// This operator is used to perform DML operations such as INSERT, DELETE,
+/// UPDATE, and CTAS (CREATE TABLE AS SELECT).
+///
+/// * `INSERT` - Appends new rows to the existing table. Calls
+/// [`TableProvider::insert_into`]
+///
+/// * `DELETE` - Removes rows from the table. NOT currently supported by the
Review Comment:
```suggestion
/// * `DELETE` - Removes rows from the table. Currently NOT supported by the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
