Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260972838

   πŸ€– Benchmark running (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4260950110)
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux 
bench-c4260950110-1371-8wgd5 6.12.55+ #1 SMP Sun Feb  1 08:59:41 UTC 2026 
aarch64 GNU/Linux`
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Comparing codex/hash-join-empty-partition-reporting 
(0584854263a02d0ea2c0cd78cc25d7b2cf5b1e1f) to 5c653be (merge-base) 
[diff](https://github.com/apache/datafusion/compare/5c653bee5da64003915f6dfeb3da15759b091a8d..0584854263a02d0ea2c0cd78cc25d7b2cf5b1e1f)
 using: tpcds
   Results will be posted here when complete
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) 
against this benchmark runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangb commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260950110

   run benchmark tpcds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangb commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260535615

   Yes. And I think this was another bandaid. But it's closer to the root cause 
than previous attempts. This has to do with cancellation when multiple joins 
are involved.
   
   TLDR I think what is happening is when you have multiple joins you end up 
with a tree of operators. One of the joins up higher in the tree hits the new 
optimization and aborts work, dropping tasks that would have polled downstream 
joins. But not the downstream join is stuck waiting for all of it's partition 
tasks to finish even though they never will. I think we were all operating 
under the assumption that the issue was within a single join operator but 
really it's an issue any time an upstream operator cancels on a join.
   
   I think the real solution is to track when a join build partition task gets 
dropped and report that to the dynamic filter building so that it doesn't wait 
for that partition to report.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


Omega359 commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260406388

   query 72 took a bit of a hit here.
   
   
 Query72
   ```sql
   select  i_item_desc
,w_warehouse_name
,d1.d_week_seq
,sum(case when p_promo_sk is null then 1 else 0 end) no_promo
,sum(case when p_promo_sk is not null then 1 else 0 end) promo
,count(*) total_cnt
   from catalog_sales
join inventory on (cs_item_sk = inv_item_sk)
join warehouse on (w_warehouse_sk=inv_warehouse_sk)
join item on (i_item_sk = cs_item_sk)
join customer_demographics on (cs_bill_cdemo_sk = cd_demo_sk)
join household_demographics on (cs_bill_hdemo_sk = hd_demo_sk)
join date_dim d1 on (cs_sold_date_sk = d1.d_date_sk)
join date_dim d2 on (inv_date_sk = d2.d_date_sk)
join date_dim d3 on (cs_ship_date_sk = d3.d_date_sk)
left outer join promotion on (cs_promo_sk=p_promo_sk)
left outer join catalog_returns on (cr_item_sk = cs_item_sk and 
cr_order_number = cs_order_number)
   where d1.d_week_seq = d2.d_week_seq
 and inv_quantity_on_hand < cs_quantity
 and d3.d_date > (d1.d_date + INTERVAL '5 days')
 and hd_buy_potential = '>1'
 and d1.d_year = 1999
 and cd_marital_status = 'D'
   group by i_item_desc,w_warehouse_name,d1.d_week_seq
   order by total_cnt desc, i_item_desc, w_warehouse_name, d_week_seq
   limit 100;
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260230574

   πŸ€– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4260131019)
   
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
   
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Details
   
   
   ```
   Comparing HEAD and codex_hash-join-empty-partition-reporting
   
   Benchmark tpcds_sf1.json
   
   
┏━━━┳━━┳━━━┳━━━┓
   ┃ Query ┃ HEAD ┃ 
codex_hash-join-empty-partition-reporting ┃Change ┃
   
┑━━━╇━━╇━━━╇━━━┩
   β”‚ QQuery 1  β”‚  6.55 / 7.03 Β±0.79 / 8.60 ms β”‚   6.62 
/ 7.11 Β±0.87 / 8.84 ms β”‚ no change β”‚
   β”‚ QQuery 2  β”‚143.53 / 143.94 Β±0.32 / 144.23 ms β”‚ 142.69 / 
144.27 Β±0.86 / 145.12 ms β”‚ no change β”‚
   β”‚ QQuery 3  β”‚113.45 / 113.89 Β±0.36 / 114.35 ms β”‚ 113.86 / 
114.43 Β±0.60 / 115.53 ms β”‚ no change β”‚
   β”‚ QQuery 4  β”‚1334.29 / 1362.57 Β±21.81 / 1394.94 ms β”‚ 1360.31 / 
1390.10 Β±16.45 / 1405.65 ms β”‚ no change β”‚
   β”‚ QQuery 5  β”‚170.59 / 172.99 Β±1.76 / 175.28 ms β”‚ 172.45 / 
174.47 Β±1.77 / 177.23 ms β”‚ no change β”‚
   β”‚ QQuery 6  β”‚   826.41 / 876.05 Β±36.80 / 938.37 ms β”‚862.48 / 
884.01 Β±15.84 / 909.86 ms β”‚ no change β”‚
   β”‚ QQuery 7  β”‚339.57 / 344.15 Β±2.45 / 346.94 ms β”‚ 340.62 / 
345.25 Β±2.84 / 348.46 ms β”‚ no change β”‚
   β”‚ QQuery 8  β”‚115.88 / 116.71 Β±0.58 / 117.66 ms β”‚ 116.03 / 
116.77 Β±0.46 / 117.50 ms β”‚ no change β”‚
   β”‚ QQuery 9  β”‚100.96 / 103.05 Β±2.10 / 106.73 ms β”‚ 100.29 / 
106.99 Β±5.92 / 114.42 ms β”‚ no change β”‚
   β”‚ QQuery 10 β”‚106.11 / 106.48 Β±0.35 / 107.03 ms β”‚ 107.15 / 
108.84 Β±1.32 / 110.87 ms β”‚ no change β”‚
   β”‚ QQuery 11 β”‚930.37 / 943.58 Β±8.27 / 952.46 ms β”‚ 956.74 / 
960.95 Β±3.40 / 966.02 ms β”‚ no change β”‚
   β”‚ QQuery 12 β”‚   44.35 / 46.11 Β±1.12 / 47.41 ms β”‚45.31 / 
46.13 Β±0.70 / 47.37 ms β”‚ no change β”‚
   β”‚ QQuery 13 β”‚399.86 / 401.27 Β±1.29 / 402.88 ms β”‚ 400.47 / 
403.82 Β±2.05 / 406.38 ms β”‚ no change β”‚
   β”‚ QQuery 14 β”‚ 992.83 / 1007.54 Β±10.23 / 1022.21 ms β”‚991.24 / 
996.86 Β±4.77 / 1002.00 ms β”‚ no change β”‚

Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260142881

   πŸ€– Benchmark running (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4260131019)
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux 
bench-c4260131019-1367-smhnv 6.12.55+ #1 SMP Sun Feb  1 08:59:41 UTC 2026 
aarch64 GNU/Linux`
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Comparing codex/hash-join-empty-partition-reporting 
(d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01) to 5c653be (merge-base) 
[diff](https://github.com/apache/datafusion/compare/5c653bee5da64003915f6dfeb3da15759b091a8d..d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01)
 using: tpcds
   Results will be posted here when complete
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) 
against this benchmark runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangb commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4260131019

   run benchmark tpcds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4259990887

   πŸ€– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4259875560)
   
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
   
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Details
   
   
   ```
   Comparing HEAD and codex_hash-join-empty-partition-reporting
   
   Benchmark tpcds_sf1.json
   
   
┏━━━┳━━┳━━━┳━━━┓
   ┃ Query ┃ HEAD ┃ 
codex_hash-join-empty-partition-reporting ┃Change ┃
   
┑━━━╇━━╇━━━╇━━━┩
   β”‚ QQuery 1  β”‚  6.98 / 7.37 Β±0.69 / 8.75 ms β”‚   7.09 
/ 7.54 Β±0.69 / 8.90 ms β”‚ no change β”‚
   β”‚ QQuery 2  β”‚145.73 / 146.31 Β±0.32 / 146.60 ms β”‚ 146.27 / 
147.38 Β±0.76 / 148.07 ms β”‚ no change β”‚
   β”‚ QQuery 3  β”‚114.06 / 114.75 Β±0.58 / 115.63 ms β”‚ 115.04 / 
116.01 Β±0.69 / 116.89 ms β”‚ no change β”‚
   β”‚ QQuery 4  β”‚1410.96 / 1432.76 Β±11.84 / 1445.23 ms β”‚ 1421.36 / 
1449.73 Β±18.93 / 1470.63 ms β”‚ no change β”‚
   β”‚ QQuery 5  β”‚174.22 / 175.39 Β±1.01 / 177.11 ms β”‚ 175.06 / 
175.90 Β±0.69 / 176.96 ms β”‚ no change β”‚
   β”‚ QQuery 6  β”‚   845.04 / 889.68 Β±26.52 / 915.48 ms β”‚857.43 / 
886.16 Β±21.55 / 910.23 ms β”‚ no change β”‚
   β”‚ QQuery 7  β”‚348.38 / 350.63 Β±2.63 / 354.78 ms β”‚ 348.24 / 
350.59 Β±1.51 / 352.86 ms β”‚ no change β”‚
   β”‚ QQuery 8  β”‚117.72 / 118.21 Β±0.41 / 118.88 ms β”‚ 117.47 / 
118.30 Β±0.76 / 119.43 ms β”‚ no change β”‚
   β”‚ QQuery 9  β”‚102.35 / 105.91 Β±2.84 / 109.15 ms β”‚102.56 / 
111.85 Β±11.17 / 133.78 ms β”‚  1.06x slower β”‚
   β”‚ QQuery 10 β”‚107.24 / 108.52 Β±0.75 / 109.28 ms β”‚ 109.81 / 
111.12 Β±0.86 / 112.11 ms β”‚ no change β”‚
   β”‚ QQuery 11 β”‚ 1007.00 / 1021.26 Β±9.23 / 1034.34 ms β”‚  1007.07 / 
1024.01 Β±8.78 / 1031.00 ms β”‚ no change β”‚
   β”‚ QQuery 12 β”‚   45.77 / 49.05 Β±1.75 / 50.94 ms β”‚46.99 / 
48.84 Β±1.52 / 50.68 ms β”‚ no change β”‚
   β”‚ QQuery 13 β”‚413.26 / 417.25 Β±5.89 / 428.86 ms β”‚ 408.54 / 
411.67 Β±3.27 / 417.80 ms β”‚ no change β”‚
   β”‚ QQuery 14 β”‚ 1009.07 / 1017.56 Β±7.45 / 1029.43 ms β”‚  999.17 / 
1018.18 Β±11.21 / 1031.36 ms β”‚ no change β”‚

Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4259989300

   πŸ€– Benchmark completed (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4259875560)
   
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
   
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Details
   
   
   ```
   Comparing HEAD and codex_hash-join-empty-partition-reporting
   
   Benchmark clickbench_partitioned.json
   
   
┏━━━┳┳━━━┳━━━┓
   ┃ Query ┃   HEAD ┃ 
codex_hash-join-empty-partition-reporting ┃Change ┃
   
┑━━━╇╇━━━╇━━━┩
   β”‚ QQuery 0  β”‚   1.19 / 4.37 Β±6.28 / 16.93 ms β”‚  1.19 / 
4.46 Β±6.37 / 17.19 ms β”‚ no change β”‚
   β”‚ QQuery 1  β”‚ 14.88 / 15.01 Β±0.11 / 15.17 ms β”‚15.14 / 
15.45 Β±0.17 / 15.63 ms β”‚ no change β”‚
   β”‚ QQuery 2  β”‚ 43.43 / 43.74 Β±0.26 / 44.21 ms β”‚43.98 / 
44.39 Β±0.30 / 44.90 ms β”‚ no change β”‚
   β”‚ QQuery 3  β”‚ 41.57 / 44.12 Β±1.69 / 46.34 ms β”‚42.77 / 
44.97 Β±1.35 / 46.94 ms β”‚ no change β”‚
   β”‚ QQuery 4  β”‚  282.16 / 293.79 Β±9.62 / 307.92 ms β”‚ 285.44 / 
296.97 Β±7.26 / 308.10 ms β”‚ no change β”‚
   β”‚ QQuery 5  β”‚  337.41 / 342.71 Β±2.83 / 345.05 ms β”‚ 352.81 / 
358.06 Β±4.34 / 364.86 ms β”‚ no change β”‚
   β”‚ QQuery 6  β”‚4.98 / 5.41 Β±0.22 / 5.55 ms β”‚  5.30 / 
9.08 Β±3.72 / 15.49 ms β”‚  1.68x slower β”‚
   β”‚ QQuery 7  β”‚ 16.78 / 17.38 Β±0.47 / 18.15 ms β”‚17.51 / 
17.64 Β±0.10 / 17.76 ms β”‚ no change β”‚
   β”‚ QQuery 8  β”‚  415.76 / 424.23 Β±8.58 / 440.27 ms β”‚410.23 / 
429.54 Β±12.05 / 446.87 ms β”‚ no change β”‚
   β”‚ QQuery 9  β”‚  648.84 / 658.48 Β±9.24 / 671.44 ms β”‚ 631.88 / 
643.91 Β±7.25 / 654.13 ms β”‚ no change β”‚
   β”‚ QQuery 10 β”‚ 92.78 / 95.81 Β±2.44 / 99.64 ms β”‚92.15 / 
94.38 Β±1.43 / 96.26 ms β”‚ no change β”‚
   β”‚ QQuery 11 β”‚  105.44 / 106.03 Β±0.58 / 107.09 ms β”‚ 105.57 / 
107.75 Β±2.37 / 111.84 ms β”‚ no change β”‚
   β”‚ QQuery 12 β”‚  342.54 / 352.42 Β±9.61 / 370.28 ms β”‚ 334.21 / 
339.65 Β±3.70 / 345.28 ms β”‚ no change β”‚
   β”‚ QQuery 13 β”‚  461.57 / 470.47 Β±8.18 / 484.10 ms β”‚448.28 / 
464.82 Β±10.82 / 476.52 ms β”‚ no change β”‚
   β”‚ QQuery 14 β”‚ 

Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4259891937

   πŸ€– Benchmark running (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4259875560)
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux 
bench-c4259875560-1361-d7znb 6.12.55+ #1 SMP Sun Feb  1 08:59:41 UTC 2026 
aarch64 GNU/Linux`
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Comparing codex/hash-join-empty-partition-reporting 
(d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01) to 5c653be (merge-base) 
[diff](https://github.com/apache/datafusion/compare/5c653bee5da64003915f6dfeb3da15759b091a8d..d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01)
 using: clickbench_partitioned
   Results will be posted here when complete
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) 
against this benchmark runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4259892610

   πŸ€– Benchmark running (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4259875560)
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux 
bench-c4259875560-1363-qrwrt 6.12.55+ #1 SMP Sun Feb  1 08:59:41 UTC 2026 
aarch64 GNU/Linux`
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Comparing codex/hash-join-empty-partition-reporting 
(d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01) to 5c653be (merge-base) 
[diff](https://github.com/apache/datafusion/compare/5c653bee5da64003915f6dfeb3da15759b091a8d..d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01)
 using: tpch
   Results will be posted here when complete
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) 
against this benchmark runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangbot commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4259890973

   πŸ€– Benchmark running (GKE) | 
[trigger](https://github.com/apache/datafusion/pull/21666#issuecomment-4259875560)
   **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux 
bench-c4259875560-1362-nk27n 6.12.55+ #1 SMP Sun Feb  1 08:59:41 UTC 2026 
aarch64 GNU/Linux`
   CPU Details (lscpu)
   
   ```
   Architecture:aarch64
   CPU op-mode(s):  64-bit
   Byte Order:  Little Endian
   CPU(s):  16
   On-line CPU(s) list: 0-15
   Vendor ID:   ARM
   Model name:  Neoverse-V2
   Model:   1
   Thread(s) per core:  1
   Core(s) per cluster: 16
   Socket(s):   -
   Cluster(s):  1
   Stepping:r0p1
   BogoMIPS:2000.00
   Flags:   fp asimd evtstrm aes pmull sha1 
sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 
sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 
sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm 
bf16 dgh rng bti
   L1d cache:   1 MiB (16 instances)
   L1i cache:   1 MiB (16 instances)
   L2 cache:32 MiB (16 instances)
   L3 cache:80 MiB (1 instance)
   NUMA node(s):1
   NUMA node0 CPU(s):   0-15
   Vulnerability Gather data sampling:  Not affected
   Vulnerability Indirect target selection: Not affected
   Vulnerability Itlb multihit: Not affected
   Vulnerability L1tf:  Not affected
   Vulnerability Mds:   Not affected
   Vulnerability Meltdown:  Not affected
   Vulnerability Mmio stale data:   Not affected
   Vulnerability Reg file data sampling:Not affected
   Vulnerability Retbleed:  Not affected
   Vulnerability Spec rstack overflow:  Not affected
   Vulnerability Spec store bypass: Mitigation; Speculative Store 
Bypass disabled via prctl
   Vulnerability Spectre v1:Mitigation; __user pointer 
sanitization
   Vulnerability Spectre v2:Mitigation; CSV2, BHB
   Vulnerability Srbds: Not affected
   Vulnerability Tsa:   Not affected
   Vulnerability Tsx async abort:   Not affected
   Vulnerability Vmscape:   Not affected
   ```
   
   
   
   Comparing codex/hash-join-empty-partition-reporting 
(d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01) to 5c653be (merge-base) 
[diff](https://github.com/apache/datafusion/compare/5c653bee5da64003915f6dfeb3da15759b091a8d..d17d5e46a45d6fa62d3b2c7a2959cba662fb0e01)
 using: tpcds
   Results will be posted here when complete
   
   ---
   [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) 
against this benchmark runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Report empty build partitions for partitioned hash join filters [datafusion]

2026-04-16 Thread via GitHub


adriangb commented on PR #21666:
URL: https://github.com/apache/datafusion/pull/21666#issuecomment-4259875560

   run benchmarks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]