Re: [PR] Support multiple results comparison in benchmark scripts [datafusion]
github-actions[bot] closed pull request #14196: Support multiple results comparison in benchmark scripts URL: https://github.com/apache/datafusion/pull/14196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Support multiple results comparison in benchmark scripts [datafusion]
github-actions[bot] commented on PR #14196: URL: https://github.com/apache/datafusion/pull/14196#issuecomment-2749855670 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Support multiple results comparison in benchmark scripts [datafusion]
Eason0729 commented on PR #14196: URL: https://github.com/apache/datafusion/pull/14196#issuecomment-2611373497 > Thanks @Eason0729 -- is there any chance you can post an example output after this change? ``` ../bench.sh compare main main2 main3 Comparing main2 main3 to main ┏━━┳┳┳━┳┳━┓ ┃ Query┃ main ┃ main2 ┃ Change on main2 ┃ main3 ┃ Change on main3 ┃ ┡━━╇╇╇━╇╇━┩ │ Qsort utf8 │ 25191.05ms │ 25191.05ms │ no change │ 25191.05ms │ no change │ │ Qsort int│ 30908.16ms │ 30908.16ms │ no change │ 40908.16ms │ 1.32x slower │ │ Qsort│ 25652.09ms │ 25652.09ms │ no change │ 25652.09ms │ no change │ │ decimal │││ ││ │ │ Qsort│ 32701.67ms │ 32701.67ms │ no change │ 32701.67ms │ no change │ │ integer │││ ││ │ │ tuple│││ ││ │ │ Qsort utf8 │ 25588.63ms │ 25588.63ms │ no change │ 25588.63ms │ no change │ │ tuple│││ ││ │ │ Qsort mixed │ 29063.22ms │ 29063.22ms │ no change │ 29063.22ms │ no change │ │ tuple│││ ││ │ └──┴┴┴─┴┴─┘ ┏┳━┓ ┃ Benchmark Summary ┃ ┃ ┡╇━┩ │ Total Time (main) │ 169104.82ms │ │ Average Time (main)│ 28184.14ms │ │ Total Time (main2) │ 169104.82ms │ │ Average Time (main2) │ 28184.14ms │ │ Queries Faster (main2) │ 0 │ │ Queries Slower (main2) │ 0 │ │ Queries with No Change (main2) │ 6 │ │ Total Time (main3) │ 179104.82ms │ │ Average Time (main3) │ 29850.80ms │ │ Queries Faster (main3) │ 0 │ │ Queries Slower (main3) │ 1 │ │ Queries with No Change (main3) │ 5 │ └┴─┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Support multiple results comparison in benchmark scripts [datafusion]
alamb commented on PR #14196: URL: https://github.com/apache/datafusion/pull/14196#issuecomment-2611196694 Thanks @Eason0729 -- is there any chance you can post an example output after this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Support multiple results comparison in benchmark scripts [datafusion]
Eason0729 commented on PR #14196: URL: https://github.com/apache/datafusion/pull/14196#issuecomment-2606171896 I spent some time trying to make it(compare.py) more readable, and I ended up with original code. Let me know if there is a better way to do this. Anyway, I thinks it ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
