Re: [PR] Update documentation for `datafusion.execution.collect_statistics` [datafusion]

[via GitHub]

alamb merged PR #16100:
URL: https://github.com/apache/datafusion/pull/16100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Update documentation for `datafusion.execution.collect_statistics` [datafusion]

[via GitHub]

alamb commented on PR #16100:
URL: https://github.com/apache/datafusion/pull/16100#issuecomment-2894408300

   Thank @leoyvens @xudong963 and @findepi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Update documentation for `datafusion.execution.collect_statistics` [datafusion]

[via GitHub]

leoyvens commented on code in PR #16100:
URL: https://github.com/apache/datafusion/pull/16100#discussion_r2096272547


##
datafusion/common/src/config.rs:
##
@@ -292,7 +292,9 @@ config_namespace! {
 /// target batch size is determined by the configuration setting
 pub coalesce_batches: bool, default = true
 
-/// Should DataFusion collect statistics after listing files
+/// Should DataFusion collect statistics when first creating a table.
+/// Has no effect after the table is created. Applies to the default
+/// `ListingTableProvider` in DataFusion Defaults to false.

Review Comment:
   ```suggestion
   /// `ListingTableProvider` in DataFusion. Defaults to false.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Update documentation for `datafusion.execution.collect_statistics` [datafusion]

[via GitHub]

alamb commented on PR #16100:
URL: https://github.com/apache/datafusion/pull/16100#issuecomment-2891582516

   This should fix CI:
   - https://github.com/apache/datafusion/pull/16102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Update documentation for `datafusion.execution.collect_statistics` [datafusion]

[via GitHub]

xudong963 commented on code in PR #16100:
URL: https://github.com/apache/datafusion/pull/16100#discussion_r2095842857


##
datafusion/common/src/config.rs:
##
@@ -292,7 +292,9 @@ config_namespace! {
 /// target batch size is determined by the configuration setting
 pub coalesce_batches: bool, default = true
 
-/// Should DataFusion collect statistics after listing files
+/// Should DataFusion collect statistics when first creating a table.

Review Comment:
   Thank you @alamb 
   
   This doc will definitely help a lot!!! (I also have been confused for many 
times)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org