Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
github-actions[bot] closed pull request #15597: Use pager and allow configuration via `\pset` URL: https://github.com/apache/datafusion/pull/15597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
github-actions[bot] commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-3190411093 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
djellemah commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2970492404 Merge conflict introduced by f40e0db161 on 02-may-2025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
github-actions[bot] commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2968768204 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
djellemah commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2799539091 Seems to me there's a confluence of several factors here: - testing this kind of functionality is not simple. - it's user facing, so if it breaks somebody will notice and say something. - it's not core functionality so the probability of erroneous behaviors causing severe consequences is fairly low. - there is limited maintainer bandwidth. - there is limited contributor bandwidth. In my opinion, the decision matrix here is not quite the same as one would apply to core functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
Weijun-H commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2791958004 I added a test to verify the CLI execution on the pty. However, testing key presses like ‘w’ or ‘s’ in the test is tricky, and there’s additional complexity with waiting for other tests to finish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
alamb commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2783269895 > I've added commits to address the CI failures. > > Of course you're welcome to add some tests to not break these features in the future :-) As documented in the contribution guidelines https://datafusion.apache.org/contributor-guide/testing.html#testing > All new features should have test coverage Thus I agree with @berkaysynnada that this feature should have tests before we merge it. Since maintainer bandwidth is the most limited resource in this project, I suspect we might be waiting a while if we wait for a maintainer help write tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
djellemah commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2781596717 I've added commits to address the CI failures. Of course you're welcome to add some tests to not break these features in the future :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
alamb commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2781418624 This PR has several CI failures so marking as a draft while they are addressed. (I do this to make it easier to see what PRs are waiting on review) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Use pager and allow configuration via `\pset` [datafusion]
berkaysynnada commented on PR #15597: URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2781391914 @djellemah thank you for working on this! Can we also add some tests to not break these features in the future? and there are some failures in CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
