Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-08-13 Thread via GitHub 


Dimchikkk commented on PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#issuecomment-3183179132

   @Jefffrey yeah, you can take it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-08-12 Thread via GitHub 


Jefffrey commented on PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#issuecomment-3182124169

   @Dimchikkk would you be able to pick up the work involving upgrade to 0.58 
as mentioned? Otherwise I can build upon your work here to get this PR over the 
line 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-24 Thread via GitHub 


alamb commented on PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#issuecomment-3114784536

   0.58.0 is released: 
https://github.com/apache/datafusion-sqlparser-rs/issues/1886#issuecomment-3114709826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-18 Thread via GitHub 


crepererum commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2216026026


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   Just for the record: I'm OK with version jumping (i.e. directly upgrading to 
0.58). I was just hoping that the intermediate step would be easier for 
@Dimchikkk or whoever is gonna pick this up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-18 Thread via GitHub 


Dimchikkk commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2215987842


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   @alamb yeah, it's definitely not a semver compatible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-18 Thread via GitHub 


alamb commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2215925032


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   I think it is impossible to backport the fix in a semver compatible way. See 
 https://github.com/apache/datafusion-sqlparser-rs/issues/1952
   
   I will instead accelerate the timeline for releasing 0.58.0



##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   I think it is impossible to backport the fix in a semver compatible way. See 
 https://github.com/apache/datafusion-sqlparser-rs/issues/1952
   
   I will instead accelerate the timeline for releasing 0.58.0
   - https://github.com/apache/datafusion-sqlparser-rs/issues/1886



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-17 Thread via GitHub 


alamb commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2214358059


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   I will work on the release tomorrow -- hopefully we'll have it released by 
early next week



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-17 Thread via GitHub 


Dimchikkk commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2214246096


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   @crepererum thanks for creating the issue for releasing 0.56.1!
   
   I changed the link to my personal repo just to test that all CI checks pass, 
surely I change it back to official 0.56.1 once it is released.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-17 Thread via GitHub 


crepererum commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2213133593


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   I think not jumping multiple releases would be nice, so I've filed 
https://github.com/apache/datafusion-sqlparser-rs/issues/1952



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-17 Thread via GitHub 


alamb commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2213096517


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   I think publishing a 0.56.1 release of sqlparser makes sense to me. Perhaps 
we can file a ticket in the sqlparser repo to track.
   
   I am happy to run the process
   
   Another alternative is to release the next release (0.57.0) and just skip 
0.56.0 entirely in Datafusion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-17 Thread via GitHub 


crepererum commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2212938215


##
Cargo.toml:
##
@@ -167,7 +167,10 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.55.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = [

Review Comment:
   As an apache project, we should probably not depend on a personal repository 
where an individual controls the branches without any additional checks -- not 
because I personally distrust you but because the OSS world has seen its fair 
share of supply chain attacks and we should use best practice. I see two 
options forward:
   
   - use a branch within the apache org repo instead of your personal one
   - actually publish a 0.56.1 backport release to crates.io
   
   I would prefer the 2nd option. CC @alamb 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-02 Thread via GitHub 


Dimchikkk commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2181032563


##
Cargo.toml:
##
@@ -167,7 +167,7 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.56.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = ["std", "visitor"] }

Review Comment:
   `FIXME`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] chore(deps): Update sqlparser to 0.56 [datafusion]

2025-07-02 Thread via GitHub 


Dimchikkk commented on code in PR #16456:
URL: https://github.com/apache/datafusion/pull/16456#discussion_r2181032563


##
Cargo.toml:
##
@@ -167,7 +167,7 @@ recursive = "0.1.1"
 regex = "1.8"
 rstest = "0.25.0"
 serde_json = "1"
-sqlparser = { version = "0.56.0", default-features = false, features = ["std", 
"visitor"] }
+sqlparser = { git = 
"https://github.com/Dimchikkk/datafusion-sqlparser-rs.git";, branch = "v0.56.1", 
default-features = false, features = ["std", "visitor"] }

Review Comment:
   FIXME`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]