Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
adriangbot commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259331509 🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21670#issuecomment-4259202471) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) CPU Details (lscpu) ``` Architecture:aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping:r0p1 BogoMIPS:2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache:32 MiB (16 instances) L3 cache:80 MiB (1 instance) NUMA node(s):1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling:Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1:Mitigation; __user pointer sanitization Vulnerability Spectre v2:Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` Details ``` Comparing HEAD and ahmed_bump-tokio Benchmark clickbench_partitioned.json ┏━━━┳━━━┳━━━┳━━━┓ ┃ Query ┃ HEAD ┃ ahmed_bump-tokio ┃Change ┃ ┡━━━╇━━━╇━━━╇━━━┩ │ QQuery 0 │ 1.22 / 4.54 ±6.48 / 17.49 ms │ 1.22 / 4.50 ±6.43 / 17.37 ms │ no change │ │ QQuery 1 │14.19 / 14.64 ±0.26 / 14.96 ms │15.36 / 15.60 ±0.15 / 15.77 ms │ 1.07x slower │ │ QQuery 2 │44.02 / 44.29 ±0.20 / 44.59 ms │45.48 / 45.83 ±0.30 / 46.19 ms │ no change │ │ QQuery 3 │42.05 / 45.34 ±2.45 / 48.01 ms │41.17 / 41.47 ±0.33 / 42.03 ms │ +1.09x faster │ │ QQuery 4 │ 287.49 / 295.70 ±6.58 / 302.12 ms │ 292.01 / 301.20 ±8.99 / 317.11 ms │ no change │ │ QQuery 5 │ 340.38 / 346.20 ±3.48 / 349.92 ms │ 344.63 / 351.48 ±6.13 / 362.77 ms │ no change │ │ QQuery 6 │ 4.89 / 6.19 ±0.85 / 7.34 ms │ 4.88 / 5.78 ±0.89 / 7.28 ms │ +1.07x faster │ │ QQuery 7 │16.56 / 16.81 ±0.15 / 16.99 ms │17.58 / 18.66 ±0.69 / 19.58 ms │ 1.11x slower │ │ QQuery 8 │ 421.65 / 426.82 ±2.73 / 429.32 ms │ 416.43 / 426.00 ±7.36 / 436.43 ms │ no change │ │ QQuery 9 │ 646.41 / 661.94 ±9.73 / 672.66 ms │ 657.45 / 673.40 ±9.38 / 686.06 ms │ no change │ │ QQuery 10 │91.92 / 94.50 ±2.51 / 98.21 ms │ 95.65 / 97.99 ±2.53 / 102.50 ms │ no change │ │ QQuery 11 │ 105.10 / 106.23 ±1.04 / 108.09 ms │ 109.60 / 110.54 ±0.87 / 112.07 ms │ no change │ │ QQuery 12 │ 341.94 / 346.62 ±4.00 / 352.20 ms │ 341.19 / 347.32 ±7.16 / 360.73 ms │ no change │ │ QQuery 13 │460.82 / 473.57 ±14.56 / 501.82 ms │ 461.10 / 469.11 ±6.22 / 476.20 ms │ no change │ │ QQuery 14 │ 346.25 / 350.14 ±3.61 / 356.57 ms │ 352.07 / 358.34 ±3.81 / 363.15 ms │ no change │ │ QQuery 15 │
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
adriangbot commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259328747 🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/21670#issuecomment-4259202471) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) CPU Details (lscpu) ``` Architecture:aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping:r0p1 BogoMIPS:2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache:32 MiB (16 instances) L3 cache:80 MiB (1 instance) NUMA node(s):1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling:Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1:Mitigation; __user pointer sanitization Vulnerability Spectre v2:Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` Details ``` Comparing HEAD and ahmed_bump-tokio Benchmark tpcds_sf1.json ┏━━━┳━━┳━━┳━━━┓ ┃ Query ┃ HEAD ┃ ahmed_bump-tokio ┃Change ┃ ┡━━━╇━━╇━━╇━━━┩ │ QQuery 1 │ 6.88 / 7.49 ±0.77 / 8.99 ms │ 6.59 / 7.01 ±0.72 / 8.45 ms │ +1.07x faster │ │ QQuery 2 │145.74 / 147.18 ±1.10 / 148.77 ms │144.33 / 145.25 ±0.83 / 146.42 ms │ no change │ │ QQuery 3 │113.83 / 115.11 ±0.98 / 116.49 ms │112.77 / 113.62 ±0.78 / 115.07 ms │ no change │ │ QQuery 4 │1375.54 / 1422.09 ±26.79 / 1446.91 ms │ 1356.55 / 1374.47 ±9.78 / 1384.62 ms │ no change │ │ QQuery 5 │172.64 / 174.45 ±1.45 / 176.48 ms │172.51 / 173.78 ±1.22 / 175.35 ms │ no change │ │ QQuery 6 │ 813.03 / 868.56 ±35.61 / 923.89 ms │ 855.76 / 889.10 ±23.08 / 920.75 ms │ no change │ │ QQuery 7 │343.40 / 344.34 ±0.79 / 345.68 ms │343.91 / 347.58 ±4.32 / 355.89 ms │ no change │ │ QQuery 8 │116.62 / 116.90 ±0.37 / 117.63 ms │115.75 / 116.76 ±0.86 / 117.85 ms │ no change │ │ QQuery 9 │100.43 / 103.86 ±2.42 / 106.35 ms │100.22 / 104.66 ±2.92 / 107.75 ms │ no change │ │ QQuery 10 │105.97 / 107.33 ±0.75 / 108.15 ms │107.90 / 108.57 ±0.56 / 109.29 ms │ no change │ │ QQuery 11 │ 925.93 / 967.54 ±23.27 / 989.34 ms │ 968.29 / 1003.21 ±30.32 / 1041.01 ms │ no change │ │ QQuery 12 │ 45.88 / 47.22 ±0.86 / 48.14 ms │ 46.15 / 47.36 ±0.86 / 48.73 ms │ no change │ │ QQuery 13 │400.43 / 405.35 ±3.19 / 410.45 ms │400.74 / 409.91 ±6.28 / 418.56 ms │ no change │ │ QQuery 14 │ 995.03 / 1005.83 ±10.23 / 1021.34 ms │ 1002.93 / 1013.74 ±6.04 / 1019.86 ms │ no change │ │ QQuery 15 │ 16.33 / 17.40 ±
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
adriangbot commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259220997 🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21670#issuecomment-4259202471) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4259202471-1349-m9sz6 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux` CPU Details (lscpu) ``` Architecture:aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping:r0p1 BogoMIPS:2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache:32 MiB (16 instances) L3 cache:80 MiB (1 instance) NUMA node(s):1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling:Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1:Mitigation; __user pointer sanitization Vulnerability Spectre v2:Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` Comparing ahmed/bump-tokio (c41fd8147c8ccea4b2f5cd3403630724eb44d8e4) to a0dbbab (merge-base) [diff](https://github.com/apache/datafusion/compare/a0dbbab5849596ecb3db48d9e168f247155209e1..c41fd8147c8ccea4b2f5cd3403630724eb44d8e4) using: clickbench_partitioned Results will be posted here when complete --- [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
adriangbot commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259219797 🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21670#issuecomment-4259202471) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4259202471-1350-z229m 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux` CPU Details (lscpu) ``` Architecture:aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping:r0p1 BogoMIPS:2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache:32 MiB (16 instances) L3 cache:80 MiB (1 instance) NUMA node(s):1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling:Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1:Mitigation; __user pointer sanitization Vulnerability Spectre v2:Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` Comparing ahmed/bump-tokio (c41fd8147c8ccea4b2f5cd3403630724eb44d8e4) to a0dbbab (merge-base) [diff](https://github.com/apache/datafusion/compare/a0dbbab5849596ecb3db48d9e168f247155209e1..c41fd8147c8ccea4b2f5cd3403630724eb44d8e4) using: tpcds Results will be posted here when complete --- [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
adriangbot commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259216400 🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/21670#issuecomment-4259202471) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c4259202471-1351-9djbm 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux` CPU Details (lscpu) ``` Architecture:aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping:r0p1 BogoMIPS:2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache:32 MiB (16 instances) L3 cache:80 MiB (1 instance) NUMA node(s):1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling:Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1:Mitigation; __user pointer sanitization Vulnerability Spectre v2:Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` Comparing ahmed/bump-tokio (c41fd8147c8ccea4b2f5cd3403630724eb44d8e4) to a0dbbab (merge-base) [diff](https://github.com/apache/datafusion/compare/a0dbbab5849596ecb3db48d9e168f247155209e1..c41fd8147c8ccea4b2f5cd3403630724eb44d8e4) using: tpch Results will be posted here when complete --- [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
Dandandan commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259204575 Also https://github.com/tokio-rs/tokio/pull/7757 seems it might be significant for us -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
Dandandan commented on PR #21670: URL: https://github.com/apache/datafusion/pull/21670#issuecomment-4259202471 run benchmarks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
gabotechs merged PR #21670: URL: https://github.com/apache/datafusion/pull/21670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
gabotechs commented on code in PR #21670:
URL: https://github.com/apache/datafusion/pull/21670#discussion_r3092316035
##
Cargo.toml:
##
@@ -192,7 +192,7 @@ strum = "0.28.0"
strum_macros = "0.28.0"
tempfile = "3"
testcontainers-modules = { version = "0.15" }
-tokio = { version = "1.51", features = ["macros", "rt", "sync"] }
+tokio = { version = "1.52", features = ["macros", "rt", "sync"] }
Review Comment:
I did some digging, and it seems that Dependabot is configured in this
project with a very aggressive minimum minor supported version for dependencies.
Actually, `tokio` itself was just bumped last week in
https://github.com/apache/datafusion/pull/21435/changes#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L195-R195.
While this is not the configuration I'd recommend for a project, it's what
we have today in DataFusion, so this PR should be good to go 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
gabotechs commented on code in PR #21670:
URL: https://github.com/apache/datafusion/pull/21670#discussion_r3092316035
##
Cargo.toml:
##
@@ -192,7 +192,7 @@ strum = "0.28.0"
strum_macros = "0.28.0"
tempfile = "3"
testcontainers-modules = { version = "0.15" }
-tokio = { version = "1.51", features = ["macros", "rt", "sync"] }
+tokio = { version = "1.52", features = ["macros", "rt", "sync"] }
Review Comment:
I did some digging, and it seems that Dependabot is configured in this
project with a very aggressive minimum minor supported version for dependencies.
Actually, `tokio` itself was just bumped some weeks ago in
https://github.com/apache/datafusion/pull/21435/changes#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L195-R195.
While this is not the configuration I'd recommend for a project, it's what
we have today in DataFusion, so this PR should be good to go 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
ahmed-mez commented on code in PR #21670:
URL: https://github.com/apache/datafusion/pull/21670#discussion_r3092208416
##
Cargo.toml:
##
@@ -192,7 +192,7 @@ strum = "0.28.0"
strum_macros = "0.28.0"
tempfile = "3"
testcontainers-modules = { version = "0.15" }
-tokio = { version = "1.51", features = ["macros", "rt", "sync"] }
+tokio = { version = "1.52", features = ["macros", "rt", "sync"] }
Review Comment:
Agreed, no issues at all. This is just an anticipation to keep the fork
aligned with upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] chore(deps): update tokio from 1.51 to 1.52 [datafusion]
gabotechs commented on code in PR #21670:
URL: https://github.com/apache/datafusion/pull/21670#discussion_r3092179794
##
Cargo.toml:
##
@@ -192,7 +192,7 @@ strum = "0.28.0"
strum_macros = "0.28.0"
tempfile = "3"
testcontainers-modules = { version = "0.15" }
-tokio = { version = "1.51", features = ["macros", "rt", "sync"] }
+tokio = { version = "1.52", features = ["macros", "rt", "sync"] }
Review Comment:
This should be fine 👍, but just want to double check something first:
The `tokio = "1.51"` version declaration in DataFusion is already compatible
with consumers having `tokio = "1.52"` on their project, meaning that you
should be already able use `tokio = "1.52"` in your codebase depending on
DataFusion without this PR. In other words, having `tokio = "1.51"` here is
like DataFusion saying to the outside world "I support `tokio` 1.X as long as X
>= 51"
Did you find any issues with that that require bumping the minimum supported
version here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
