Re: [PR] chore: [comet-parquet-exec] Unit test fixes, default scan impl to comet_native [datafusion-comet]
parthchandra commented on PR #1265: URL: https://github.com/apache/datafusion-comet/pull/1265#issuecomment-2585536874 Added the plans for Spark 4.0 for the NATIVE_DATAFUSION and NATIVE_ICEBERG_COMPAT scans -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] chore: [comet-parquet-exec] Unit test fixes, default scan impl to comet_native [datafusion-comet]
parthchandra commented on PR #1265: URL: https://github.com/apache/datafusion-comet/pull/1265#issuecomment-2585079878 Updated the plns for Spark 3.5 and Spark 4.0. However plan generation for the native_datafusion impl is failing which will not affect the ci, but which needs to be addressed at some point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] chore: [comet-parquet-exec] Unit test fixes, default scan impl to comet_native [datafusion-comet]
parthchandra commented on PR #1265: URL: https://github.com/apache/datafusion-comet/pull/1265#issuecomment-2584878525 > > @parthchandra could you run `cargo fmt` and `cargo clippy` > > and `make format` .. that is if we want to see tests passing on this PR, which I think they should now? Or do we want to wait until we PR comet-parquet-exec against main before trying to get CI green? Fixed the build. Yes, we should get the CI to turn green with this PR before we attempt any more changes to the feature branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] chore: [comet-parquet-exec] Unit test fixes, default scan impl to comet_native [datafusion-comet]
andygrove commented on PR #1265: URL: https://github.com/apache/datafusion-comet/pull/1265#issuecomment-2584726893 > @parthchandra could you run `cargo fmt` and `cargo clippy` and `make format` .. that is if we want to see tests passing on this PR, which I think they should now? Or do we want to wait until we PR comet-parquet-exec against main before trying to get CI green? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
