Re: [PR] chore: Reenable nested types for CometFuzzTestSuite with int96 [datafusion-comet]
andygrove merged PR #1761: URL: https://github.com/apache/datafusion-comet/pull/1761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Reenable nested types for CometFuzzTestSuite with int96 [datafusion-comet]
mbutrovich commented on PR #1761: URL: https://github.com/apache/datafusion-comet/pull/1761#issuecomment-2897584536 > Perhaps this PR should also remove this item from the compatibility guide? > > ``` > - Reading legacy INT96 timestamps contained within complex types can produce different results to Spark > ``` Good catch, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Reenable nested types for CometFuzzTestSuite with int96 [datafusion-comet]
codecov-commenter commented on PR #1761: URL: https://github.com/apache/datafusion-comet/pull/1761#issuecomment-2896101349 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1761?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 57.24%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8580510`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/85805105f195264d57e112683f19413ebb001ca6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 201 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1761 +/- ## + Coverage 56.12% 57.24% +1.11% - Complexity 976 1068 +92 Files 119 130 +11 Lines 1174312578 +835 Branches 2251 2354 +103 + Hits 6591 7200 +609 - Misses 4012 4178 +166 - Partials 1140 1200 +60 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1761?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Reenable nested types for CometFuzzTestSuite with int96 [datafusion-comet]
andygrove commented on PR #1761: URL: https://github.com/apache/datafusion-comet/pull/1761#issuecomment-2896038701 Perhaps this PR should also remove this item from the compatibility guide? ``` - Reading legacy INT96 timestamps contained within complex types can produce different results to Spark ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Reenable nested types for CometFuzzTestSuite with int96 [datafusion-comet]
mbutrovich commented on PR #1761: URL: https://github.com/apache/datafusion-comet/pull/1761#issuecomment-2895978064 This should be ready for review now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Reenable nested types for CometFuzzTestSuite with int96 [datafusion-comet]
mbutrovich commented on code in PR #1761:
URL: https://github.com/apache/datafusion-comet/pull/1761#discussion_r2098673404
##
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##
@@ -220,12 +220,7 @@ class CometFuzzTestSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
test("Parquet temporal types written as INT96") {
-// int96 coercion in DF does not work with nested types yet
-// https://github.com/apache/datafusion/issues/15763
-testParquetTemporalTypes(
- ParquetOutputTimestampType.INT96,
- generateArray = false,
- generateStruct = false)
+testParquetTemporalTypes(ParquetOutputTimestampType.INT96)
Review Comment:
This is the only change on top of #1710.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
