Re: [PR] chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 [datafusion-comet]
andygrove commented on PR #1870: URL: https://github.com/apache/datafusion-comet/pull/1870#issuecomment-2968083119 These changes already got merged in https://github.com/apache/datafusion-comet/pull/1869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 [datafusion-comet]
andygrove closed pull request #1870: chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 URL: https://github.com/apache/datafusion-comet/pull/1870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 [datafusion-comet]
andygrove commented on code in PR #1870: URL: https://github.com/apache/datafusion-comet/pull/1870#discussion_r2142666410 ## .github/workflows/pr_build_linux.yml: ## @@ -74,14 +74,14 @@ jobs: maven_opts: "-Pspark-3.4 -Pscala-2.12" scan_impl: "native_comet" - - name: "Spark 3.5, JDK 11, Scala 2.12" -java_version: "17" -maven_opts: "-Pspark-3.5 -Pscala-2.12" + - name: "Spark 3.5.4, JDK 11, Scala 2.12" Review Comment: These profiles are testing `native_comet` with Spark 3.5. My goal with these changes was to continue testing 3.5.4, 3.5.5, and 3.5.6 without adding any additional jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 [datafusion-comet]
parthchandra commented on code in PR #1870: URL: https://github.com/apache/datafusion-comet/pull/1870#discussion_r2141326158 ## .github/workflows/pr_build_linux.yml: ## @@ -74,14 +74,14 @@ jobs: maven_opts: "-Pspark-3.4 -Pscala-2.12" scan_impl: "native_comet" - - name: "Spark 3.5, JDK 11, Scala 2.12" -java_version: "17" -maven_opts: "-Pspark-3.5 -Pscala-2.12" + - name: "Spark 3.5.4, JDK 11, Scala 2.12" Review Comment: Should we remove these profiles? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 [datafusion-comet]
andygrove commented on PR #1870: URL: https://github.com/apache/datafusion-comet/pull/1870#issuecomment-2963221219 CI failure is unrelated: https://github.com/apache/datafusion-comet/issues/1871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Stop Running Spark SQL tests for Spark 3.5.4 and 3.5.5 [datafusion-comet]
codecov-commenter commented on PR #1870: URL: https://github.com/apache/datafusion-comet/pull/1870#issuecomment-2960634456 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1870?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 32.17%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b620ab8`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/b620ab817cec7922008b417cac1b50d4fde76be4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 250 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1870 +/- ## = - Coverage 56.12% 32.17% -23.96% + Complexity 976 651 -325 = Files 119 130 +11 Lines 1174312653 +910 Branches 2251 2358 +107 = - Hits 6591 4071 -2520 - Misses 4012 7792 +3780 + Partials 1140 790 -350 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1870?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
