Re: [PR] chore: enable map_values testing since we fall back on nested types for defa… [datafusion-comet]
comphead closed pull request #1813: chore: enable map_values testing since we fall back on nested types for defa… URL: https://github.com/apache/datafusion-comet/pull/1813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: enable map_values testing since we fall back on nested types for defa… [datafusion-comet]
comphead commented on PR #1813: URL: https://github.com/apache/datafusion-comet/pull/1813#issuecomment-2951293667 Closing this PR in favor of #1835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: enable map_values testing since we fall back on nested types for defa… [datafusion-comet]
zhuqi-lucas commented on PR #1813: URL: https://github.com/apache/datafusion-comet/pull/1813#issuecomment-2920887659 Thank you @comphead for explain! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: enable map_values testing since we fall back on nested types for defa… [datafusion-comet]
comphead commented on PR #1813: URL: https://github.com/apache/datafusion-comet/pull/1813#issuecomment-2920847666 @zhuqi-lucas The problem is not in map_values it is deeper problem with reader itself, I provided some investigation details in https://github.com/apache/datafusion-comet/issues/1789#issuecomment-2920846368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: enable map_values testing since we fall back on nested types for defa… [datafusion-comet]
codecov-commenter commented on PR #1813: URL: https://github.com/apache/datafusion-comet/pull/1813#issuecomment-2919942250 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1813?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 49.80%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3bce824`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/3bce824fa15aa62a66acab07bcbe17d2238566c7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 225 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1813 +/- ## - Coverage 56.12% 49.80% -6.32% + Complexity 976 907 -69 Files 119 129 +10 Lines 1174312508 +765 Branches 2251 2350 +99 - Hits 6591 6230 -361 - Misses 4012 5112+1100 - Partials 1140 1166 +26 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1813?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: enable map_values testing since we fall back on nested types for defa… [datafusion-comet]
zhuqi-lucas commented on PR #1813: URL: https://github.com/apache/datafusion-comet/pull/1813#issuecomment-2919840718 Thank you @mbutrovich for review, i just noticed some fix in apache datafusion is in progress. https://github.com/apache/datafusion/pull/16203 But it seems we already fall back to spark map functions, so i reenable it now. After we change to comet execution, we can also keep it to see if it's fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
