Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
comphead merged PR #16119: URL: https://github.com/apache/datafusion/pull/16119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
patrickcsullivan commented on code in PR #16119:
URL: https://github.com/apache/datafusion/pull/16119#discussion_r2101301182
##
datafusion/core/src/lib.rs:
##
@@ -311,9 +311,9 @@
//! ```
//!
//! A [`TableProvider`] provides information for planning and
-//! an [`ExecutionPlan`]s for execution. DataFusion includes [`ListingTable`],
+//! an [`ExecutionPlan`] for execution. DataFusion includes [`ListingTable`],
//! a [`TableProvider`] which reads individual files or directories of files
-//! ("partitioned datasets") of several common file formats. Uses can add
+//! ("partitioned datasets") of several common file formats. Users can add
Review Comment:
Thanks! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
patrickcsullivan commented on code in PR #16119: URL: https://github.com/apache/datafusion/pull/16119#discussion_r2101295764 ## datafusion/core/src/lib.rs: ## @@ -488,16 +488,16 @@ //! DataFusion automatically runs each plan with multiple CPU cores using //! a [Tokio] [`Runtime`] as a thread pool. While tokio is most commonly used //! for asynchronous network I/O, the combination of an efficient, work-stealing -//! scheduler and first class compiler support for automatic continuation -//! generation (`async`), also makes it a compelling choice for CPU intensive +//! scheduler, and first class compiler support for automatic continuation +//! generation (`async`) also makes it a compelling choice for CPU intensive //! applications as explained in the [Using Rustlang’s Async Tokio //! Runtime for CPU-Bound Tasks] blog. //! //! The number of cores used is determined by the `target_partitions` //! configuration setting, which defaults to the number of CPU cores. //! While preparing for execution, DataFusion tries to create this many distinct //! `async` [`Stream`]s for each `ExecutionPlan`. -//! The `Stream`s for certain `ExecutionPlans`, such as as [`RepartitionExec`] +//! The `Stream`s for certain `ExecutionPlan`s, such as [`RepartitionExec`] Review Comment: Thanks for pointing that out. I made your suggested change and also added some other missing intra-doc links as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
comphead commented on code in PR #16119: URL: https://github.com/apache/datafusion/pull/16119#discussion_r2098954205 ## datafusion/core/src/lib.rs: ## @@ -488,16 +488,16 @@ //! DataFusion automatically runs each plan with multiple CPU cores using //! a [Tokio] [`Runtime`] as a thread pool. While tokio is most commonly used //! for asynchronous network I/O, the combination of an efficient, work-stealing -//! scheduler and first class compiler support for automatic continuation -//! generation (`async`), also makes it a compelling choice for CPU intensive +//! scheduler, and first class compiler support for automatic continuation +//! generation (`async`) also makes it a compelling choice for CPU intensive //! applications as explained in the [Using Rustlang’s Async Tokio //! Runtime for CPU-Bound Tasks] blog. //! //! The number of cores used is determined by the `target_partitions` //! configuration setting, which defaults to the number of CPU cores. //! While preparing for execution, DataFusion tries to create this many distinct //! `async` [`Stream`]s for each `ExecutionPlan`. -//! The `Stream`s for certain `ExecutionPlans`, such as as [`RepartitionExec`] +//! The `Stream`s for certain `ExecutionPlan`s, such as [`RepartitionExec`] Review Comment: ```suggestion //! The `Stream`s for certain [`ExecutionPlan`]s, such as [`RepartitionExec`] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
comphead commented on code in PR #16119:
URL: https://github.com/apache/datafusion/pull/16119#discussion_r2098957264
##
datafusion/core/src/lib.rs:
##
@@ -311,9 +311,9 @@
//! ```
//!
//! A [`TableProvider`] provides information for planning and
-//! an [`ExecutionPlan`]s for execution. DataFusion includes [`ListingTable`],
+//! an [`ExecutionPlan`] for execution. DataFusion includes [`ListingTable`],
//! a [`TableProvider`] which reads individual files or directories of files
-//! ("partitioned datasets") of several common file formats. Uses can add
+//! ("partitioned datasets") of several common file formats. Users can add
Review Comment:
```suggestion
//! ("partitioned datasets") of the same file format. Users can add
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
patrickcsullivan commented on code in PR #16119: URL: https://github.com/apache/datafusion/pull/16119#discussion_r2098899042 ## datafusion/core/src/lib.rs: ## @@ -617,8 +617,8 @@ //! The state required to execute queries is managed by the following //! structures: //! -//! 1. [`SessionContext`]: State needed for create [`LogicalPlan`]s such -//!as the table definitions, and the function registries. +//! 1. [`SessionContext`]: State needed for creating [`LogicalPlan`]s such Review Comment: That sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs: Fix typos and minor grammatical issues in Architecture docs [datafusion]
findepi commented on code in PR #16119: URL: https://github.com/apache/datafusion/pull/16119#discussion_r2098815968 ## datafusion/core/src/lib.rs: ## @@ -617,8 +617,8 @@ //! The state required to execute queries is managed by the following //! structures: //! -//! 1. [`SessionContext`]: State needed for create [`LogicalPlan`]s such -//!as the table definitions, and the function registries. +//! 1. [`SessionContext`]: State needed for creating [`LogicalPlan`]s such Review Comment: "to create" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
