Re: [PR] feat: make error handling in indent explain consistent with that in tree [datafusion]
alamb merged PR #16097: URL: https://github.com/apache/datafusion/pull/16097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] feat: make error handling in indent explain consistent with that in tree [datafusion]
chenkovsky commented on code in PR #16097:
URL: https://github.com/apache/datafusion/pull/16097#discussion_r2096658640
##
datafusion/core/src/physical_planner.rs:
##
@@ -1757,6 +1757,12 @@ impl DefaultPhysicalPlanner {
)));
}
+if !e.logical_optimization_succeeded {
+if let Some(plan) = e.stringified_plans.last() {
Review Comment:
I modified implementation. If logical_optimization_succeeded is false. all
stringified_plans will be returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] feat: make error handling in indent explain consistent with that in tree [datafusion]
alamb commented on code in PR #16097:
URL: https://github.com/apache/datafusion/pull/16097#discussion_r2096013268
##
datafusion/core/src/physical_planner.rs:
##
@@ -1757,6 +1757,12 @@ impl DefaultPhysicalPlanner {
)));
}
+if !e.logical_optimization_succeeded {
+if let Some(plan) = e.stringified_plans.last() {
Review Comment:
I think the original intent was to still show the explain plan even if there
was an error
The idea was to show all the work that had happened so far (e.g. the plans)
to help debugging
I agree both explain modes should be consistent, but I suggest that instead
of erroring with `EXPLAIN FORMAT INDENT` instead we capture and report the
error in `EXPLAIN FORMAT TREE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
