Re: [PR] feat: optimize and unparse grouping [datafusion]
Slimsammylim commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3366066625 Hi, I ran my code using this branch and unfortunately it did not solve my issue (https://github.com/apache/datafusion/issues/16590). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
chenkovsky commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3368161956 I added substrait support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
chenkovsky commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3367555224 > Hi, I ran my code using this branch and unfortunately it did not solve my issue (https://github.com/apache/datafusion/issues/16590). hi，could you please push your code， then i can see what's your issue. currently i havent touch substrait， some extra codes should be modified to solve issue 16590. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
alamb commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3363067462 > Hi @alamb and @chenkovsky! I am running into the same issue @lorenarosati brought up a couple months ago (#16590) and have not found a workaround solution yet. Just wanted to check in, what's the status of this PR? I am waiting for someone to help review the PR. Can you help here @Slimsammylim ? Perhaps verify that this solution fixes your issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
Slimsammylim commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3361517517 Hi @alamb and @chenkovsky! I am running into the same issue @lorenarosati brought up a couple months ago (https://github.com/apache/datafusion/issues/16590) and have not found a workaround solution yet. Just wanted to check in, what's the status of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
alamb commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3297976536 Thanks @chenkovsky @eejbyfeldt it looks like you contributed the initial implementation of `grouping` in https://github.com/apache/datafusion/pull/12704 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
chenkovsky commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3289341290 keep it open -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
github-actions[bot] commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-3289089870 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
alamb commented on code in PR #16161:
URL: https://github.com/apache/datafusion/pull/16161#discussion_r2164876290
##
datafusion/sql/Cargo.toml:
##
@@ -48,6 +48,7 @@ arrow = { workspace = true }
bigdecimal = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-expr = { workspace = true }
+datafusion-functions-aggregate = { workspace = true }
Review Comment:
We have tried hard to avoid having the sql parser depend on function
libraries -- is there any way to avoid changing this dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
eejbyfeldt commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2981365745 I did not look closely at yet since I have not really contributed here in months. > there are three projections. for bitwise operation, there's no benifit for extra projection. This extra projection is introduced by `CommonSubexprEliminate`. I understand that the changes make it so that they do not interact in the presented query, but is this really a general fix of that behavior? But the goal of leaving more structure in logical plan after resolving the grouping expr so that optimization and unparsing sounds reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
chenkovsky commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2906804315 it's related to #12704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
chenkovsky commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2906801006 @eejbyfeldt could you please help me review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat: optimize and unparse grouping [datafusion]
alamb commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2906786682 Thanks @chenkovsky -- can. you find the original PR that added this `GROUPING` function and perhaps @ mention the author to see if they have any feedback / could help with review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
