Re: [PR] fix: enable one more filter pushdown test for iceberg_compat [datafusion-comet]

2025-06-25 Thread via GitHub


parthchandra closed pull request #1931: fix: enable one more filter pushdown 
test for iceberg_compat
URL: https://github.com/apache/datafusion-comet/pull/1931


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] fix: enable one more filter pushdown test for iceberg_compat [datafusion-comet]

2025-06-25 Thread via GitHub


parthchandra commented on PR #1931:
URL: 
https://github.com/apache/datafusion-comet/pull/1931#issuecomment-3006653030

   Doesn't look like this is right. Closing it and will reopen after I look at 
it again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] fix: enable one more filter pushdown test for iceberg_compat [datafusion-comet]

2025-06-25 Thread via GitHub


codecov-commenter commented on PR #1931:
URL: 
https://github.com/apache/datafusion-comet/pull/1931#issuecomment-3005663181

   ## 
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1931?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 33.53%. Comparing base 
[(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`5406f9c`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/5406f9ca470a38f8a8eebf6dde8fe08699eef47e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 285 commits behind head on main.
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   main#1931   +/-   ##
   =
   - Coverage 56.12%   33.53%   -22.60% 
   + Complexity  976  803  -173 
   =
 Files   119  130   +11 
 Lines 1174312853 +1110 
 Branches   2251 2393  +142 
   =
   - Hits   6591 4310 -2281 
   - Misses 4012 7611 +3599 
   + Partials   1140  932  -208 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1931?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]