Re: [PR] verify TPC-DS results [datafusion]

2025-03-12 Thread via GitHub 


github-actions[bot] closed pull request #13791: verify TPC-DS results
URL: https://github.com/apache/datafusion/pull/13791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] verify TPC-DS results [datafusion]

2025-03-04 Thread via GitHub 


github-actions[bot] commented on PR #13791:
URL: https://github.com/apache/datafusion/pull/13791#issuecomment-2699544342

   Thank you for your contribution. Unfortunately, this pull request is stale 
because it has been open 60 days with no activity. Please remove the stale 
label or comment or this will be closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] verify TPC-DS results [datafusion]

2025-01-03 Thread via GitHub 


Lordworms commented on code in PR #13791:
URL: https://github.com/apache/datafusion/pull/13791#discussion_r1902127243


##
benchmarks/transfer_dat_parquet.py:
##


Review Comment:
   I'll refactor that, thanks a lot



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] verify TPC-DS results [datafusion]

2024-12-27 Thread via GitHub 


gruuya commented on code in PR #13791:
URL: https://github.com/apache/datafusion/pull/13791#discussion_r1898497745


##
benchmarks/transfer_dat_parquet.py:
##


Review Comment:
   I'm wondering if you used duckdb [tpc-ds 
extension](https://duckdb.org/docs/extensions/tpcds.html) to generate tpc-ds 
parquet files directly would it render this entire file redundant?
   
   Something along the lines of
   ```sql
   install tpcds;
   load tpcds;
   call dsdgen(sf=1000);
   ```
   
   And then for each table copy to Parquet, e.g.
   ```sql
   copy inventory to '/path/to/inventory.parquet' (format parquet)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] verify TPC-DS results [datafusion]

2024-12-27 Thread via GitHub 


gruuya commented on code in PR #13791:
URL: https://github.com/apache/datafusion/pull/13791#discussion_r1898497745


##
benchmarks/transfer_dat_parquet.py:
##


Review Comment:
   I'm wondering if you used duckdb connection to generate tpc-ds parquet files 
directly would it render this entire file redundant?
   
   Something along the lines of
   ```sql
   install tpcds;
   load tpcds;
   call dsdgen(sf=1000);
   ```
   
   And then for each table copy to Parquet, e.g.
   ```sql
   copy inventory to '/path/to/inventory.parquet' (format parquet)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] verify TPC-DS results [datafusion]

2024-12-27 Thread via GitHub 


gruuya commented on code in PR #13791:
URL: https://github.com/apache/datafusion/pull/13791#discussion_r1898497745


##
benchmarks/transfer_dat_parquet.py:
##


Review Comment:
   I'm wondering if you used duckdb python package to generate tpc-ds parquet 
files directly would it render this entire file redundant?
   
   Something along the lines of
   ```sql
   install tpcds;
   load tpcds;
   call dsdgen(sf=1000);
   ```
   
   And then for each table copy to Parquet, e.g.
   ```sql
   copy inventory to '/path/to/inventory.parquet' (format parquet)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]