[classlib] matching RI exceptions -- are we required to have this type of compatibility?

2006-04-23 Thread Mikhail Loenko
Look at HARMONY-387. Example: 1) java.io.ByteArrayOutputStream.write(byte[] b , int off, int len): Harmony throws ArrayIndexOutOfBoundsException when off<0 or/and len <0, while RI throws IndexOutOfBoundsException. Specification mentions neither ArrayIndexOutOfBoundsException nor IndexOutOfBoundsEx

Re: ITC's java.math package contribution

2006-04-23 Thread Vladimir Gorr
It means we should compare both implementations on the method-by-method base to understand where there is the performance degradation. Obviously new tests should be implemented for this purpose. Those methods look worse should be replaced if they have no internal representation's dependency. Now we

RE: ITC's java.math package contribution

2006-04-23 Thread Semukhina, Elena V
I'd like to confirm that BigDecimal's methods can be easily combined to get a new version that implements the best approaches from both implementations. The ITC's optimized "ten powering" is very fruitful and contributes significantly to the arithmetic methods performance. On the other hand, Intel'

Re: [classlib] String is special

2006-04-23 Thread bootjvm
> [Original Message] > From: Mikhail Loenko <[EMAIL PROTECTED]> > To: ; <[EMAIL PROTECTED]> > Date: 4/21/06 1:05:26 AM > Subject: Re: [classlib] String is special > > Why not put all the tests that control String's behavior to the suite? > > Are there any possible harmful differences that are unte

Re: Summer Of Code 2006 - Lets get Harmony involved

2006-04-23 Thread Mark Hindess
On 4/23/06, Robin Garner <[EMAIL PROTECTED]> wrote: > Tim Ellison wrote: > > >Sanket Sharma wrote: > > > > > >>Performance analysis sounds interesting... > >> > >>Any links/pointers to get started? > >> > >> > > > >I suggest that you look around for some simple well-written performance > >benchmark

Re: Do we mix up regression and unit tests?

2006-04-23 Thread Mark Hindess
On 4/23/06, Dmitry M. Kononov <[EMAIL PROTECTED]> wrote: > On 4/22/06, LvJimmy,Jing <[EMAIL PROTECTED]> wrote: > > In my understanding, if someone want to add some regression tests to test > > APIs, it > > can be added directly to the API test files if any, it is not necessary to > > open a new fi

Re: Do we mix up regression and unit tests?

2006-04-23 Thread Dmitry M. Kononov
On 4/22/06, LvJimmy,Jing <[EMAIL PROTECTED]> wrote: > In my understanding, if someone want to add some regression tests to test > APIs, it > can be added directly to the API test files if any, it is not necessary to > open a new file. I see. Could you please explain what is your understanding of

Re: ITC's java.math package contribution

2006-04-23 Thread Vladimir Gorr
If we will combine on ideas level new implementaion of java.math should appear. Both implementations use the D. Knuth's algorithms and nothing new. Yes, we can take the Big Decimal from HARMONY-199 and Big Integer from HARMONY-39 (or vice versa) and measure the performance. Other approach is to imp

Re: Do we mix up regression and unit tests?

2006-04-23 Thread Mikhail Loenko
2006/4/22, LvJimmy,Jing <[EMAIL PROTECTED]>: > Hi: >I take a look at the directory, it is really confusion. However > currently tests are put in luni/src/test/java/tests/api/java/net, I'm quite > sure that a unit test of api class method must be add to that directory. >And I'm not sure what

Re: ITC's java.math package contribution

2006-04-23 Thread Mikhail Loenko
I think it should be possible to combine on ideas level, not just the code. You may want to look at your counterpart's code from the following perspective: which ideas, tips, algorithms would you take to your code? Once we figured that out I think it would be easier to define next steps. Thanks,

Re: Summer Of Code 2006 - Lets get Harmony involved

2006-04-23 Thread Robin Garner
Tim Ellison wrote: Sanket Sharma wrote: Performance analysis sounds interesting... Any links/pointers to get started? I suggest that you look around for some simple well-written performance benchmarks for Java and see if you can get them running on Harmony. Not sure whether they

Re: ITC's java.math package contribution

2006-04-23 Thread Chris Gray
On Sunday 23 April 2006 02:07, Daniel Fridlender wrote: > I also agree with [Vladimir] that it would be really nice to have a > representative collection of realistic applications of the > functionality of java.math. RSA key generation is definitely one of > them. We should find more. That woul