[classlib][pack200] Moving pack200 to a separate module

2006-10-20 Thread Alex Blewitt
Moving from a different thread ... I'd like to move the pack200 to a separate buildable module, primarily so that it can be built as its own OSGi bundle and/or Jar, but also to separate it out from the archive so that e.g. internationalisation messages etc. don't need to get mixed in. There's a

Re: Re: [classlib][pack200] Moving pack200 to a separate module?

2006-10-15 Thread Alex Blewitt
Cool. I've attached patches for the stuff I've done up until now as well as rolling back the localisation stuff as a patch in HARMONY-1871. And, for some reason, I've accidentally created an empty HARMONY-1870 too ... Alex. On 15/10/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: I agree wit

Re: Re: [classlib][pack200] Moving pack200 to a separate module?

2006-10-15 Thread Alex Blewitt
Yeah, it would be easy enough to do :-) I've added some comments in the header of each file to that effect. As for the (indirect) ties with o.a.h.k.VM, that's just an implementation issue with the Messages class; it should be fairly easy to roll out a less specific one for the pack200 messages. A

Re: [classlib][pack200] Moving pack200 to a separate module?

2006-10-14 Thread Geir Magnusson Jr.
I'm assuming that the person just didn't know... Please put a readme into the root of the codebase so that these special circumstances are known by others (assuming someone doesn't have a big problem with it...) geir Alex Blewitt wrote: On a related note, it seems that some changes have been

Re: [classlib][pack200] Moving pack200 to a separate module?

2006-10-14 Thread Geir Magnusson Jr.
I agree with your motivations. Lets move it to the javatools/ part of the project when I get that done this weekend. As to the ties to o.a.h.k.VM, I'm sure we can work something out... geir Alex Blewitt wrote: I was in the process of trying to put together a patch for the new stuff that I'v

Re: [classlib][pack200] Moving pack200 to a separate module?

2006-10-14 Thread Alex Blewitt
On a related note, it seems that some changes have been committed that are using generics in the pack200 code. These will prevent it from being run on pre Java 1.5 systems, which again was one of my goals in writing this. I'll have to revert those changes, too ... Alex. On 15/10/06, Alex Blewitt

[classlib][pack200] Moving pack200 to a separate module?

2006-10-14 Thread Alex Blewitt
I was in the process of trying to put together a patch for the new stuff that I've added recently, and it turns out that someone's gone through and pulled out all of the hard-coded strings in the code and added a dependency on org.apache.harmony.archive.internal.nls.Messages, which in turn has a d