Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-21 Thread Alexei Zakharov
Hi Mikhail, BTW, there is a looking similar failure in the test o.a.h.beans.tests.java.beans.CustomizedPersistenceDelegateTest#testProxyPD :) It doesn't seem to be a completely similar failure to me. IMO the above test fails due the fact that we simply don't have persistence delegates for prox

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-16 Thread Mikhail Loenko
It works, thanks for the patch! BTW, there is a looking similar failure in the test o.a.h.beans.tests.java.beans.CustomizedPersistenceDelegateTest#testProxyPD :) Thanks, Mikhail 2006/8/16, Mikhail Loenko <[EMAIL PROTECTED]>: Sure! 2006/8/16, Alexei Zakharov <[EMAIL PROTECTED]>: > Mikhail, >

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-16 Thread Mikhail Loenko
Sure! 2006/8/16, Alexei Zakharov <[EMAIL PROTECTED]>: Mikhail, > But there are two remaining failures related to > Proxy. That area is completely new for me and I guess it's caused > by incorrect process of Object's methods including equals(). > Can you guys take a look? I have created HARMONY

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-16 Thread Alexei Zakharov
Mikhail, But there are two remaining failures related to Proxy. That area is completely new for me and I guess it's caused by incorrect process of Object's methods including equals(). Can you guys take a look? I have created HARMONY-1207 that fixes the above problem. Could you please take a lo

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Ilya Okomin
Alexei, Thanks for encouraging me! It's a great pleasure for me to take part in Harmony! :) Regards, Ilya. On 8/14/06, Alexei Zakharov <[EMAIL PROTECTED]> wrote: Ilya, > Thus test_setAsTextNull is redundant but > other two test cases have to be added. This is exactly what I mean. BTW, If y

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Alexei Zakharov
Hi Mikhail, You are not alone :) I beg you pardon, I meant mere mortals who speak patch+JIRA language :) BTW, I've managed to fix most of the failures in org.apache.harmony.beans.tests.java.beans.PropertyEditorSupportTest ... Can you guys take a look? Sure, I will look at it tomorrow. R

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Mikhail Loenko
2006/8/14, Alexei Zakharov <[EMAIL PROTECTED]>: Ilya, > Thus test_setAsTextNull is redundant but > other two test cases have to be added. This is exactly what I mean. BTW, If you have more patches (or free time) for java.beans you are highly welcome. I have already tired from working on this pa

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Alexei Zakharov
Ilya, Thus test_setAsTextNull is redundant but other two test cases have to be added. This is exactly what I mean. BTW, If you have more patches (or free time) for java.beans you are highly welcome. I have already tired from working on this package alone. :) Regards, 2006/8/14, Ilya Okomin <

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Ilya Okomin
On 8/14/06, Alexei Zakharov <[EMAIL PROTECTED]> wrote: Hi Ilya, FYI there is the existing class org.apache.harmony.beans.tests.java.beans.PropertyEditorSupportTest that contains all tests for PropertyEditorSupport. IMHO it would be better if you embed your tests into this class. BTW, you may al

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Alexei Zakharov
Hi Ilya, FYI there is the existing class org.apache.harmony.beans.tests.java.beans.PropertyEditorSupportTest that contains all tests for PropertyEditorSupport. IMHO it would be better if you embed your tests into this class. BTW, you may also take a look at existent testSetAsText method since it

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Ilya Okomin
Hello, Mikhail! Provided test case can work from classpath of course. It's my mistake, thanks for noticed it. I'll prepare updated test case' patch with correct packaging and taking into account exceptions handling recommendation ASAP. Thanks, Ilya. On 8/14/06, Mikhail Loenko <[EMAIL PROTECTED

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Stepan Mishura
BTW, don't forget to grant license to ASF. Thanks, Stepan. On 8/14/06, Mikhail Loenko wrote: Hi Ilya Is it significant that the test code is in bootclasspath, or it can work from classpath? There were some discussions around the tests that might be interesting, please look at [1]. Please l

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Mikhail Loenko
Hi Ilya Is it significant that the test code is in bootclasspath, or it can work from classpath? There were some discussions around the tests that might be interesting, please look at [1]. Please look at the section Utilize JUnit's assert/fail methods and exception handling for clean test code