[ibm-acpi-devel] [PATCH] leds: avoid races with workqueue

2019-04-29 Thread Pavel Machek
There are races between "main" thread and workqueue. They manifest themselves on Thinkpad X60: This should result in LED blinking, but it turns it off instead: root@amd:/data/pavel# cd /sys/class/leds/tpacpi\:\:power root@amd:/sys/class/leds/tpacpi::power# echo timer > trigger

[ibm-acpi-devel] [PATCH] leds: tpacpi: cleanup for Thinkpad ACPI led

2019-04-29 Thread Pavel Machek
Make error returns more consistent... no behaviour change intended. Signed-off-by: Pavel Machek diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 726341f..7008a7f 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/think

Re: [ibm-acpi-devel] Thinkpad ACPI led -- it keeps blinking

2019-04-29 Thread Pavel Machek
Hi! > >This fixes one problem: > >Signed-off-by: Pavel Machek > > > >diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > >index e3da7c0..d795d8f 100644 > >--- a/drivers/leds/led-core.c > >+++ b/drivers/leds/led-core.c > >@@ -164,8 +164,14 @@ static void led_blink_setup(struct led_cl