Re: [ibm-acpi-devel] [PATCH 17/24] platform/x86: thinkpad_acpi: Use correct keycodes for volume and brightness keys

2024-04-23 Thread Hans de Goede
Hi, On 4/21/24 9:11 PM, Andy Shevchenko wrote: > On Sun, Apr 21, 2024 at 6:45 PM Hans de Goede wrote: >> >> Change the default keymap to report the correct keycodes for the volume and >> brightness keys. Reporting key events for these is already filtered out by >> the hotkey_reserved_mask which m

Re: [ibm-acpi-devel] [PATCH 08/24] platform/x86: thinkpad_acpi: Move adaptive kbd event handling to tpacpi_driver_event()

2024-04-23 Thread Hans de Goede
Hi, On 4/22/24 10:29 AM, Ilpo Järvinen wrote: > On Sun, 21 Apr 2024, Hans de Goede wrote: > >> Factor out the adaptive kbd non hotkey event handling into >> adaptive_keyboard_change_row() and adaptive_keyboard_s_quickview_row() >> helpers and move the handling of TP_HKEY_EV_DFR_CHANGE_ROW and >>

Re: [ibm-acpi-devel] [PATCH 03/24] platform/x86: thinkpad_acpi: Drop setting send_/ignore_acpi_ev defaults twice

2024-04-23 Thread Hans de Goede
Hi, On 4/22/24 10:07 AM, Ilpo Järvinen wrote: > On Sun, 21 Apr 2024, Hans de Goede wrote: > >> send_acpi_ev, ignore_acpi_ev are already initialized to true resp. false by > > Wording here is odd (but I'm not native so could be I just don't > understand what "true resp. false" is supposed to mea

Re: [ibm-acpi-devel] [PATCH 08/24] platform/x86: thinkpad_acpi: Move adaptive kbd event handling to tpacpi_driver_event()

2024-04-23 Thread Hans de Goede
Hi Mark, On 4/23/24 2:15 PM, Mark Pearson wrote: > Hi Hans > > On Tue, Apr 23, 2024, at 4:35 AM, Hans de Goede wrote: >> Hi Mark, >> >> On 4/22/24 9:27 PM, Mark Pearson wrote: >>> Hi Hans, >>> >>> On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote: Factor out the adaptive kbd non hotkey

Re: [ibm-acpi-devel] [PATCH 08/24] platform/x86: thinkpad_acpi: Move adaptive kbd event handling to tpacpi_driver_event()

2024-04-23 Thread Mark Pearson
Hi Hans On Tue, Apr 23, 2024, at 4:35 AM, Hans de Goede wrote: > Hi Mark, > > On 4/22/24 9:27 PM, Mark Pearson wrote: >> Hi Hans, >> >> On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote: >>> Factor out the adaptive kbd non hotkey event handling into >>> adaptive_keyboard_change_row() and ada

Re: [ibm-acpi-devel] [PATCH 08/24] platform/x86: thinkpad_acpi: Move adaptive kbd event handling to tpacpi_driver_event()

2024-04-23 Thread Hans de Goede
Hi Mark, On 4/22/24 9:27 PM, Mark Pearson wrote: > Hi Hans, > > On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote: >> Factor out the adaptive kbd non hotkey event handling into >> adaptive_keyboard_change_row() and adaptive_keyboard_s_quickview_row() >> helpers and move the handling of TP_HK