Re: [ibm-acpi-devel] [PATCH v2 22/24] platform/x86: thinkpad_acpi: Support for trackpoint doubletap

2024-04-29 Thread Mark Pearson
On Mon, Apr 29, 2024, at 5:57 AM, Hans de Goede wrote: > Hi Mark, > > On 4/24/24 8:19 PM, Mark Pearson wrote: >> Hi Hans, >> >> On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote: >>> From: Mark Pearson >>> >>> Lenovo trackpoints are adding the ability to generate a doubletap event. >>> Thi

Re: [ibm-acpi-devel] [PATCH v2 00/24] platform/x86: thinkpad_acpi: Refactor hotkey handling and add support for some new hotkeys

2024-04-29 Thread Hans de Goede
Hi All, On 4/24/24 2:28 PM, Hans de Goede wrote: > Hi All, > > Here is v2 of my patch-series to refactor thinkpad_acpi's hotkey handling > and to add support for some new hotkeys on new models. > > Changes in v2: > - Some small code style tweaks in response to reviews > - Add various Reviewed-by

Re: [ibm-acpi-devel] [PATCH v2 22/24] platform/x86: thinkpad_acpi: Support for trackpoint doubletap

2024-04-29 Thread Hans de Goede
Hi Mark, On 4/24/24 8:19 PM, Mark Pearson wrote: > Hi Hans, > > On Wed, Apr 24, 2024, at 8:28 AM, Hans de Goede wrote: >> From: Mark Pearson >> >> Lenovo trackpoints are adding the ability to generate a doubletap event. >> This handles the doubletap event and sends the KEY_PROG4 event to >> user

Re: [ibm-acpi-devel] [PATCH v2 16/24] platform/x86: thinkpad_acpi: Change hotkey_reserved_mask initialization

2024-04-29 Thread Hans de Goede
Hi Ilpo, Thank you for reviewing this series. On 4/25/24 11:14 AM, Ilpo Järvinen wrote: > On Wed, 24 Apr 2024, Hans de Goede wrote: > >> Change the hotkey_reserved_mask initialization to hardcode the list >> of reserved keys. There are only a few reserved keys and the code to >> iterate over the

Re: [ibm-acpi-devel] [PATCH v2 04/24] platform/x86: thinkpad_acpi: Drop ignore_acpi_ev

2024-04-29 Thread Hans de Goede
Hi, On 4/25/24 9:13 AM, Ilpo Järvinen wrote: > On Wed, 24 Apr 2024, Hans de Goede wrote: > >> Setting ignore_acpi_ev to true has the same result as setting >> send_acpi_ev to false, so there is no need to have both. >> >> Drop ignore_acpi_ev. >> >> Tested-by: Mark Pearson >> Signed-off-by: Hans