Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-15 Thread Dmitry Torokhov
On Mon, Apr 15, 2024 at 04:28:19PM -0400, Mark Pearson wrote: > Hi > > On Mon, Apr 15, 2024, at 3:58 PM, Dmitry Torokhov wrote: > > On Mon, Apr 15, 2024 at 09:50:37PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 4/15/24 9:40 PM, Dmitry Torokhov w

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-15 Thread Dmitry Torokhov
On Mon, Apr 15, 2024 at 09:50:37PM +0200, Hans de Goede wrote: > Hi, > > On 4/15/24 9:40 PM, Dmitry Torokhov wrote: > > On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote: > >> > >> I have a stronger preference to keep the KEY_DOUBLECLICK - that one se

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-15 Thread Dmitry Torokhov
On Mon, Apr 15, 2024 at 09:47:10PM +0200, Hans de Goede wrote: > Hi, > > On 4/15/24 9:35 PM, Dmitry Torokhov wrote: > > On Thu, Apr 11, 2024 at 02:30:35PM +0200, Hans de Goede wrote: > >> Hi Dmitry, > >> > >> On 4/11/24 2:02 AM, Dmitry Torokhov wrote

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-15 Thread Dmitry Torokhov
On Wed, Apr 10, 2024 at 10:48:10PM -0400, Mark Pearson wrote: > > I have a stronger preference to keep the KEY_DOUBLECLICK - that one seems > less controversial as a genuine new input event. Please see my response to Peter's letter. I think it very much depends on how it will be used (associated

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-15 Thread Dmitry Torokhov
On Thu, Apr 11, 2024 at 02:30:35PM +0200, Hans de Goede wrote: > Hi Dmitry, > > On 4/11/24 2:02 AM, Dmitry Torokhov wrote: > > On Tue, Apr 09, 2024 at 10:17:05PM -0400, Mark Pearson wrote: > >> Hi Dmitry > >> > >> On Tue, Apr 9, 2024, at 9:20 PM, Dmitry

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-15 Thread Dmitry Torokhov
On Wed, Apr 10, 2024 at 02:32:56PM +1000, Peter Hutterer wrote: > On 10/04/2024 11:20, Dmitry Torokhov wrote: > > On Tue, Apr 09, 2024 at 02:47:05PM -0700, Dmitry Torokhov wrote: > > > On Tue, Apr 09, 2024 at 03:23:52PM +1000, Peter Hutterer wrote: > > > > On 09/

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-10 Thread Dmitry Torokhov
On Tue, Apr 09, 2024 at 10:17:05PM -0400, Mark Pearson wrote: > Hi Dmitry > > On Tue, Apr 9, 2024, at 9:20 PM, Dmitry Torokhov wrote: > > On Tue, Apr 09, 2024 at 02:47:05PM -0700, Dmitry Torokhov wrote: > >> On Tue, Apr 09, 2024 at 03:23:52PM +1000, Peter Hutterer wrote:

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-09 Thread Dmitry Torokhov
On Tue, Apr 09, 2024 at 02:47:05PM -0700, Dmitry Torokhov wrote: > On Tue, Apr 09, 2024 at 03:23:52PM +1000, Peter Hutterer wrote: > > On 09/04/2024 09:31, Dmitry Torokhov wrote: > > > Hi Mark, > > > > > > On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearso

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-09 Thread Dmitry Torokhov
On Tue, Apr 09, 2024 at 12:16:04PM +0200, Hans de Goede wrote: > Hi Dmitry, > > On 4/9/24 2:00 AM, Mark Pearson wrote: > > Hi Dmitry > > > > On Mon, Apr 8, 2024, at 7:31 PM, Dmitry Torokhov wrote: > >> Hi Mark, > >> > >> On Sun, Mar 24, 2

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-09 Thread Dmitry Torokhov
On Tue, Apr 09, 2024 at 03:23:52PM +1000, Peter Hutterer wrote: > On 09/04/2024 09:31, Dmitry Torokhov wrote: > > Hi Mark, > > > > On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote: > > > Add support for new input events on Lenovo laptops that need

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-08 Thread Dmitry Torokhov
Hi Mark, On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote: > Add support for new input events on Lenovo laptops that need exporting to > user space. > > Lenovo trackpoints are adding the ability to generate a doubletap event. > Add a new keycode to allow this to be used by userspace.

Re: [ibm-acpi-devel] [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen

2022-01-07 Thread Dmitry Torokhov
.add = chromeos_privacy_screen_add, > + .remove = chromeos_privacy_screen_remove, > + }, > +}; > + > +module_acpi_driver(chromeos_privacy_screen_driver); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("Chrome

Re: [ibm-acpi-devel] [PATCH] Input: cyapa - do not call input_device_enabled from power mode handler

2020-12-11 Thread Dmitry Torokhov
On Fri, Dec 11, 2020 at 09:22:44AM +0100, Marek Szyprowski wrote: > > On 11.12.2020 08:09, Dmitry Torokhov wrote: > > Input device's user counter is supposed to be accessed only while holding > > input->mutex. Commit d69f0a43c677 ("Input: use input_device_enabled(

[ibm-acpi-devel] [PATCH] Input: cyapa - do not call input_device_enabled from power mode handler

2020-12-10 Thread Dmitry Torokhov
ll input_device_enabled() without holding input->mutex, those are left unfixed for now. Reported-by: Marek Szyprowski Signed-off-by: Dmitry Torokhov --- Marek, could you please try this one? drivers/input/mouse/cyapa_gen3.c |5 + drivers/input/mouse/cyapa_gen5.c |3 +-- 2 files c

Re: [ibm-acpi-devel] [PATCH v4 2/7] Input: use input_device_enabled()

2020-12-08 Thread Dmitry Torokhov
On Tue, Dec 08, 2020 at 11:05:42AM +0100, Marek Szyprowski wrote: > Hi Andrzej, > > On 07.12.2020 16:50, Andrzej Pietrasiewicz wrote: > > Hi Marek, > > > > W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze: > >> Hi Andrzej, > >> > >> On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote: > >>> Use the

Re: [ibm-acpi-devel] [PATCH v4 7/7] Input: Add "inhibited" property

2020-12-02 Thread Dmitry Torokhov
On Tue, Oct 06, 2020 at 06:12:49PM -0700, Dmitry Torokhov wrote: > On Tue, Oct 06, 2020 at 06:11:02PM -0700, Dmitry Torokhov wrote: > > On Tue, Oct 06, 2020 at 03:04:28PM +0200, Andrzej Pietrasiewicz wrote: > > > Hi Dmitry, > > > > > > W dniu 05.10.2020 o 20:1

Re: [ibm-acpi-devel] [PATCH v2] Input: document inhibiting

2020-12-02 Thread Dmitry Torokhov
On Wed, Jun 17, 2020 at 12:18:22PM +0200, Andrzej Pietrasiewicz wrote: > Document inhibiting input devices and its relation to being > a wakeup source. > > Signed-off-by: Andrzej Pietrasiewicz Applied, thank you. -- Dmitry ___ ibm-acpi-devel mailin

Re: [ibm-acpi-devel] [PATCH v4 1/7] Input: add input_device_enabled()

2020-12-02 Thread Dmitry Torokhov
On Mon, Jun 08, 2020 at 01:22:05PM +0200, Andrzej Pietrasiewicz wrote: > A helper function for drivers to decide if the device is used or not. > A lockdep check is introduced as inspecting ->users should be done under > input device's mutex. > > Signed-off-by: Andrzej Pietrasiewicz Applied, than

Re: [ibm-acpi-devel] [PATCH v4 2/7] Input: use input_device_enabled()

2020-12-02 Thread Dmitry Torokhov
On Mon, Jun 08, 2020 at 01:22:06PM +0200, Andrzej Pietrasiewicz wrote: > Use the newly added helper in relevant input drivers. > > Signed-off-by: Andrzej Pietrasiewicz Applied, thank you. -- Dmitry ___ ibm-acpi-devel mailing list ibm-acpi-devel@lis

Re: [ibm-acpi-devel] [PATCH v4 7/7] Input: Add "inhibited" property

2020-10-06 Thread Dmitry Torokhov
On Tue, Oct 06, 2020 at 06:11:02PM -0700, Dmitry Torokhov wrote: > On Tue, Oct 06, 2020 at 03:04:28PM +0200, Andrzej Pietrasiewicz wrote: > > Hi Dmitry, > > > > W dniu 05.10.2020 o 20:10, Dmitry Torokhov pisze: > > > Hi Andrzej, > > > > > > O

Re: [ibm-acpi-devel] [PATCH v4 7/7] Input: Add "inhibited" property

2020-10-06 Thread Dmitry Torokhov
On Tue, Oct 06, 2020 at 03:04:28PM +0200, Andrzej Pietrasiewicz wrote: > Hi Dmitry, > > W dniu 05.10.2020 o 20:10, Dmitry Torokhov pisze: > > Hi Andrzej, > > > > On Mon, Jun 08, 2020 at 01:22:11PM +0200, Andrzej Pietrasiewicz wrote: > > > @@ -284,8 +284,11

Re: [ibm-acpi-devel] [PATCH v4 7/7] Input: Add "inhibited" property

2020-10-05 Thread Dmitry Torokhov
Hi Andrzej, On Mon, Jun 08, 2020 at 01:22:11PM +0200, Andrzej Pietrasiewicz wrote: > @@ -284,8 +284,11 @@ static int input_get_disposition(struct input_dev *dev, > case EV_KEY: > if (is_event_supported(code, dev->keybit, KEY_MAX)) { > > - /* auto-repeat by

Re: [ibm-acpi-devel] [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-10-04 Thread Dmitry Torokhov
On Thu, Jun 25, 2020 at 12:55:29PM +0200, Rafael J. Wysocki wrote: > On Thu, Jun 25, 2020 at 7:23 AM Dmitry Torokhov > wrote: > > > > On Wed, Jun 24, 2020 at 05:00:09PM +0200, Rafael J. Wysocki wrote: > > > On Mon, Jun 8, 2020 at 1:22 PM Andrzej

Re: [ibm-acpi-devel] [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper

2020-10-04 Thread Dmitry Torokhov
On Wed, Jun 24, 2020 at 10:24:46PM -0700, Dmitry Torokhov wrote: > On Mon, Jun 08, 2020 at 01:22:08PM +0200, Andrzej Pietrasiewicz wrote: > > A new helper is available, so use it. > > > > Signed-off-by: Andrzej Pietrasiewicz > > --- > > drivers/acpi/button.

Re: [ibm-acpi-devel] [PATCH v2 0/4] Add 4 new keycodes and use them for 4 new hotkeys on new Lenovo Thinkpads

2020-09-08 Thread Dmitry Torokhov
Hi Hans, On Tue, Sep 08, 2020 at 03:51:43PM +0200, Hans de Goede wrote: > Hi All, > > Here is a v2 of my series to get a couple of new hotkeys, and matching > thinkpad_acpi hkey event codes seen on the last 2 generations of > Thinkpads supported. > > New in this version that Lenovo got back to m

Re: [ibm-acpi-devel] [PATCH 0/3] Add 3 new keycodes and use them for 3 new hotkeys on new Lenovo Thinkpads

2020-07-21 Thread Dmitry Torokhov
On Sun, Jul 19, 2020 at 07:56:49PM -0300, Henrique de Moraes Holschuh wrote: > On Fri, 17 Jul 2020, Hans de Goede wrote: > > This is a simple patch-series adding support for 3 new hotkeys found > > on various new Lenovo Thinkpad models. > > For all three patches, pending an ack for the new keycode

Re: [ibm-acpi-devel] [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper

2020-06-24 Thread Dmitry Torokhov
On Mon, Jun 08, 2020 at 01:22:08PM +0200, Andrzej Pietrasiewicz wrote: > A new helper is available, so use it. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/acpi/button.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/button.c b/drivers/acpi

Re: [ibm-acpi-devel] [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-24 Thread Dmitry Torokhov
On Wed, Jun 24, 2020 at 05:00:09PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz > wrote: > > > > Inspecting input device's 'users' member should be done under device's > > mutex, so add appropriate invocations. > > > > Signed-off-by: Andrzej Pietrasiewicz

Re: [ibm-acpi-devel] [PATCH v4 0/7] Support inhibiting input devices

2020-06-10 Thread Dmitry Torokhov
On Wed, Jun 10, 2020 at 12:38:30PM +0200, Rafael J. Wysocki wrote: > On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: > > > > Hi All, > > > > On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: > > > This is a quick respin of v3, with just two small changes, please see > > > the changelog below.

Re: [ibm-acpi-devel] [PATCH v3 0/7] Support inhibiting input devices

2020-06-07 Thread Dmitry Torokhov
On Sun, Jun 07, 2020 at 10:24:14PM +0200, Pavel Machek wrote: > On Fri 2020-06-05 19:33:28, Andrzej Pietrasiewicz wrote: > > Userspace might want to implement a policy to temporarily disregard input > > from certain devices. > > Wow, you certainly cc a lot of lists. > > > An example use case is a

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-04 Thread Dmitry Torokhov
Hi Hans, Andrzej, On Wed, Jun 03, 2020 at 09:37:10PM +0200, Hans de Goede wrote: > Hi, > > On 6/3/20 7:54 PM, Andrzej Pietrasiewicz wrote: > > W dniu 03.06.2020 o 19:38, Hans de Goede pisze: > > > Hi, > > > > > > On 6/3/20 3:07 PM, Andrzej Pietrasiewicz wrote: > > > > Hi Hans, hi Dmitry, > > >

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-02 Thread Dmitry Torokhov
Hi Andrzej, On Tue, Jun 02, 2020 at 06:56:40PM +0200, Andrzej Pietrasiewicz wrote: > Hi Dmitry, > > W dniu 27.05.2020 o 08:34, Dmitry Torokhov pisze: > > That said, I think the way we should handle inhibit/uninhibit, is that > > if we have the callback defined, then we c

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-26 Thread Dmitry Torokhov
On Tue, May 19, 2020 at 11:36:34AM +0200, Hans de Goede wrote: > Hi, > > On 5/19/20 11:02 AM, Andrzej Pietrasiewicz wrote: > > Hi Hans, Hi Dmitry, > > > > W dniu 18.05.2020 o 16:23, Hans de Goede pisze: > > > Hi, > > > > > > > > > > > > > > > > > > > > So I wonder what this series actually ad

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-17 Thread Dmitry Torokhov
Hi Hans, Peter, On Mon, May 18, 2020 at 08:55:10AM +1000, Peter Hutterer wrote: > On Fri, May 15, 2020 at 08:19:10PM +0200, Hans de Goede wrote: > > Hi Andrezj, > > > > On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: > > > Userspace might want to implement a policy to temporarily disregard input

Re: [ibm-acpi-devel] 2nd Fan quirk for Thinkpad P50 causes spurios touchpad/trackpoint events on ThinkPad L570

2018-10-15 Thread Dmitry Torokhov
On Sat, Oct 13, 2018 at 6:32 AM Jaak Ristioja wrote: > > On 27.08.2018 19:22, Jaak Ristioja wrote: > > Upgrading Linux from 4.16 to 4.17, a ThinkPad L570 started receiving > > spurious input events, mostly right mouse button click events, but also > > cursor jumps. > > > > I have not attempted to

Re: [ibm-acpi-devel] [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Dmitry Torokhov
On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote: > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote: > > Signed-off-by: Bastien Nocera > > --- > > include/uapi/linux/input.h | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/uapi/linux/inpu

Re: [ibm-acpi-devel] [PATCH] Add KEY_MICMUTE and enable it on Lenovo X220

2011-05-27 Thread Dmitry Torokhov
On Friday, May 27, 2011 09:29:01 AM Matthew Garrett wrote: > On Tue, May 24, 2011 at 03:16:43PM -0400, Andy Lutomirski wrote: > > I suspect that this works on T410. > > Dmitry? Sure, merge it. -- Dmitry -- vRanger cuts

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Dmitry Torokhov
On Thu, May 12, 2011 at 03:33:54PM -0400, Andrew Lutomirski wrote: > On Thu, May 12, 2011 at 11:39 AM, Dmitry Torokhov > wrote: > > Hi Andrew, > > > > On Thu, May 12, 2011 at 10:50:54AM -0400, Andrew Lutomirski wrote: > >> > >> I do, however, have a ques

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-12 Thread Dmitry Torokhov
Hi Andrew, On Thu, May 12, 2011 at 10:50:54AM -0400, Andrew Lutomirski wrote: > > I do, however, have a question for the input people. Dmitry: Lenovo > makes laptops which are kind enough to tell us that the volume changed > by sending a keystroke over the atkbd-based keyboard. (wtf!) I've > m

Re: [ibm-acpi-devel] [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly

2009-12-10 Thread Dmitry Torokhov
On Thu, Dec 10, 2009 at 10:46:02PM -0200, Henrique de Moraes Holschuh wrote: > On Thu, 10 Dec 2009, Dmitry Torokhov wrote: > > Right, input_set_abs_params()... No, I don't really want to go through > > all touchpad, touchscreen and joystick drivers at once, thank you vey >

Re: [ibm-acpi-devel] [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly

2009-12-10 Thread Dmitry Torokhov
On Thu, Dec 10, 2009 at 11:19:18AM -0200, Henrique de Moraes Holschuh wrote: > On Wed, 09 Dec 2009, Dmitry Torokhov wrote: > > > Still, please look at the patch below... Would something like this be a > > > cleaner API? It is certainly more obvious, and it is cleaner

Re: [ibm-acpi-devel] [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly

2009-12-09 Thread Dmitry Torokhov
On Wed, Dec 09, 2009 at 06:32:01PM -0200, Henrique de Moraes Holschuh wrote: > On Wed, 09 Dec 2009, Dmitry Torokhov wrote: > > > input_report_switch() will call input_event(), which will have a 50% > > > chance > > > of doing the wrong thing at startup (i.e.

Re: [ibm-acpi-devel] [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly

2009-12-09 Thread Dmitry Torokhov
On Wed, Dec 09, 2009 at 02:30:41PM -0200, Henrique de Moraes Holschuh wrote: > On Tue, 08 Dec 2009, Dmitry Torokhov wrote: > > On Tuesday 08 December 2009 05:36:30 pm Henrique de Moraes Holschuh wrote: > > > Before we register the input device, sync the input layer EV_SW state

Re: [ibm-acpi-devel] [PATCH 10/10] thinkpad-acpi: sync input device EV_SW state directly

2009-12-08 Thread Dmitry Torokhov
On Tuesday 08 December 2009 05:36:30 pm Henrique de Moraes Holschuh wrote: > Before we register the input device, sync the input layer EV_SW state > directly by setting the bitmaps, to avoid issuing a gratuitous event > for the initial state of these switches. > > I will propose a clean input laye

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-16 Thread Dmitry Torokhov
On 7/15/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > On Sun, Jul 15, 2007 at 05:59:34PM -0300, Henrique de Moraes Holschuh wrote: > > > *HAL* does. HAL is *not* all there is to userspace. The input layer is > > > not > > > an interf

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-16 Thread Dmitry Torokhov
On 7/15/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 16 Jul 2007, Matthew Garrett wrote: > > > > Having checked other drivers, it looks like KEY_SWITCHVIDEOMODE is the > > one used for video toggling. If that's not actually how people are using > > it, we need to fix that -

Re: [ibm-acpi-devel] [PATCH 12/16] INPUT: add a new EV_SW SW_RADIO event, for radio switches on laptops

2007-07-05 Thread Dmitry Torokhov
On Thursday 05 July 2007 22:42, Henrique de Moraes Holschuh wrote: > Many laptops have rf-kill physical switches that are not keys, but slider > or rocker switches. Often (like in all ThinkPads with a radio kill slider > switch), they have both a slider/rocker switch and a hot key. Linus just mer

Re: [ibm-acpi-devel] Anything against a new EV_SW SW_RADIO event ?

2007-06-24 Thread Dmitry Torokhov
Hi Henrique, On Sunday 24 June 2007 06:55, Henrique de Moraes Holschuh wrote: > Dmitry, > > Could you ACK the attached patch? I am about to send in code that would > benefit a damn great deal from it (thinkpad-acpi support for the > T60/X60/newer radio-kill slider switch)... So I thought it wou

Re: [ibm-acpi-devel] reseting an input device due to sleep/resume cycle

2007-06-18 Thread Dmitry Torokhov
Hi Henrique, On 6/16/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > Dmitry, input gurus, > > When a ThinkPad does an sleep cycle, the firmware explicitly kills all > pending hotkey state. That reminds me that I also need to do the same in > thinkpad-acpi. > > How does one tell the i

Re: [ibm-acpi-devel] Exporting EV_SW SW_LID events from thinkpad-acpi to input layer

2007-06-16 Thread Dmitry Torokhov
On Saturday 16 June 2007 10:44, Henrique de Moraes Holschuh wrote: > thinkpad-acpi can now be made to export EV_SW SW_LID events to the input > layer. > > However, most (all?) thinkpads will also generate ACPI notifications to > \_SB.LID, on LID changes, i.e. this would duplicate an ACPI LID event

Re: [ibm-acpi-devel] Making KEY_UNKNOWN really useful to userland

2007-05-31 Thread Dmitry Torokhov
On Wednesday 30 May 2007 20:53, Henrique de Moraes Holschuh wrote: > On Wed, 30 May 2007, Dmitry Torokhov wrote: > > On 5/30/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > >It is trivial to guarantee that KEY_PROG is unique for a single input > &

Re: [ibm-acpi-devel] Making KEY_UNKNOWN really useful to userland

2007-05-31 Thread Dmitry Torokhov
On 5/31/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Thu, 31 May 2007, Richard Hughes wrote: > > I am on it on the thinkpad-acpi side, so at least for that, you don't have > to worry. I am still waiting an answer about which event is the correct one > to output scancodes, but th

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Wed, 30 May 2007, Dmitry Torokhov wrote: > > >1. Generate SOMETHING that has an undefined meaning or function, but which > > >is unique for that keyboard (KEY_PROG/KEY_HOSTSPECIFIC) > > >

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Wed, 30 May 2007, Dmitry Torokhov wrote: > > On 5/29/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > >But I will still need to add keys, and I still think that a bunch of 32 or

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Wed, May 30, 2007 at 10:18:17AM -0400, Dmitry Torokhov wrote: > > Hi Matthew, > > >We've already got KEY_PROG* - is this not the sort of situation they're > > >for? (ie, keys that aren&

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
Hi Matthew, On 5/30/07, Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Wed, May 30, 2007 at 09:57:11AM -0400, Dmitry Torokhov wrote: > > > I really don't like KEY_FN_F1..KEY_FN_BACKSPACE either. What are they > > supposed to do? Just being an unique value to be map

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/29/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 28 May 2007, Dmitry Torokhov wrote: > > On Sunday 27 May 2007 08:15, Henrique de Moraes Holschuh wrote: > > > On Sat, 26 May 2007, Dmitry Torokhov wrote: > > > > I am unconvinced that

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: allow hotkey to input event map to be modified

2007-05-29 Thread Dmitry Torokhov
On 5/29/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 28 May 2007, Dmitry Torokhov wrote: > > Documentation/input/input-programming.txt gives some pointers. > > It is outdated, Hm, I just recently updated it so it is pretty fresh. > and i

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-28 Thread Dmitry Torokhov
On Sunday 27 May 2007 08:15, Henrique de Moraes Holschuh wrote: > On Sat, 26 May 2007, Dmitry Torokhov wrote: > > On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: > > > Add hotkeys available in almost all ThinkPads manufactured in the last > > > five

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: allow hotkey to input event map to be modified

2007-05-28 Thread Dmitry Torokhov
Hi, On Sunday 27 May 2007 08:03, Henrique de Moraes Holschuh wrote: > On Sat, 26 May 2007, Dmitry Torokhov wrote: > > On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: > > > Add a sysfs interface to allow userspace to modify the mapping between > > &g

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-27 Thread Dmitry Torokhov
On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: > Add hotkeys available in almost all ThinkPads manufactured in the last five > years (more than one million machines given the ammount of batteries > recalled) to input.h, and make thinkpad-acpi use those instead of issuing > KEY_UN

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: register input device

2007-05-27 Thread Dmitry Torokhov
Hi, On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: > Register an input device to send input events to userspace. > > This patch is based on a patch by Richard Hughes <[EMAIL PROTECTED]>. > > Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > Cc: Richard Hughes <[

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: allow hotkey to input event map to be modified

2007-05-27 Thread Dmitry Torokhov
On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: > Add a sysfs interface to allow userspace to modify the mapping between > ThinkPad hotkeys and the keycode input events they generate. > No, please do not do that. We have a standard way to adjust keymap for an input device via EV

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
[Sorry, cut away too much in original reply...] On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 22 May 2007, Dmitry Torokhov wrote: > > > > Notification to where? The driver? Userspace? Does delay in status > > reading of ~0.5 sec matter?

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 22 May 2007, Dmitry Torokhov wrote: > > On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > > I can work with that, yes. In fact I have nothing against it, but current &

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > On Monday 21 May 2007 13:22, Henrique de Moraes Holschuh wrote: > > > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > > > RFkill is not only abou

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 22 May 2007, Richard Hughes wrote: > > Yes, if there is no event on kill switch, I agree. We need a way so > > AFAIK one can poll it, but since it is in the EC space, it is a "we don't > have events" thing. If someone fin

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On Monday 21 May 2007 13:22, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > RFkill is not only about "please disable radios", it _does_ provide > > the standard sysfs interface to control the radios as well. > > To control? Fin

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Dmitry Torokhov
terfaces otherwise the patch is really tiny. Sorry for attachment. -- Dmitry Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 143 +++ drivers/misc/thinkpad_acpi.h |1 include/linux/rfkill.h |1 n

Re: [ibm-acpi-devel] How to handle WWAN card, together with WLAN or separate?

2007-05-08 Thread Dmitry Torokhov
On Tuesday 08 May 2007 22:08, Henrique de Moraes Holschuh wrote: > The rfkill class has been merged in Linux mainline, and if at all possible, > thinkpad-acpi will use it to connect or disconnect the internal bluetooth > and WWAN devices. > > The rfkill class has a concept of "type" of the radio,