Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-30 Thread Andy Shevchenko
On Thu, Nov 29, 2018 at 10:23:31PM +0100, Jacek Anaszewski wrote: > Regarding sound devices - how would we name micmute LED for USB > microphone? I suppose that it is possible to discover some unique > identifier in runtime - this is a question to ALSA people. USB path (e.g. 2-1.1.2.4.3) + '::' +

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-29 Thread Takashi Iwai
On Thu, 29 Nov 2018 22:23:31 +0100, Jacek Anaszewski wrote: > > On 11/28/2018 10:22 PM, Pavel Machek wrote: > > Hi! > > > >>> If external USB keyboard is identified as "input7" device, then > >>> "input7::mute" is a good name for mute key. But "sys::mute" does not say > >>> anything to which devi

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-29 Thread Jacek Anaszewski
On 11/28/2018 10:22 PM, Pavel Machek wrote: > Hi! > >>> If external USB keyboard is identified as "input7" device, then >>> "input7::mute" is a good name for mute key. But "sys::mute" does not say >>> anything to which device or hardware it belongs nor does not solve >>> problem that which device/

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pavel Machek
Hi! > > If external USB keyboard is identified as "input7" device, then > > "input7::mute" is a good name for mute key. But "sys::mute" does not say > > anything to which device or hardware it belongs nor does not solve > > problem that which device/driver/subsystem should have privilege to take >

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pavel Machek
Hi! > > > >> A nice godfather is required here... > > > > > > > > Just use sys:: :-). > > > > > > > > laptop:: would work for me, too. (It is always laptop in the cases we > > > > are handling now, right?) > > > > > > > > When we get a keyboard with mute led, we'll have to decide if it > > > >

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Jacek Anaszewski
On 11/28/2018 09:46 PM, Pali Rohár wrote: > On Wednesday 28 November 2018 21:34:10 Pavel Machek wrote: >> Hi! >> >>> Looks good... except one detail: you have "tpacpi::micmute" and >>> "dell::micmute". I know it follows "tradition", but we are trying to >>> fix that at the moment. Lapto

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pali Rohár
On Wednesday 28 November 2018 21:34:10 Pavel Machek wrote: > Hi! > > > Looks good... except one detail: you have "tpacpi::micmute" and > > "dell::micmute". I know it follows "tradition", but we are trying to > > fix that at the moment. Laptop micmute button is a laptop micmute > > >

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pavel Machek
Hi! > Looks good... except one detail: you have "tpacpi::micmute" and > "dell::micmute". I know it follows "tradition", but we are trying to > fix that at the moment. Laptop micmute button is a laptop micmute > button, and userspace should not need to know what prefix to use >

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Jacek Anaszewski
On 11/28/2018 01:25 PM, Pavel Machek wrote: > On Wed 2018-11-28 12:38:19, Takashi Iwai wrote: >> On Wed, 28 Nov 2018 12:18:06 +0100, >> Pali Rohár wrote: >>> >>> On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote: Looks good... except one detail: you have "tpacpi::micmute" and "dell:

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Andy Shevchenko
On Wed, Nov 28, 2018 at 2:59 PM Takashi Iwai wrote: > On Wed, 28 Nov 2018 13:25:05 +0100, > > On Wed 2018-11-28 12:38:19, Takashi Iwai wrote: > > Just use sys:: :-). > > > > laptop:: would work for me, too. (It is always laptop in the cases we > > are handling now, right?) > > In theory, such a t

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Takashi Iwai
On Wed, 28 Nov 2018 13:25:05 +0100, Pavel Machek wrote: > > On Wed 2018-11-28 12:38:19, Takashi Iwai wrote: > > On Wed, 28 Nov 2018 12:18:06 +0100, > > Pali Rohár wrote: > > > > > > On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote: > > > > Looks good... except one detail: you have "tpacpi:

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pavel Machek
On Wed 2018-11-28 12:38:19, Takashi Iwai wrote: > On Wed, 28 Nov 2018 12:18:06 +0100, > Pali Rohár wrote: > > > > On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote: > > > Looks good... except one detail: you have "tpacpi::micmute" and > > > "dell::micmute". I know it follows "tradition", but

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Takashi Iwai
On Wed, 28 Nov 2018 12:18:06 +0100, Pali Rohár wrote: > > On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote: > > Looks good... except one detail: you have "tpacpi::micmute" and > > "dell::micmute". I know it follows "tradition", but we are trying to > > fix that at the moment. Laptop micmute

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Takashi Iwai
On Wed, 28 Nov 2018 12:14:34 +0100, Pali Rohár wrote: > > On Monday 26 November 2018 18:11:20 Takashi Iwai wrote: > > Hi, > > > > this is patch series I've hacked after useful conversation with > > Pavel. Basically this adds a new LED trigger audio-mute and > > audio-micmute, and convert the HD-

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pali Rohár
On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote: > Looks good... except one detail: you have "tpacpi::micmute" and > "dell::micmute". I know it follows "tradition", but we are trying to > fix that at the moment. Laptop micmute button is a laptop micmute > button, and userspace should not ne

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-28 Thread Pali Rohár
On Monday 26 November 2018 18:11:20 Takashi Iwai wrote: > Hi, > > this is patch series I've hacked after useful conversation with > Pavel. Basically this adds a new LED trigger audio-mute and > audio-micmute, and convert the HD-audio driver and the platform > drivers to use the LED trigger instea

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 11:26:32 +0100, Henrique de Moraes Holschuh wrote: > > On Mon, 26 Nov 2018, Takashi Iwai wrote: > > this is patch series I've hacked after useful conversation with > > Pavel. Basically this adds a new LED trigger audio-mute and > > audio-micmute, and convert the HD-audio drive

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 09:44:18 +0100, Pavel Machek wrote: > > Hi! > > > this is patch series I've hacked after useful conversation with > > Pavel. Basically this adds a new LED trigger audio-mute and > > audio-micmute, and convert the HD-audio driver and the platform > > drivers to use the LED tri

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 00:09:17 +0100, Andy Shevchenko wrote: > > On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai wrote: > > > > Hi, > > > > this is patch series I've hacked after useful conversation with > > Pavel. Basically this adds a new LED trigger audio-mute and > > audio-micmute, and convert th

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-27 Thread Henrique de Moraes Holschuh
On Mon, 26 Nov 2018, Takashi Iwai wrote: > this is patch series I've hacked after useful conversation with > Pavel. Basically this adds a new LED trigger audio-mute and > audio-micmute, and convert the HD-audio driver and the platform > drivers to use the LED trigger instead of the ugly direct dyn

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-27 Thread Pavel Machek
Hi! > this is patch series I've hacked after useful conversation with > Pavel. Basically this adds a new LED trigger audio-mute and > audio-micmute, and convert the HD-audio driver and the platform > drivers to use the LED trigger instead of the ugly direct dynamic > symbol binding. Thanks a lot

Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-26 Thread Andy Shevchenko
On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai wrote: > > Hi, > > this is patch series I've hacked after useful conversation with > Pavel. Basically this adds a new LED trigger audio-mute and > audio-micmute, and convert the HD-audio driver and the platform > drivers to use the LED trigger instead

[ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-26 Thread Takashi Iwai
Hi, this is patch series I've hacked after useful conversation with Pavel. Basically this adds a new LED trigger audio-mute and audio-micmute, and convert the HD-audio driver and the platform drivers to use the LED trigger instead of the ugly direct dynamic symbol binding. The latest version of