Re: [Intel-gfx] [PATCH] drm/i915: Fix incorrect definition of ADPA HSYNC and VSYNC bits

2013-03-06 Thread Patrik Jakobsson
On Wed, Mar 6, 2013 at 12:17 AM, Paul Menzel wrote: > Dear Patrik, Hi Paul > Am Dienstag, den 05.03.2013, 19:09 +0100 schrieb Patrik Jakobsson: >> Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend >> becoming standby and vice versa. > > nice find. Could you elaborate on t

Re: [Intel-gfx] [PATCH] drm/i915: Fix incorrect definition of ADPA HSYNC and VSYNC bits

2013-03-06 Thread Daniel Vetter
On Tue, Mar 05, 2013 at 02:19:31PM -0800, Eric Anholt wrote: > Patrik Jakobsson writes: > > > Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend > > becoming standby and vice versa. Fixed by swapping their bit position. > > > > Reported-by: Ville Syrjälä > > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Fix incorrect definition of ADPA HSYNC and VSYNC bits

2013-03-05 Thread Paul Menzel
Dear Patrik, Am Dienstag, den 05.03.2013, 19:09 +0100 schrieb Patrik Jakobsson: > Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend > becoming standby and vice versa. nice find. Could you elaborate on the symptoms please as I have never experienced any issues with suspend

Re: [Intel-gfx] [PATCH] drm/i915: Fix incorrect definition of ADPA HSYNC and VSYNC bits

2013-03-05 Thread Eric Anholt
Patrik Jakobsson writes: > Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend > becoming standby and vice versa. Fixed by swapping their bit position. > > Reported-by: Ville Syrjälä > Signed-off-by: Patrik Jakobsson Confirmed in the 945 and 845 specs. Reviewed-by: Eric

[Intel-gfx] [PATCH] drm/i915: Fix incorrect definition of ADPA HSYNC and VSYNC bits

2013-03-05 Thread Patrik Jakobsson
Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend becoming standby and vice versa. Fixed by swapping their bit position. Reported-by: Ville Syrjälä Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/i915/i915_reg.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletio