Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-24 Thread Ville Syrjälä
On Wed, Apr 24, 2013 at 02:57:17PM +0200, Daniel Vetter wrote: > The current code is rather ... ugly. The only thing it managed to pull > off is getting 6bpc on DP working on g4x. Then someone added another > custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly > implementing the PI

[Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-24 Thread Daniel Vetter
The current code is rather ... ugly. The only thing it managed to pull off is getting 6bpc on DP working on g4x. Then someone added another custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly implementing the PIPECONF-based dither/bpc controls on g4x/vlv. Note that compared to pch

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-24 Thread Ville Syrjälä
On Wed, Apr 24, 2013 at 12:30:14AM +0200, Daniel Vetter wrote: > The current code is rather ... ugly. The only thing it managed to pull > off is getting 6bpc on DP working on g4x. Then someone added another > custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly > implementing the PI

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-24 Thread Ville Syrjälä
On Wed, Apr 24, 2013 at 12:27:59AM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2013 at 10:39:35PM +0200, Daniel Vetter wrote: > > On Tue, Apr 23, 2013 at 06:27:54PM +0300, Ville Syrjälä wrote: > > > The g4x docs are a bit confusing though. They seem to indicate the the > > > PIPECONF dither contr

[Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-23 Thread Daniel Vetter
The current code is rather ... ugly. The only thing it managed to pull off is getting 6bpc on DP working on g4x. Then someone added another custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly implementing the PIPECONF-based dither/bpc controls on g4x/vlv. Note that compared to pch

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2013 at 10:39:35PM +0200, Daniel Vetter wrote: > On Tue, Apr 23, 2013 at 06:27:54PM +0300, Ville Syrjälä wrote: > > The g4x docs are a bit confusing though. They seem to indicate the the > > PIPECONF dither controls only affect DP. > > Hm, this could put a pending question from Jes

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-23 Thread Daniel Vetter
On Tue, Apr 23, 2013 at 06:27:54PM +0300, Ville Syrjälä wrote: > On Fri, Apr 19, 2013 at 08:17:10PM +0200, Daniel Vetter wrote: > > The current code is rather ... ugly. The only thing it managed to pull > > off is getting 6bpc on DP working on g4x. Then someone added another > > custom hack for 6bp

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-23 Thread Ville Syrjälä
On Fri, Apr 19, 2013 at 08:17:10PM +0200, Daniel Vetter wrote: > The current code is rather ... ugly. The only thing it managed to pull > off is getting 6bpc on DP working on g4x. Then someone added another > custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly > implementing the PI

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-19 Thread Daniel Vetter
On Fri, Apr 19, 2013 at 8:39 PM, Jesse Barnes wrote: > On Fri, 19 Apr 2013 20:17:10 +0200 > Daniel Vetter wrote: >> diff --git a/drivers/gpu/drm/i915/intel_display.c >> b/drivers/gpu/drm/i915/intel_display.c >> index 8c36376..7f1ab8b 100644 >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/

Re: [Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-19 Thread Jesse Barnes
On Fri, 19 Apr 2013 20:17:10 +0200 Daniel Vetter wrote: > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 8c36376..7f1ab8b 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -4605,22 +4605,29 @@

[Intel-gfx] [PATCH] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv

2013-04-19 Thread Daniel Vetter
The current code is rather ... ugly. The only thing it managed to pull off is getting 6bpc on DP working on g4x. Then someone added another custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly implementing the PIPECONF-based dither/bpc controls on g4x/vlv. Note that compared to pch