Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix enabled_planes bitmask

2021-03-19 Thread Navare, Manasi
On Fri, Mar 19, 2021 at 11:20:07PM +0200, Ville Syrjälä wrote: > On Fri, Mar 19, 2021 at 02:17:18PM -0700, Navare, Manasi wrote: > > On Fri, Mar 05, 2021 at 05:36:05PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The enabled_planes bitmask was supposed to track logically enab

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix enabled_planes bitmask

2021-03-19 Thread Ville Syrjälä
On Fri, Mar 19, 2021 at 02:17:18PM -0700, Navare, Manasi wrote: > On Fri, Mar 05, 2021 at 05:36:05PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The enabled_planes bitmask was supposed to track logically enabled > > planes (ie. fb!=NULL and crtc!=NULL), but instead we end up putti

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Fix enabled_planes bitmask

2021-03-19 Thread Navare, Manasi
On Fri, Mar 05, 2021 at 05:36:05PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The enabled_planes bitmask was supposed to track logically enabled > planes (ie. fb!=NULL and crtc!=NULL), but instead we end up putting > even disabled planes into the bitmask since > intel_plane_atomic_chec

[Intel-gfx] [PATCH 1/6] drm/i915: Fix enabled_planes bitmask

2021-03-05 Thread Ville Syrjala
From: Ville Syrjälä The enabled_planes bitmask was supposed to track logically enabled planes (ie. fb!=NULL and crtc!=NULL), but instead we end up putting even disabled planes into the bitmask since intel_plane_atomic_check_with_state() only takes the early exit if the plane was disabled and stay