Re: [Intel-gfx] [PATCH 4/7] drm/i915: use pipe_config for lvds dithering

2013-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2013 at 2:42 PM, Ville Syrjälä wrote: > On Thu, Apr 25, 2013 at 02:24:50PM +0200, Daniel Vetter wrote: >> On Thu, Apr 25, 2013 at 02:57:16PM +0300, Ville Syrjälä wrote: >> > On Fri, Apr 19, 2013 at 11:14:34AM +0200, Daniel Vetter wrote: >> > > diff --git a/drivers/gpu/drm/i915/inte

Re: [Intel-gfx] [PATCH 4/7] drm/i915: use pipe_config for lvds dithering

2013-04-25 Thread Ville Syrjälä
On Thu, Apr 25, 2013 at 02:24:50PM +0200, Daniel Vetter wrote: > On Thu, Apr 25, 2013 at 02:57:16PM +0300, Ville Syrjälä wrote: > > On Fri, Apr 19, 2013 at 11:14:34AM +0200, Daniel Vetter wrote: > > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c > > > b/drivers/gpu/drm/i915/intel_lvds.c > > > in

Re: [Intel-gfx] [PATCH 4/7] drm/i915: use pipe_config for lvds dithering

2013-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2013 at 02:57:16PM +0300, Ville Syrjälä wrote: > On Fri, Apr 19, 2013 at 11:14:34AM +0200, Daniel Vetter wrote: > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c > > b/drivers/gpu/drm/i915/intel_lvds.c > > index 563f505..58a98ff 100644 > > --- a/drivers/gpu/drm/i915/intel_lvds.c >

Re: [Intel-gfx] [PATCH 4/7] drm/i915: use pipe_config for lvds dithering

2013-04-25 Thread Ville Syrjälä
On Fri, Apr 19, 2013 at 11:14:34AM +0200, Daniel Vetter wrote: > Up to now we've relied on the bios to get this right for us. Let's try > out whether our code has improved a bit, since we should dither > always when the output bpp doesn't match the plane bpp. > - gen5+ should be fine, since we only

[Intel-gfx] [PATCH 4/7] drm/i915: use pipe_config for lvds dithering

2013-04-19 Thread Daniel Vetter
Up to now we've relied on the bios to get this right for us. Let's try out whether our code has improved a bit, since we should dither always when the output bpp doesn't match the plane bpp. - gen5+ should be fine, since we only use the bios hint as an upgrade. - gen4 changes, since here dithering