Re: [Intel-wired-lan] [PATCH iwl-next v2 2/5] e1000e: drop unnecessary constant casts to u16

[Simon Horman]

On Tue, Jul 08, 2025 at 10:17:22AM +0200, Jacek Kowalski wrote:
> Remove unnecessary casts of constant values to u16.
> Let the C type system do it's job.
> 
> Signed-off-by: Jacek Kowalski 
> Suggested-by: Simon Horman 

The nit below not withstanding this looks good to me.

Reviewed-by: Simon Horman 

> ---
>  drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-
>  drivers/net/ethernet/intel/e1000e/nvm.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c 
> b/drivers/net/ethernet/intel/e1000e/ethtool.c
> index c0bbb12eed2e..5d8c66253779 100644
> --- a/drivers/net/ethernet/intel/e1000e/ethtool.c
> +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c
> @@ -959,7 +959,7 @@ static int e1000_eeprom_test(struct e1000_adapter 
> *adapter, u64 *data)
>   }
>  
>   /* If Checksum is not Correct return error else test passed */
> - if ((checksum != (u16)NVM_SUM) && !(*data))
> + if ((checksum != NVM_SUM) && !(*data))

Unnecessary inner parentheses here too.

...

[Intel-wired-lan] [PATCH iwl-next v2 2/5] e1000e: drop unnecessary constant casts to u16

[Jacek Kowalski]

Remove unnecessary casts of constant values to u16.
Let the C type system do it's job.

Signed-off-by: Jacek Kowalski 
Suggested-by: Simon Horman 
---
 drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-
 drivers/net/ethernet/intel/e1000e/nvm.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c 
b/drivers/net/ethernet/intel/e1000e/ethtool.c
index c0bbb12eed2e..5d8c66253779 100644
--- a/drivers/net/ethernet/intel/e1000e/ethtool.c
+++ b/drivers/net/ethernet/intel/e1000e/ethtool.c
@@ -959,7 +959,7 @@ static int e1000_eeprom_test(struct e1000_adapter *adapter, 
u64 *data)
}
 
/* If Checksum is not Correct return error else test passed */
-   if ((checksum != (u16)NVM_SUM) && !(*data))
+   if ((checksum != NVM_SUM) && !(*data))
*data = 2;
 
return *data;
diff --git a/drivers/net/ethernet/intel/e1000e/nvm.c 
b/drivers/net/ethernet/intel/e1000e/nvm.c
index 16369e6d245a..4bde1c9de1b9 100644
--- a/drivers/net/ethernet/intel/e1000e/nvm.c
+++ b/drivers/net/ethernet/intel/e1000e/nvm.c
@@ -564,7 +564,7 @@ s32 e1000e_validate_nvm_checksum_generic(struct e1000_hw 
*hw)
return 0;
}
 
-   if (checksum != (u16)NVM_SUM) {
+   if (checksum != NVM_SUM) {
e_dbg("NVM Checksum Invalid\n");
return -E1000_ERR_NVM;
}
@@ -594,7 +594,7 @@ s32 e1000e_update_nvm_checksum_generic(struct e1000_hw *hw)
}
checksum += nvm_data;
}
-   checksum = (u16)NVM_SUM - checksum;
+   checksum = NVM_SUM - checksum;
ret_val = e1000_write_nvm(hw, NVM_CHECKSUM_REG, 1, &checksum);
if (ret_val)
e_dbg("NVM Write Error while updating checksum.\n");
-- 
2.47.2