Re: [Intel-wired-lan] [iwl-next v3 2/4] ixgbe: check for MDD events

2025-06-27 Thread Romanowski, Rafal
> -Original Message-
> From: Intel-wired-lan  On Behalf Of Simon
> Horman
> Sent: Tuesday, February 18, 2025 8:37 PM
> To: Michal Swiatkowski 
> Cc: [email protected]; [email protected];
> [email protected]; Jagielski, Jedrzej 
> ;
> Kitszel, Przemyslaw ; Kwapulinski, Piotr
> ; Nguyen, Anthony L
> ; Osuchowski, Dawid
> ; [email protected]
> Subject: Re: [Intel-wired-lan] [iwl-next v3 2/4] ixgbe: check for MDD events
> 
> On Mon, Feb 17, 2025 at 10:06:34AM +0100, Michal Swiatkowski wrote:
> > From: Don Skidmore 
> >
> > When an event is detected it is logged and, for the time being, the
> > queue is immediately re-enabled.  This is due to the lack of an API to
> > the hypervisor so it could deal with it as it chooses.
> >
> > Reviewed-by: Przemek Kitszel 
> > Reviewed-by: Jedrzej Jagielski 
> > Reviewed-by: Marcin Szycik 
> > Signed-off-by: Don Skidmore 
> > Signed-off-by: Michal Swiatkowski 
> 
> Reviewed-by: Simon Horman 

Tested-by: Rafal Romanowski 




Re: [Intel-wired-lan] [iwl-next v3 2/4] ixgbe: check for MDD events

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 10:06:34AM +0100, Michal Swiatkowski wrote:
> From: Don Skidmore 
> 
> When an event is detected it is logged and, for the time being, the
> queue is immediately re-enabled.  This is due to the lack of an API
> to the hypervisor so it could deal with it as it chooses.
> 
> Reviewed-by: Przemek Kitszel 
> Reviewed-by: Jedrzej Jagielski 
> Reviewed-by: Marcin Szycik 
> Signed-off-by: Don Skidmore 
> Signed-off-by: Michal Swiatkowski 

Reviewed-by: Simon Horman 



[Intel-wired-lan] [iwl-next v3 2/4] ixgbe: check for MDD events

2025-02-17 Thread Michal Swiatkowski
From: Don Skidmore 

When an event is detected it is logged and, for the time being, the
queue is immediately re-enabled.  This is due to the lack of an API
to the hypervisor so it could deal with it as it chooses.

Reviewed-by: Przemek Kitszel 
Reviewed-by: Jedrzej Jagielski 
Reviewed-by: Marcin Szycik 
Signed-off-by: Don Skidmore 
Signed-off-by: Michal Swiatkowski 
---
 .../net/ethernet/intel/ixgbe/ixgbe_sriov.h|  1 +
 drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  2 +
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  3 ++
 .../net/ethernet/intel/ixgbe/ixgbe_sriov.c| 50 +++
 4 files changed, 56 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h
index 0690ecb8dfa3..bc4cab976bf9 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h
@@ -15,6 +15,7 @@
 #ifdef CONFIG_PCI_IOV
 void ixgbe_restore_vf_multicasts(struct ixgbe_adapter *adapter);
 #endif
+bool ixgbe_check_mdd_event(struct ixgbe_adapter *adapter);
 void ixgbe_msg_task(struct ixgbe_adapter *adapter);
 int ixgbe_vf_configuration(struct pci_dev *pdev, unsigned int event_mask);
 void ixgbe_ping_all_vfs(struct ixgbe_adapter *adapter);
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
index d446c375335a..aa3b498558bc 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
@@ -402,6 +402,8 @@ struct ixgbe_nvm_version {
 #define IXGBE_MRCTL(_i)  (0x0F600 + ((_i) * 4))
 #define IXGBE_VMRVLAN(_i)(0x0F610 + ((_i) * 4))
 #define IXGBE_VMRVM(_i)  (0x0F630 + ((_i) * 4))
+#define IXGBE_LVMMC_RX  0x2FA8
+#define IXGBE_LVMMC_TX  0x8108
 #define IXGBE_WQBR_RX(_i)(0x2FB0 + ((_i) * 4)) /* 4 total */
 #define IXGBE_WQBR_TX(_i)(0x8130 + ((_i) * 4)) /* 4 total */
 #define IXGBE_L34T_IMIR(_i)  (0x0E800 + ((_i) * 4)) /*128 of these (0-127)*/
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 467f81239e12..3ff48207165c 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -7959,6 +7959,9 @@ static void ixgbe_watchdog_link_is_up(struct 
ixgbe_adapter *adapter)
netif_carrier_on(netdev);
ixgbe_check_vf_rate_limit(adapter);
 
+   if (adapter->num_vfs && hw->mac.ops.enable_mdd)
+   hw->mac.ops.enable_mdd(hw);
+
/* enable transmits */
netif_tx_wake_all_queues(adapter->netdev);
 
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index ccdce80edd14..c374ebd4a56b 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -207,6 +207,7 @@ void ixgbe_enable_sriov(struct ixgbe_adapter *adapter, 
unsigned int max_vfs)
 int ixgbe_disable_sriov(struct ixgbe_adapter *adapter)
 {
unsigned int num_vfs = adapter->num_vfs, vf;
+   struct ixgbe_hw *hw = &adapter->hw;
unsigned long flags;
int rss;
 
@@ -237,6 +238,9 @@ int ixgbe_disable_sriov(struct ixgbe_adapter *adapter)
if (!(adapter->flags & IXGBE_FLAG_SRIOV_ENABLED))
return 0;
 
+   if (hw->mac.ops.disable_mdd)
+   hw->mac.ops.disable_mdd(hw);
+
 #ifdef CONFIG_PCI_IOV
/*
 * If our VFs are assigned we cannot shut down SR-IOV
@@ -1353,12 +1357,58 @@ static void ixgbe_rcv_ack_from_vf(struct ixgbe_adapter 
*adapter, u32 vf)
ixgbe_write_mbx(hw, &msg, 1, vf);
 }
 
+/**
+ * ixgbe_check_mdd_event - check for MDD event on all VFs
+ * @adapter: pointer to ixgbe adapter
+ *
+ * Return: true if there is a VF on which MDD event occurred, false otherwise.
+ */
+bool ixgbe_check_mdd_event(struct ixgbe_adapter *adapter)
+{
+   struct ixgbe_hw *hw = &adapter->hw;
+   DECLARE_BITMAP(vf_bitmap, 64);
+   bool ret = false;
+   int i;
+
+   if (!hw->mac.ops.handle_mdd)
+   return false;
+
+   /* Did we have a malicious event */
+   hw->mac.ops.handle_mdd(hw, vf_bitmap);
+
+   /* Log any blocked queues and release lock */
+   for_each_set_bit(i, vf_bitmap, 64) {
+   dev_warn(&adapter->pdev->dev,
+"Malicious event on VF %d tx:%x rx:%x\n", i,
+IXGBE_READ_REG(hw, IXGBE_LVMMC_TX),
+IXGBE_READ_REG(hw, IXGBE_LVMMC_RX));
+
+   if (hw->mac.ops.restore_mdd_vf) {
+   u32 ping;
+
+   hw->mac.ops.restore_mdd_vf(hw, i);
+
+   /* get the VF to rebuild its queues */
+   adapter->vfinfo[i].clear_to_send = 0;
+   ping = IXGBE_PF_CONTROL_MSG |
+  IXGBE_VT_MSGTYPE_CTS;
+   ixgbe_write_mbx(hw, &ping, 1, i);
+