Re: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler
Hi Sebastian, kernel test robot noticed the following build errors: [auto build test ERROR on tnguy-next-queue/dev-queue] [also build test ERROR on tnguy-net-queue/dev-queue linus/master v6.15-rc5 next-20250502] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/igb-Request-igb_msix_other-as-a-threaded-interrupt-handler/20250430-225615 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue patch link:https://lore.kernel.org/r/20250430144452.8zcAZc29%40linutronix.de patch subject: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250505/[email protected]/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250505/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): >> drivers/net/ethernet/intel/igb/igb_main.c:916:48: error: too few arguments >> to function call, expected 6, have 5 915 | err = request_threaded_irq(adapter->msix_entries[vector].vector, | 916 |igb_msix_other, 0, netdev->name, adapter); | ^ include/linux/interrupt.h:151:1: note: 'request_threaded_irq' declared here 151 | request_threaded_irq(unsigned int irq, irq_handler_t handler, | ^ 152 | irq_handler_t thread_fn, | 153 | unsigned long flags, const char *name, void *dev); | drivers/net/ethernet/intel/igb/igb_main.c:3229:46: warning: shift count >= width of type [-Wshift-count-overflow] 3229 | err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); | ^~~~ include/linux/dma-mapping.h:73:54: note: expanded from macro 'DMA_BIT_MASK' 73 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) | ^ ~~~ drivers/net/ethernet/intel/igb/igb_main.c:6199:14: warning: division by zero is undefined [-Wdivision-by-zero] 6199 | cmd_type |= IGB_SET_FLAG(tx_flags, IGB_TX_FLAGS_VLAN, | ^ 6200 | (E1000_ADVTXD_DCMD_VLE)); | drivers/net/ethernet/intel/igb/igb_main.c:6189:26: note: expanded from macro 'IGB_SET_FLAG' 6189 | ((u32)(_input & _flag) / (_flag / _result))) | ^ ~ drivers/net/ethernet/intel/igb/igb_main.c:6203:14: warning: division by zero is undefined [-Wdivision-by-zero] 6203 | cmd_type |= IGB_SET_FLAG(tx_flags, IGB_TX_FLAGS_TSO, | ^~~~ 6204 | (E1000_ADVTXD_DCMD_TSE)); | drivers/net/ethernet/intel/igb/igb_main.c:6189:26: note: expanded from macro 'IGB_SET_FLAG' 6189 | ((u32)(_input & _flag) / (_flag / _result))) | ^ ~ drivers/net/ethernet/intel/igb/igb_main.c:6207:14: warning: division by zero is undefined [-Wdivision-by-zero] 6207 | cmd_type |= IGB_SET_FLAG(tx_flags, IGB_TX_FLAGS_TSTAMP, | ^~~ 6208 | (E1000_ADVTXD_MAC_TSTAMP)); | ~~ drivers/net/ethernet/intel/igb/igb_main.c:6189:26: note: expanded from macro 'IGB_SET_FLAG' 6189 | ((u32)(_input & _flag) / (_flag / _result))) | ^ ~ drivers/net/ethernet/intel/igb/igb_main.c:6211:14: warning: division by zero is undefined [-Wdivision-by-zero] 6211 | cmd_type ^= IGB_SET_FLAG(skb->no_fcs, 1
Re: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler
Hi Sebastian, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-next-queue/dev-queue] [also build test WARNING on tnguy-net-queue/dev-queue linus/master v6.15-rc5 next-20250502] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/igb-Request-igb_msix_other-as-a-threaded-interrupt-handler/20250430-225615 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue patch link:https://lore.kernel.org/r/20250430144452.8zcAZc29%40linutronix.de patch subject: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250505/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250505/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All warnings (new ones prefixed by >>): drivers/net/ethernet/intel/igb/igb_main.c: In function 'igb_request_msix': >> drivers/net/ethernet/intel/igb/igb_main.c:916:61: warning: passing argument >> 4 of 'request_threaded_irq' makes integer from pointer without a cast >> [-Wint-conversion] 916 |igb_msix_other, 0, netdev->name, adapter); | ~~^~ | | | char * In file included from arch/x86/include/asm/highmem.h:24, from include/linux/highmem-internal.h:25, from include/linux/highmem.h:14, from include/linux/pagemap.h:11, from drivers/net/ethernet/intel/igb/igb_main.c:11: include/linux/interrupt.h:153:36: note: expected 'long unsigned int' but argument is of type 'char *' 153 | unsigned long flags, const char *name, void *dev); | ~~^ drivers/net/ethernet/intel/igb/igb_main.c:916:69: error: passing argument 5 of 'request_threaded_irq' from incompatible pointer type [-Werror=incompatible-pointer-types] 916 |igb_msix_other, 0, netdev->name, adapter); | ^~~ | | | struct igb_adapter * include/linux/interrupt.h:153:55: note: expected 'const char *' but argument is of type 'struct igb_adapter *' 153 | unsigned long flags, const char *name, void *dev); | ^~~~ drivers/net/ethernet/intel/igb/igb_main.c:915:15: error: too few arguments to function 'request_threaded_irq' 915 | err = request_threaded_irq(adapter->msix_entries[vector].vector, | ^~~~ include/linux/interrupt.h:151:1: note: declared here 151 | request_threaded_irq(unsigned int irq, irq_handler_t handler, | ^~~~ cc1: some warnings being treated as errors vim +/request_threaded_irq +916 drivers/net/ethernet/intel/igb/igb_main.c 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 901 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 902 /** 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 903 * igb_request_msix - Initialize MSI-X interrupts b980ac18c95f32 drivers/net/ethernet/intel/igb/igb_main.c Jeff Kirsher 2013-02-23 904 * @adapter: board private structure to initialize 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 905 * 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 906 * igb_request_msix allocates MSI-X vectors and requests interrupts from the 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 907 * kernel. 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 908 **/ 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-0
Re: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler
Hi Sebastian, kernel test robot noticed the following build errors: [auto build test ERROR on tnguy-next-queue/dev-queue] [also build test ERROR on tnguy-net-queue/dev-queue linus/master v6.15-rc4 next-20250501] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/igb-Request-igb_msix_other-as-a-threaded-interrupt-handler/20250430-225615 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue patch link:https://lore.kernel.org/r/20250430144452.8zcAZc29%40linutronix.de patch subject: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler config: loongarch-randconfig-002-20250502 (https://download.01.org/0day-ci/archive/20250502/[email protected]/config) compiler: loongarch64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250502/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All errors (new ones prefixed by >>): drivers/net/ethernet/intel/igb/igb_main.c: In function 'igb_request_msix': >> drivers/net/ethernet/intel/igb/igb_main.c:916:61: error: passing argument 4 >> of 'request_threaded_irq' makes integer from pointer without a cast >> [-Wint-conversion] 916 |igb_msix_other, 0, netdev->name, adapter); | ~~^~ | | | char * In file included from include/linux/kernel_stat.h:8, from include/linux/cgroup.h:26, from include/net/netprio_cgroup.h:11, from include/linux/netdevice.h:42, from drivers/net/ethernet/intel/igb/igb_main.c:12: include/linux/interrupt.h:153:36: note: expected 'long unsigned int' but argument is of type 'char *' 153 | unsigned long flags, const char *name, void *dev); | ~~^ >> drivers/net/ethernet/intel/igb/igb_main.c:916:69: error: passing argument 5 >> of 'request_threaded_irq' from incompatible pointer type >> [-Wincompatible-pointer-types] 916 |igb_msix_other, 0, netdev->name, adapter); | ^~~ | | | struct igb_adapter * include/linux/interrupt.h:153:55: note: expected 'const char *' but argument is of type 'struct igb_adapter *' 153 | unsigned long flags, const char *name, void *dev); | ^~~~ >> drivers/net/ethernet/intel/igb/igb_main.c:915:15: error: too few arguments >> to function 'request_threaded_irq' 915 | err = request_threaded_irq(adapter->msix_entries[vector].vector, | ^~~~ include/linux/interrupt.h:151:1: note: declared here 151 | request_threaded_irq(unsigned int irq, irq_handler_t handler, | ^~~~ vim +/request_threaded_irq +916 drivers/net/ethernet/intel/igb/igb_main.c 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 901 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 902 /** 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 903 * igb_request_msix - Initialize MSI-X interrupts b980ac18c95f32 drivers/net/ethernet/intel/igb/igb_main.c Jeff Kirsher 2013-02-23 904 * @adapter: board private structure to initialize 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 905 * 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 906 * igb_request_msix allocates MSI-X vectors and requests interrupts from the 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 907 * kernel. 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 908 **/ 9d5c824399dea8 drivers/net/igb/igb_main.cAuke Kok 2008-01-24 909 static int igb_request_msix(str
