Re: [Intel-wired-lan] [PATCH net-next 4/5] devlink: Make health reporter grace period delay configurable

2025-07-20 Thread Tariq Toukan




On 19/07/2025 3:51, Jakub Kicinski wrote:

On Thu, 17 Jul 2025 19:07:21 +0300 Tariq Toukan wrote:

diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index e72bcc239afd..42a11b7e4a70 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -634,6 +634,8 @@ enum devlink_attr {
  
  	DEVLINK_ATTR_REGION_DIRECT,		/* flag */
  
+	DEVLINK_ATTR_HEALTH_REPORTER_GRACEFUL_PERIOD_DELAY,	/* u64 */

+
DEVLINK_ATTR_RATE_TC_BWS,   /* nested */
DEVLINK_ATTR_RATE_TC_INDEX, /* u8 */
DEVLINK_ATTR_RATE_TC_BW,/* u32 */


BTW the patch from Carolina to cut the TC attributes from the main enum
is higher prio that this.



WIP. We'll send it soon.



Re: [Intel-wired-lan] [PATCH net-next 4/5] devlink: Make health reporter grace period delay configurable

2025-07-20 Thread Tariq Toukan




On 19/07/2025 3:48, Jakub Kicinski wrote:

On Thu, 17 Jul 2025 19:07:21 +0300 Tariq Toukan wrote:

+   DEVLINK_ATTR_HEALTH_REPORTER_GRACEFUL_PERIOD_DELAY, /* u64 */


/me pulls out a ruler

50 characters, -ENAMETOOLONG


We'll address.


Re: [Intel-wired-lan] [PATCH net-next 4/5] devlink: Make health reporter grace period delay configurable

2025-07-18 Thread Jakub Kicinski
On Thu, 17 Jul 2025 19:07:21 +0300 Tariq Toukan wrote:
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index e72bcc239afd..42a11b7e4a70 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -634,6 +634,8 @@ enum devlink_attr {
>  
>   DEVLINK_ATTR_REGION_DIRECT, /* flag */
>  
> + DEVLINK_ATTR_HEALTH_REPORTER_GRACEFUL_PERIOD_DELAY, /* u64 */
> +
>   DEVLINK_ATTR_RATE_TC_BWS,   /* nested */
>   DEVLINK_ATTR_RATE_TC_INDEX, /* u8 */
>   DEVLINK_ATTR_RATE_TC_BW,/* u32 */

BTW the patch from Carolina to cut the TC attributes from the main enum
is higher prio that this.


Re: [Intel-wired-lan] [PATCH net-next 4/5] devlink: Make health reporter grace period delay configurable

2025-07-18 Thread Jakub Kicinski
On Thu, 17 Jul 2025 19:07:21 +0300 Tariq Toukan wrote:
> + DEVLINK_ATTR_HEALTH_REPORTER_GRACEFUL_PERIOD_DELAY, /* u64 */

/me pulls out a ruler

50 characters, -ENAMETOOLONG
-- 
pw-bot: cr