Re: [Intel-wired-lan] [iwl-next v3 1/4] ixgbe: add MDD support

2025-06-27 Thread Romanowski, Rafal
> -Original Message-
> From: Intel-wired-lan  On Behalf Of Simon
> Horman
> Sent: Tuesday, February 18, 2025 8:36 PM
> To: Michal Swiatkowski 
> Cc: [email protected]; [email protected];
> [email protected]; Jagielski, Jedrzej 
> ;
> Kitszel, Przemyslaw ; Kwapulinski, Piotr
> ; Nguyen, Anthony L
> ; Osuchowski, Dawid
> ; [email protected]
> Subject: Re: [Intel-wired-lan] [iwl-next v3 1/4] ixgbe: add MDD support
> 
> On Mon, Feb 17, 2025 at 10:06:33AM +0100, Michal Swiatkowski wrote:
> > From: Paul Greenwalt 
> >
> > Add malicious driver detection to ixgbe driver. The supported devices
> > are E610 and X550.
> >
> > Handling MDD events is enabled while VFs are created and turned off
> > when they are disabled. here is no runtime command to enable or
> > disable MDD independently.
> >
> > MDD event is logged when malicious VF driver is detected. For example
> > VF can try to send incorrect Tx descriptor (TSO on, but length field
> > not correct). It can be reproduced by manipulating the driver, or
> > using DPDK driver with incorrect descriptor values.
> >
> > Example log:
> > "Malicious event on VF 0 tx:128 rx:128"
> >
> > Reviewed-by: Przemek Kitszel 
> > Reviewed-by: Jedrzej Jagielski 
> > Reviewed-by: Marcin Szycik 
> > Signed-off-by: Paul Greenwalt 
> > Signed-off-by: Michal Swiatkowski 
> 
> Reviewed-by: Simon Horman 

Tested-by: Rafal Romanowski 




Re: [Intel-wired-lan] [iwl-next v3 1/4] ixgbe: add MDD support

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 10:06:33AM +0100, Michal Swiatkowski wrote:
> From: Paul Greenwalt 
> 
> Add malicious driver detection to ixgbe driver. The supported devices
> are E610 and X550.
> 
> Handling MDD events is enabled while VFs are created and turned off
> when they are disabled. here is no runtime command to enable or
> disable MDD independently.
> 
> MDD event is logged when malicious VF driver is detected. For example VF
> can try to send incorrect Tx descriptor (TSO on, but length field not
> correct). It can be reproduced by manipulating the driver, or using DPDK
> driver with incorrect descriptor values.
> 
> Example log:
> "Malicious event on VF 0 tx:128 rx:128"
> 
> Reviewed-by: Przemek Kitszel 
> Reviewed-by: Jedrzej Jagielski 
> Reviewed-by: Marcin Szycik 
> Signed-off-by: Paul Greenwalt 
> Signed-off-by: Michal Swiatkowski 

Reviewed-by: Simon Horman