Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)

2016-05-02 Thread Oliver Nie
@robinsmidsrod I got another board which has two NICs. Net0 is using intel 82567lm, net1 is using intel 82576eb. My patch is on 82576eb. Following are the results on loopback tests. Enabled debugging level 3 for intel and netdevice. The failed case shows 1 packet transmitted but nothing received

Re: [ipxe-devel] [PATCH v3 2/3] [virtio] Renumber virtio_pci_region flags

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 06:41 PM, Ladi Prosek wrote: Some of the regions may end up being unmapped, either because they are optional or because the attempt to map them has failed. Region types starting at 0 didn't make it easy to test for this condition. This commit bumps all valid region types up by 1 wi

Re: [ipxe-devel] Windows loading issue

2016-05-02 Thread Ladi Prosek
On Sat, Apr 30, 2016 at 2:54 PM, Mohammad Oslani wrote: > Hello, > > We are trying to load windows over ipxe and followed over this page : > http://ipxe.org/wimboot > > However I am unable to get it loaded correctly, after everything is > loaded and server boots up again I get always a blue scree.

[ipxe-devel] [PATCH v3 3/3] [virtio] Enable and restore PCI device correctly

2016-05-02 Thread Ladi Prosek
The driver enabled both memory and I/O access even if they were not usable, e.g. BAR not mapped by BIOS. This commit fixes it by enabling only the BAR types actually used. The device is also restored to the original state (in terms of the command PCI register) on removal. Reviewed-by: Marcel Apfel

[ipxe-devel] [PATCH v3 2/3] [virtio] Renumber virtio_pci_region flags

2016-05-02 Thread Ladi Prosek
Some of the regions may end up being unmapped, either because they are optional or because the attempt to map them has failed. Region types starting at 0 didn't make it easy to test for this condition. This commit bumps all valid region types up by 1 with 0 having the implicit 'unmapped' meaning.

[ipxe-devel] [PATCH v3 1/3] [pci] Add pci_enable_device and pci_restore_device

2016-05-02 Thread Ladi Prosek
This commit adds two new functions. pci_enable_device gives drivers finer control over how the PCI device is initialized and pci_restore_device is the shutdown path counterpart. adjust_pci_device is now implemented in terms of pci_enable_device and its functionality hasn't changed, i.e. it still u

[ipxe-devel] [PATCH v3 0/3] [virtio] Enable and restore PCI device correctly

2016-05-02 Thread Ladi Prosek
This series is a follow-up to our virtio 1.0 discussion. The first patch adds two new functions as suggested by Michael and the third one makes virtio-net call them. Changes v1->v2: * fixed comment 'busmaster' -> 'bus master' * renamed functions 'enable_pci_device' -> 'pci_enable_device', 'disa

Re: [ipxe-devel] [PATCH v2 2/3] [virtio] Renumber virtio_pci_region flags

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 05:38 PM, Ladi Prosek wrote: On Mon, May 2, 2016 at 4:21 PM, Marcel Apfelbaum wrote: On 05/02/2016 04:11 PM, Ladi Prosek wrote: Some of the regions may end up being unmapped, either because they are optional or because the attempt to map them has failed. Region types starting at

Re: [ipxe-devel] [PATCH v2 2/3] [virtio] Renumber virtio_pci_region flags

2016-05-02 Thread Ladi Prosek
On Mon, May 2, 2016 at 4:21 PM, Marcel Apfelbaum wrote: > On 05/02/2016 04:11 PM, Ladi Prosek wrote: >> >> Some of the regions may end up being unmapped, either because >> they are optional or because the attempt to map them has failed. >> Region types starting at 0 didn't make it easy to test for

Re: [ipxe-devel] [PATCH v2 2/3] [virtio] Renumber virtio_pci_region flags

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 04:11 PM, Ladi Prosek wrote: Some of the regions may end up being unmapped, either because they are optional or because the attempt to map them has failed. Region types starting at 0 didn't make it easy to test for this condition. This commit adds VIRTIO_PCI_REGION_NONE with the va

Re: [ipxe-devel] [PATCH v2 3/3] [virtio] Enable and restore PCI device correctly

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 04:11 PM, Ladi Prosek wrote: The driver enabled both memory and I/O access even if they were not usable, e.g. BAR not mapped by BIOS. This commit fixes it by enabling only the BAR types actually used. The device is also restored to the original state (in terms of the command PCI reg

Re: [ipxe-devel] [PATCH v2 1/3] [pci] Add pci_enable_device and pci_restore_device

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 04:11 PM, Ladi Prosek wrote: This commit adds two new functions. pci_enable_device gives drivers finer control over how the PCI device is initialized and pci_restore_device is the shutdown path counterpart. adjust_pci_device is now implemented in terms of pci_enable_device and its

[ipxe-devel] [PATCH v2 3/3] [virtio] Enable and restore PCI device correctly

2016-05-02 Thread Ladi Prosek
The driver enabled both memory and I/O access even if they were not usable, e.g. BAR not mapped by BIOS. This commit fixes it by enabling only the BAR types actually used. The device is also restored to the original state (in terms of the command PCI register) on removal. Signed-off-by: Ladi Prose

[ipxe-devel] [PATCH v2 1/3] [pci] Add pci_enable_device and pci_restore_device

2016-05-02 Thread Ladi Prosek
This commit adds two new functions. pci_enable_device gives drivers finer control over how the PCI device is initialized and pci_restore_device is the shutdown path counterpart. adjust_pci_device is now implemented in terms of pci_enable_device and its functionality hasn't changed, i.e. it still u

[ipxe-devel] [PATCH v2 2/3] [virtio] Renumber virtio_pci_region flags

2016-05-02 Thread Ladi Prosek
Some of the regions may end up being unmapped, either because they are optional or because the attempt to map them has failed. Region types starting at 0 didn't make it easy to test for this condition. This commit adds VIRTIO_PCI_REGION_NONE with the value of 0 and bumps the valid region types up

[ipxe-devel] [PATCH v2 0/3] [virtio] Enable and restore PCI device correctly

2016-05-02 Thread Ladi Prosek
This series is a follow-up to our virtio 1.0 discussion. The first patch adds two new functions as suggested by Michael and the third one makes virtio-net call them. Changes v1->v2: * fixed comment 'busmaster' -> 'bus master' * renamed functions 'enable_pci_device' -> 'pci_enable_device', 'disa

Re: [ipxe-devel] [PATCH 1/2] [pci] Add enable_pci_device and disable_pci_device

2016-05-02 Thread Michael S. Tsirkin
On Mon, May 02, 2016 at 09:39:34AM +0200, Ladi Prosek wrote: > On Sun, May 1, 2016 at 2:24 PM, Marcel Apfelbaum wrote: > > Hi Ladi, > > > > On 04/28/2016 06:34 PM, Ladi Prosek wrote: > >> > >> adjust_pci_device unconditionally enables both memory and I/O space > >> access, which may not be necessa

Re: [ipxe-devel] [PATCH 2/2] [virtio] Enable and disable PCI device correctly

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 11:00 AM, Ladi Prosek wrote: On Sun, May 1, 2016 at 2:41 PM, Michael S. Tsirkin wrote: On Sun, May 01, 2016 at 03:25:07PM +0300, Marcel Apfelbaum wrote: On 04/28/2016 06:34 PM, Ladi Prosek wrote: The driver enabled both memory and I/O access even if they were not usable, e.g. BA

Re: [ipxe-devel] [PATCH 1/2] [pci] Add enable_pci_device and disable_pci_device

2016-05-02 Thread Ladi Prosek
On Mon, May 2, 2016 at 9:58 AM, Marcel Apfelbaum wrote: > On 05/02/2016 10:39 AM, Ladi Prosek wrote: >> >> On Sun, May 1, 2016 at 2:24 PM, Marcel Apfelbaum >> wrote: >>> >>> Hi Ladi, >>> >>> On 04/28/2016 06:34 PM, Ladi Prosek wrote: adjust_pci_device unconditionally enables both m

Re: [ipxe-devel] [PATCH 2/2] [virtio] Enable and disable PCI device correctly

2016-05-02 Thread Ladi Prosek
On Sun, May 1, 2016 at 2:41 PM, Michael S. Tsirkin wrote: > On Sun, May 01, 2016 at 03:25:07PM +0300, Marcel Apfelbaum wrote: >> On 04/28/2016 06:34 PM, Ladi Prosek wrote: >> >The driver enabled both memory and I/O access even if they were >> >not usable, e.g. BAR not mapped by BIOS. This commit f

Re: [ipxe-devel] [PATCH 1/2] [pci] Add enable_pci_device and disable_pci_device

2016-05-02 Thread Marcel Apfelbaum
On 05/02/2016 10:39 AM, Ladi Prosek wrote: On Sun, May 1, 2016 at 2:24 PM, Marcel Apfelbaum wrote: Hi Ladi, On 04/28/2016 06:34 PM, Ladi Prosek wrote: adjust_pci_device unconditionally enables both memory and I/O space access, which may not be necessary. The above problem is not addressed

Re: [ipxe-devel] [PATCH 1/2] [pci] Add enable_pci_device and disable_pci_device

2016-05-02 Thread Ladi Prosek
On Sun, May 1, 2016 at 2:24 PM, Marcel Apfelbaum wrote: > Hi Ladi, > > On 04/28/2016 06:34 PM, Ladi Prosek wrote: >> >> adjust_pci_device unconditionally enables both memory and I/O space >> access, which may not be necessary. > > > The above problem is not addressed in this patch, > people my get

Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)

2016-05-02 Thread Robin Smidsrød
@olivernie Thanks for the test feedback. The loopback tests are most of the time tested with two NICs in the same system, with one being the one under test and the other one a known working NIC. This ensures that there is no packet drop in the receive and transmit data paths and that VLAN featur