Re: [PR] [C++] Improve readability of SchemaTests [avro]

2024-09-22 Thread via GitHub
pascalginter commented on code in PR #3167: URL: https://github.com/apache/avro/pull/3167#discussion_r1770841955 ## lang/c++/test/SchemaTests.cc: ## @@ -315,11 +436,13 @@ static void testRoundTrip(const char *schema) { compiledSchema.toJson(os); std::string result = os

[jira] [Commented] (AVRO-4058) Issue in schema preservation

2024-09-22 Thread Pascal Ginter (Jira)
[ https://issues.apache.org/jira/browse/AVRO-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883704#comment-17883704 ] Pascal Ginter commented on AVRO-4058: - I agree that the spec is not the most clear. I

Re: [PR] [C++] Improve readability of SchemaTests [avro]

2024-09-22 Thread via GitHub
Gerrit0 commented on code in PR #3167: URL: https://github.com/apache/avro/pull/3167#discussion_r1770738406 ## lang/c++/test/SchemaTests.cc: ## @@ -315,11 +436,13 @@ static void testRoundTrip(const char *schema) { compiledSchema.toJson(os); std::string result = os.str(

[jira] [Commented] (AVRO-4049) Use JDK Equals in UTF8

2024-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AVRO-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883650#comment-17883650 ] ASF subversion and git services commented on AVRO-4049: --- Commit 9bff

[jira] [Commented] (AVRO-4049) Use JDK Equals in UTF8

2024-09-22 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/AVRO-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883625#comment-17883625 ] David Mollitor commented on AVRO-4049: -- During some micro-benchmarking, I found that

[jira] (AVRO-4045) Use JDK to Compare Byte Array Lexicographically

2024-09-22 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/AVRO-4045 ] David Mollitor deleted comment on AVRO-4045: -- was (Author: belugabehr): During some micro-benchmarking, I found that there was a significant overhead to calling the JDK method Arrays#equals.

[jira] [Commented] (AVRO-4045) Use JDK to Compare Byte Array Lexicographically

2024-09-22 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/AVRO-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883622#comment-17883622 ] David Mollitor commented on AVRO-4045: -- During some micro-benchmarking, I found that

Re: [PR] Bump com.google.protobuf:protobuf-java from 4.28.0 to 4.28.1 in /lang/java [avro]

2024-09-22 Thread via GitHub
dependabot[bot] commented on PR #3161: URL: https://github.com/apache/avro/pull/3161#issuecomment-2366891540 Superseded by #3172. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] AVRO-4045: Use JDK compare for byte arrays [avro]

2024-09-22 Thread via GitHub
belugabehr commented on code in PR #3126: URL: https://github.com/apache/avro/pull/3126#discussion_r1770598130 ## lang/java/avro/src/main/java/org/apache/avro/io/BinaryData.java: ## @@ -181,16 +184,7 @@ private static int compare(Decoders d, Schema schema) throws IOException {

Re: [PR] AVRO-4045: Use JDK compare for byte arrays [avro]

2024-09-22 Thread via GitHub
belugabehr commented on code in PR #3126: URL: https://github.com/apache/avro/pull/3126#discussion_r1770598130 ## lang/java/avro/src/main/java/org/apache/avro/io/BinaryData.java: ## @@ -181,16 +184,7 @@ private static int compare(Decoders d, Schema schema) throws IOException {