[GitHub] [flink] zhoulii commented on pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
zhoulii commented on PR #19946: URL: https://github.com/apache/flink/pull/19946#issuecomment-1154791356 > > Maybe add a hotfix commit "Rework BinaryInputFormatTest to be based on AssertJ" first. And then add the new test using AssertJ. > > same as @zhuzhurk's previous suggestion, you

[jira] [Commented] (FLINK-28028) Common secure credential protection mechanism in Flink SQL

2022-06-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553931#comment-17553931 ] Martijn Visser commented on FLINK-28028: A potential solution was brought forwar

[jira] [Updated] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28033: --- Description: File: StatusWatermarkValve.java Method:  findAndOutputNewMinWatermarkAcrossAli

[GitHub] [flink] shuiqiangchen commented on pull request #19140: [FLINK-25231][python]Update Pyflink to use the new type system

2022-06-13 Thread GitBox
shuiqiangchen commented on PR #19140: URL: https://github.com/apache/flink/pull/19140#issuecomment-1154786882 @HuangXingBo Thank you for your comments. I have updated the PR according to your suggestions, please have look. -- This is an automated message from the Apache Git Service. To re

[jira] [Updated] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28033: --- Priority: Major (was: Blocker) > find and output new min watermark mybe wrong when in multi

[GitHub] [flink] reswqa commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
reswqa commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896438515 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -73,13 +76,21 @@ public void testCreateInputSplitsWithOneFile() throws IOExc

[GitHub] [flink] reswqa commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
reswqa commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896430817 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -154,17 +170,60 @@ public void testGetStatisticsMultiplePaths() throws IOExc

[GitHub] [flink] reswqa commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
reswqa commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896430817 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -154,17 +170,60 @@ public void testGetStatisticsMultiplePaths() throws IOExc

[jira] [Commented] (FLINK-28026) Add benchmark module for flink table store

2022-06-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553929#comment-17553929 ] Jingsong Lee commented on FLINK-28026: -- [~Aiden Gong] Thanks! > Add benchmark modu

[jira] [Assigned] (FLINK-28026) Add benchmark module for flink table store

2022-06-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee reassigned FLINK-28026: Assignee: Aiden Gong > Add benchmark module for flink table store > -

[jira] [Closed] (FLINK-28032) Checkpointing hangs and times out with some jobs

2022-06-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-28032. Resolution: Information Provided The thread dump on taskmanager does not have a good format for people to

[jira] [Commented] (FLINK-28037) Flink SQL Upsert-Kafka can not support Flink1.14.x

2022-06-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553927#comment-17553927 ] Martijn Visser commented on FLINK-28037: [~renqs] Can you have a look at this on

[jira] [Updated] (FLINK-28037) Flink SQL Upsert-Kafka can not support Flink1.14.x

2022-06-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28037: --- Affects Version/s: (was: 1.14.0) (was: 1.14.2)

[GitHub] [flink] reswqa commented on pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
reswqa commented on PR #19946: URL: https://github.com/apache/flink/pull/19946#issuecomment-1154783029 > Maybe add a hotfix commit "Rework BinaryInputFormatTest to be based on AssertJ" first. And then add the new test using AssertJ. same as @zhuzhurk's previous suggestion, you should

[GitHub] [flink] dusukang commented on pull request #19741: [FLINK-27794][connectors/jdbc]Fix the bug of wrong primary key in MysqlCatalog

2022-06-13 Thread GitBox
dusukang commented on PR #19741: URL: https://github.com/apache/flink/pull/19741#issuecomment-1154782595 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] reswqa commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
reswqa commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896422901 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -73,13 +76,21 @@ public void testCreateInputSplitsWithOneFile() throws IOExc

[GitHub] [flink] fsk119 commented on a diff in pull request #19823: [FLINK-27766][sql-gateway] Introduce the framework of the SqlGatewayService

2022-06-13 Thread GitBox
fsk119 commented on code in PR #19823: URL: https://github.com/apache/flink/pull/19823#discussion_r896426974 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java: ## @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache Sof

[jira] [Resolved] (FLINK-28038) RocksDB rescaling improvement & rescaling benchmark - umbrella ticket

2022-06-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei resolved FLINK-28038. -- Resolution: Fixed > RocksDB rescaling improvement & rescaling benchmark - umbrella ticket > --

[jira] [Assigned] (FLINK-28038) RocksDB rescaling improvement & rescaling benchmark - umbrella ticket

2022-06-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei reassigned FLINK-28038: Assignee: Yanfei Lei > RocksDB rescaling improvement & rescaling benchmark - umbrella ticket > --

[jira] [Updated] (FLINK-28038) RocksDB rescaling improvement & rescaling benchmark - umbrella ticket

2022-06-13 Thread Yuan Mei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuan Mei updated FLINK-28038: - Fix Version/s: 1.16.0 > RocksDB rescaling improvement & rescaling benchmark - umbrella ticket >

[GitHub] [flink] fsk119 commented on a diff in pull request #19823: [FLINK-27766][sql-gateway] Introduce the framework of the SqlGatewayService

2022-06-13 Thread GitBox
fsk119 commented on code in PR #19823: URL: https://github.com/apache/flink/pull/19823#discussion_r896425180 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/session/SessionManager.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Sof

[jira] [Commented] (FLINK-28035) Don't check num of buckets for rescale bucket condition

2022-06-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553917#comment-17553917 ] Jingsong Lee commented on FLINK-28035: -- Can you add some description? > Don't chec

[jira] [Updated] (FLINK-28035) Don't check num of buckets for rescale bucket condition

2022-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28035: --- Labels: pull-request-available (was: ) > Don't check num of buckets for rescale bucket cond

[GitHub] [flink-table-store] JingsongLi commented on pull request #157: [FLINK-28035] Don't check num of buckets for rescale bucket condition

2022-06-13 Thread GitBox
JingsongLi commented on PR #157: URL: https://github.com/apache/flink-table-store/pull/157#issuecomment-1154769567 Why just check for rescale? Throws exception for normal reading? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Created] (FLINK-28040) Introduce Trino reader for table store

2022-06-13 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-28040: Summary: Introduce Trino reader for table store Key: FLINK-28040 URL: https://issues.apache.org/jira/browse/FLINK-28040 Project: Flink Issue Type: Sub-task

[GitHub] [flink] zhoulii commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
zhoulii commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896417184 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -160,11 +161,45 @@ public void testGetStatisticsMultiplePaths() throws IOEx

[jira] [Updated] (FLINK-27947) Introduce Spark Reader for table store

2022-06-13 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-27947: - Parent: FLINK-28039 Issue Type: Sub-task (was: New Feature) > Introduce Spark Reader fo

[jira] [Updated] (FLINK-23399) Add a performance benchmark for statebackend rescaling

2022-06-13 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei updated FLINK-23399: --- Parent: FLINK-28038 Issue Type: Sub-task (was: Improvement) > Add a performance benchmark f

[jira] [Created] (FLINK-28039) Flink Table Store Ecosystem: Compute Engine Readers

2022-06-13 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-28039: Summary: Flink Table Store Ecosystem: Compute Engine Readers Key: FLINK-28039 URL: https://issues.apache.org/jira/browse/FLINK-28039 Project: Flink Issue Typ

[jira] [Updated] (FLINK-26560) Make the threshold of the overlap fraction of incremental restoring configurable

2022-06-13 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei updated FLINK-26560: --- Parent: FLINK-28038 Issue Type: Sub-task (was: Improvement) > Make the threshold of the ove

[GitHub] [flink] dianfu commented on a diff in pull request #19896: [FLINK-27932][python] align noWatermarks and withWatermarkAlignment API

2022-06-13 Thread GitBox
dianfu commented on code in PR #19896: URL: https://github.com/apache/flink/pull/19896#discussion_r896402211 ## docs/content.zh/docs/dev/datastream/event-time/generating_watermarks.md: ## @@ -77,6 +77,19 @@ WatermarkStrategy }) ``` {{< /tab >}} +{{< tab "Python" >}} Review

[jira] [Created] (FLINK-28038) RocksDB rescaling improvement & rescaling benchmark - umbrella ticket

2022-06-13 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-28038: -- Summary: RocksDB rescaling improvement & rescaling benchmark - umbrella ticket Key: FLINK-28038 URL: https://issues.apache.org/jira/browse/FLINK-28038 Project: Flink

[jira] [Assigned] (FLINK-26941) Support Pattern end with notFollowedBy with window

2022-06-13 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-26941: --- Assignee: Yue Ma > Support Pattern end with notFollowedBy with window > ---

[GitHub] [flink] reswqa commented on a diff in pull request #19927: [FLINK-27903][runtime] Introduce and support HYBRID resultPartitionType

2022-06-13 Thread GitBox
reswqa commented on code in PR #19927: URL: https://github.com/apache/flink/pull/19927#discussion_r896405257 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1201,6 +1243,33 @@ private void verifyFractions(

[GitHub] [flink] reswqa commented on a diff in pull request #19927: [FLINK-27903][runtime] Introduce and support HYBRID resultPartitionType

2022-06-13 Thread GitBox
reswqa commented on code in PR #19927: URL: https://github.com/apache/flink/pull/19927#discussion_r896405257 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java: ## @@ -1201,6 +1243,33 @@ private void verifyFractions(

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
zhuzhurk commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896403096 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -160,11 +161,45 @@ public void testGetStatisticsMultiplePaths() throws IOE

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
zhuzhurk commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896402127 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -160,11 +161,45 @@ public void testGetStatisticsMultiplePaths() throws IOE

[GitHub] [flink] godfreyhe commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-06-13 Thread GitBox
godfreyhe commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1154742694 @libenchao, Hope you can continue to move forward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] Aitozi commented on pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-13 Thread GitBox
Aitozi commented on PR #19840: URL: https://github.com/apache/flink/pull/19840#issuecomment-1154742585 Hi @KarmaGYZ , I have rebased this PR based on the previous commit, please take a look again, thanks. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [flink] reswqa commented on pull request #19882: [hotfix] fix a typo in NetworkBufferTest

2022-06-13 Thread GitBox
reswqa commented on PR #19882: URL: https://github.com/apache/flink/pull/19882#issuecomment-1154728455 @wsry Just a very small hotfix, would you like to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] reswqa closed pull request #14498: [hotfix][typo]Fix typo in StreamingJobGraphGenerator.areOperatorsChainable

2022-06-13 Thread GitBox
reswqa closed pull request #14498: [hotfix][typo]Fix typo in StreamingJobGraphGenerator.areOperatorsChainable URL: https://github.com/apache/flink/pull/14498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] reswqa commented on pull request #14498: [hotfix][typo]Fix typo in StreamingJobGraphGenerator.areOperatorsChainable

2022-06-13 Thread GitBox
reswqa commented on PR #14498: URL: https://github.com/apache/flink/pull/14498#issuecomment-1154727170 fixed by FLINK-27903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #19950: [hotfix] [docs] Translate a Chinese comment into English

2022-06-13 Thread GitBox
flinkbot commented on PR #19950: URL: https://github.com/apache/flink/pull/19950#issuecomment-1154726348 ## CI report: * 19abcb256444ba684736e355bf76986a79d5f501 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] diohabara opened a new pull request, #19950: [hotfix] [docs] Translate a Chinese comment into English

2022-06-13 Thread GitBox
diohabara opened a new pull request, #19950: URL: https://github.com/apache/flink/pull/19950 I translate a Chinese comment in the sample code into English for more people to understand it. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Created] (FLINK-28037) Flink SQL Upsert-Kafka can not support Flink1.14.x

2022-06-13 Thread Jiangfei Liu (Jira)
Jiangfei Liu created FLINK-28037: Summary: Flink SQL Upsert-Kafka can not support Flink1.14.x Key: FLINK-28037 URL: https://issues.apache.org/jira/browse/FLINK-28037 Project: Flink Issue Type

[jira] [Updated] (FLINK-15635) Allow passing a ClassLoader to EnvironmentSettings

2022-06-13 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-15635: Parent: FLINK-14055 Issue Type: Sub-task (was: Improvement) > Allow passing a ClassLoader to Envi

[jira] [Commented] (FLINK-27828) FlinkKafkaProducer VS KafkaSink

2022-06-13 Thread Jiangfei Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553892#comment-17553892 ] Jiangfei Liu commented on FLINK-27828: -- checkpoint config:         CheckpointConfi

[jira] [Commented] (FLINK-27828) FlinkKafkaProducer VS KafkaSink

2022-06-13 Thread Jiangfei Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553891#comment-17553891 ] Jiangfei Liu commented on FLINK-27828: -- parallelism:3 checkpoint config:        

[jira] (FLINK-27828) FlinkKafkaProducer VS KafkaSink

2022-06-13 Thread Jiangfei Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27828 ] Jiangfei Liu deleted comment on FLINK-27828: -- was (Author: JIRAUSER290004): parallelism:3 checkpoint config:         CheckpointConfig checkpointConfig = env.getCheckpointConfig();        

[jira] [Commented] (FLINK-26721) PulsarSourceITCase.testSavepoint failed on azure pipeline

2022-06-13 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553889#comment-17553889 ] godfrey he commented on FLINK-26721: https://dev.azure.com/apache-flink/apache-flink

[GitHub] [flink] flinkbot commented on pull request #19949: [FLINK-28036][hive] HiveInspectors should use correct writable type to create ConstantObjectInspector

2022-06-13 Thread GitBox
flinkbot commented on PR #19949: URL: https://github.com/apache/flink/pull/19949#issuecomment-1154694926 ## CI report: * b2f5199f5d430f4684e63f5f4d4317690c7f53e2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
reswqa commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896360739 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -160,11 +161,45 @@ public void testGetStatisticsMultiplePaths() throws IOExc

[GitHub] [flink] luoyuxia opened a new pull request, #19949: [FLINK-28036][hive] HiveInspectors should use correct writable type to create ConstantObjectInspector

2022-06-13 Thread GitBox
luoyuxia opened a new pull request, #19949: URL: https://github.com/apache/flink/pull/19949 ## What is the purpose of the change To make `HiveInspectors` use correct writable type to create ConstantObjectInspector ## Brief change log Replace `org.apache.hadoop.io.Byt

[jira] [Updated] (FLINK-28036) HiveInspectors should use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28036: --- Labels: pull-request-available (was: ) > HiveInspectors should use correct writable type to

[GitHub] [flink] snuyanzin commented on pull request #18779: [hotfix][javadoc] Misprint in javadoc at QuadFunction.java

2022-06-13 Thread GitBox
snuyanzin commented on PR #18779: URL: https://github.com/apache/flink/pull/18779#issuecomment-1154691101 @MartijnVisser sorry for the poke. Could you please have a look once you have time? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Closed] (FLINK-27658) FlinkUserCodeClassLoader expose addURL method to allow to register jar dynamically

2022-06-13 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-27658. --- Assignee: dalongliu Resolution: Fixed Done via: 2e37a06368596ca9ed04366a879f2facfb7ef509 > FlinkUser

[GitHub] [flink] zhuzhurk merged pull request #19860: [FLINK-27658][table] FlinkUserCodeClassLoader expose addURL method to allow to register jar dynamically

2022-06-13 Thread GitBox
zhuzhurk merged PR #19860: URL: https://github.com/apache/flink/pull/19860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] reswqa commented on a diff in pull request #19849: [FLINK-27767][sql-gateway] Introduce Endpoint API and utils

2022-06-13 Thread GitBox
reswqa commented on code in PR #19849: URL: https://github.com/apache/flink/pull/19849#discussion_r896357754 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/session/SessionManagerTest.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache

[GitHub] [flink] reswqa commented on a diff in pull request #19939: [FLINK-27983][FLINK-27984][FLINK-27985] Introduce SupportsStatisticsReport, FileBasedStatisticsReportableDecodingFormat, FlinkRecomp

2022-06-13 Thread GitBox
reswqa commented on code in PR #19939: URL: https://github.com/apache/flink/pull/19939#discussion_r896353277 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/connector/file/table/FileSystemStatisticsReportTest.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the A

[GitHub] [flink] reswqa commented on a diff in pull request #19939: [FLINK-27983][FLINK-27984][FLINK-27985] Introduce SupportsStatisticsReport, FileBasedStatisticsReportableDecodingFormat, FlinkRecomp

2022-06-13 Thread GitBox
reswqa commented on code in PR #19939: URL: https://github.com/apache/flink/pull/19939#discussion_r896352923 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java: ## @@ -0,0 +1,203 @@ +/* + *

[GitHub] [flink] zhoulii commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
zhoulii commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896348640 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -160,6 +160,44 @@ public void testGetStatisticsMultiplePaths() throws IOExc

[jira] [Commented] (FLINK-28034) ClassCastException occurred in creating a checkpoint with merge windows

2022-06-13 Thread Takayuki Eimizu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553883#comment-17553883 ] Takayuki Eimizu commented on FLINK-28034: - I have already implemented a fix for

[GitHub] [flink] PatrickRen commented on pull request #19456: [FLINK-27041][connector/kafka] Catch IllegalStateException in KafkaPartitionSplitReader.fetch() to handle no valid partition case

2022-06-13 Thread GitBox
PatrickRen commented on PR #19456: URL: https://github.com/apache/flink/pull/19456#issuecomment-1154675519 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-28036) HiveInspectors should use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28036: - Description: In HiveInspectors, we will create Hive's ConstantObjectInspector by passing writable type

[GitHub] [flink] dianfu commented on a diff in pull request #19295: [FLINK-26941][cep] Support Pattern end with notFollowedBy with window

2022-06-13 Thread GitBox
dianfu commented on code in PR #19295: URL: https://github.com/apache/flink/pull/19295#discussion_r895598233 ## flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java: ## @@ -261,15 +261,31 @@ public Collection>, Long>> advanceTime( final NFAStat

[jira] [Updated] (FLINK-28036) HiveInspectors should use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28036: - Summary: HiveInspectors should use correct writable type to creaet ConstantObjectInspector (was: Use co

[jira] [Created] (FLINK-28036) Use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread luoyuxia (Jira)
luoyuxia created FLINK-28036: Summary: Use correct writable type to creaet ConstantObjectInspector Key: FLINK-28036 URL: https://issues.apache.org/jira/browse/FLINK-28036 Project: Flink Issue Ty

[jira] [Updated] (FLINK-28036) Use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28036: - Fix Version/s: 1.16.0 > Use correct writable type to creaet ConstantObjectInspector > --

[jira] [Updated] (FLINK-28036) Use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28036: - Component/s: Connectors / Hive > Use correct writable type to creaet ConstantObjectInspector > -

[jira] [Updated] (FLINK-28036) HiveInspectors should use correct writable type to creaet ConstantObjectInspector

2022-06-13 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-28036: - Description: In  > HiveInspectors should use correct writable type to creaet > ConstantObjectInspector

[jira] [Updated] (FLINK-27395) IllegalStateException: Could not find policy 'pick_first'. on Flink Application

2022-06-13 Thread Natan HP (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natan HP updated FLINK-27395: - Description: I got this exception on flink taskmanager, but I can see that the data is successfully pub

[jira] [Updated] (FLINK-27395) IllegalStateException: Could not find policy 'pick_first'. on Flink Application

2022-06-13 Thread Natan HP (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natan HP updated FLINK-27395: - Description: I got this exception on flink taskmanager, but I can see that the data is successfully pub

[jira] [Closed] (FLINK-27395) IllegalStateException: Could not find policy 'pick_first'. on Flink Application

2022-06-13 Thread Natan HP (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natan HP closed FLINK-27395. > IllegalStateException: Could not find policy 'pick_first'. on Flink > Application > ---

[jira] [Resolved] (FLINK-27395) IllegalStateException: Could not find policy 'pick_first'. on Flink Application

2022-06-13 Thread Natan HP (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natan HP resolved FLINK-27395. -- Resolution: Resolved > IllegalStateException: Could not find policy 'pick_first'. on Flink > Applicat

[GitHub] [flink] zhuzhurk commented on a diff in pull request #19946: [FLINK-28018][core] correct the start index for creating empty splits in BinaryInputFormat#createInputSplits

2022-06-13 Thread GitBox
zhuzhurk commented on code in PR #19946: URL: https://github.com/apache/flink/pull/19946#discussion_r896335558 ## flink-core/src/test/java/org/apache/flink/api/common/io/BinaryInputFormatTest.java: ## @@ -160,6 +160,44 @@ public void testGetStatisticsMultiplePaths() throws IOEx

[jira] [Updated] (FLINK-27395) IllegalStateException: Could not find policy 'pick_first'. on Flink Application

2022-06-13 Thread Natan HP (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natan HP updated FLINK-27395: - Description: I got this exception on flink taskmanager, but I can see that the data is successfully pub

[jira] [Comment Edited] (FLINK-28003) A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553870#comment-17553870 ] Jing Zhang edited comment on FLINK-28003 at 6/14/22 3:14 AM: -

[jira] [Commented] (FLINK-28003) A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553870#comment-17553870 ] Jing Zhang commented on FLINK-28003: As discussed with [~fsk119] offline, we add a c

[jira] [Assigned] (FLINK-28003) A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang reassigned FLINK-28003: -- Assignee: Shengkai Fang > A unexpected replacement happened in SqlClient, for example, replac

[GitHub] [flink] lsyldliu commented on pull request #19860: [FLINK-27658][table] FlinkUserCodeClassLoader expose addURL method to allow to register jar dynamically

2022-06-13 Thread GitBox
lsyldliu commented on PR #19860: URL: https://github.com/apache/flink/pull/19860#issuecomment-1154661119 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-27944) IO metrics collision happens if a task has union inputs

2022-06-13 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-27944: Fix Version/s: 1.15.2 (was: 1.15.1) > IO metrics collision happens if a task has un

[GitHub] [flink] PatrickRen commented on pull request #19828: [FLINK-27762][connector/kafka] Catch WakeupException and retry KafkaConsumer invocations in split assignment

2022-06-13 Thread GitBox
PatrickRen commented on PR #19828: URL: https://github.com/apache/flink/pull/19828#issuecomment-1154653485 @becketqin @leonardBang Please take a look when you are available. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Updated] (FLINK-28035) Don't check num of buckets for rescale bucket condition

2022-06-13 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-28035: -- Summary: Don't check num of buckets for rescale bucket condition (was: Enable scan reading different

[GitHub] [flink] PatrickRen commented on pull request #19828: [FLINK-27762][connector/kafka] Catch WakeupException and retry KafkaConsumer invocations in split assignment

2022-06-13 Thread GitBox
PatrickRen commented on PR #19828: URL: https://github.com/apache/flink/pull/19828#issuecomment-1154652936 Thanks for the review @zou-can ! Initially I was trying to fix this case from the root that `KafkaPartitionSplitReader#wakeup` should only wake up the blocking `KafkaConsumer#poll` inv

[jira] [Comment Edited] (FLINK-28003) A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553860#comment-17553860 ] Jing Zhang edited comment on FLINK-28003 at 6/14/22 2:51 AM: -

[jira] [Created] (FLINK-28035) Enable scan reading different bucket num for rescale bucket

2022-06-13 Thread Jane Chan (Jira)
Jane Chan created FLINK-28035: - Summary: Enable scan reading different bucket num for rescale bucket Key: FLINK-28035 URL: https://issues.apache.org/jira/browse/FLINK-28035 Project: Flink Issue

[jira] [Commented] (FLINK-28003) A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553860#comment-17553860 ] Jing Zhang commented on FLINK-28003: [~martijnvisser] Thanks for response, however y

[jira] [Updated] (FLINK-28003) A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang updated FLINK-28003: --- Summary: A unexpected replacement happened in SqlClient, for example, replace 'pos ' to 'POSITION'

[jira] [Reopened] (FLINK-28003) 'pos ' field would be updated to 'POSITION' when use SqlClient

2022-06-13 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang reopened FLINK-28003: > 'pos ' field would be updated to 'POSITION' when use SqlClient > --

[jira] [Commented] (FLINK-27951) Translate the "Debugging Classloading" page into Chinese

2022-06-13 Thread Zili Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553859#comment-17553859 ] Zili Sun commented on FLINK-27951: -- [~martijnvisser] I have done the work and have crea

[jira] [Created] (FLINK-28034) ClassCastException occurred in creating a checkpoint with merge windows

2022-06-13 Thread Takayuki Eimizu (Jira)
Takayuki Eimizu created FLINK-28034: --- Summary: ClassCastException occurred in creating a checkpoint with merge windows Key: FLINK-28034 URL: https://issues.apache.org/jira/browse/FLINK-28034 Projec

[jira] [Closed] (FLINK-28029) Checkpoint always hangs when running some jobs

2022-06-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-28029. Resolution: Duplicate > Checkpoint always hangs when running some jobs > -

[jira] [Closed] (FLINK-28030) Checkpoint always hangs when running some jobs

2022-06-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-28030. Resolution: Duplicate > Checkpoint always hangs when running some jobs > -

[jira] [Closed] (FLINK-28031) Checkpoint always hangs when running some jobs

2022-06-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang closed FLINK-28031. Resolution: Duplicate > Checkpoint always hangs when running some jobs > -

[GitHub] [flink] paul8263 commented on pull request #19772: [FLINK-27579][client] The param client.timeout can not be set by dyna…

2022-06-13 Thread GitBox
paul8263 commented on PR #19772: URL: https://github.com/apache/flink/pull/19772#issuecomment-1154618703 Hi @wangyang0918 , Could you please review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-13 Thread YeAble (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553848#comment-17553848 ] YeAble commented on FLINK-28033: In my mind,it can do like this: {code:java} long newMin

[GitHub] [flink] lsyldliu commented on pull request #19860: [FLINK-27658][table] FlinkUserCodeClassLoader expose addURL method to allow to register jar dynamically

2022-06-13 Thread GitBox
lsyldliu commented on PR #19860: URL: https://github.com/apache/flink/pull/19860#issuecomment-1154606842 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-13 Thread YeAble (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YeAble updated FLINK-28033: --- Priority: Blocker (was: Major) > find and output new min watermark mybe wrong when in multichannel > --

[jira] [Created] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-13 Thread YeAble (Jira)
YeAble created FLINK-28033: -- Summary: find and output new min watermark mybe wrong when in multichannel Key: FLINK-28033 URL: https://issues.apache.org/jira/browse/FLINK-28033 Project: Flink Issue

[jira] [Updated] (FLINK-28033) find and output new min watermark mybe wrong when in multichannel

2022-06-13 Thread YeAble (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YeAble updated FLINK-28033: --- Affects Version/s: (was: 1.15.0) > find and output new min watermark mybe wrong when in multichannel > -

  1   2   3   4   >