[GitHub] [flink] FangYongs commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-02 Thread via GitHub
FangYongs commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155438551 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java: ## @@ -18,34 +18,67 @@ package org.apache.flink.table.jdbc;

[GitHub] [flink] FangYongs commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-01 Thread via GitHub
FangYongs commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155231475 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java: ## @@ -55,41 +85,75 @@ public DatabaseMetaData getMetaData() thro

[GitHub] [flink] FangYongs commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-01 Thread via GitHub
FangYongs commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155231101 ## flink-table/flink-sql-jdbc-driver/src/test/java/org/apache/flink/table/jdbc/FlinkConnectionTest.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] FangYongs commented on a diff in pull request #22289: [FLINK-31545][jdbc-driver] Create executor in flink connection

2023-04-01 Thread via GitHub
FangYongs commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155230946 ## flink-table/flink-sql-jdbc-driver-bundle/pom.xml: ## @@ -77,7 +89,9 @@ org.apache.flink:fl