Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-07 Thread via GitHub
snuyanzin merged PR #23885: URL: https://github.com/apache/flink/pull/23885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
snuyanzin commented on code in PR #23885: URL: https://github.com/apache/flink/pull/23885#discussion_r1417994612 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java: ## @@ -66,7 +66,7 @@ void testPassingExecutionParameters() {

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
JingGe commented on code in PR #23885: URL: https://github.com/apache/flink/pull/23885#discussion_r1417905005 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java: ## @@ -66,7 +66,7 @@ void testPassingExecutionParameters() {

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
flinkbot commented on PR #23885: URL: https://github.com/apache/flink/pull/23885#issuecomment-1843366916 ## CI report: * 19810b57dd41666d22a91399d41be0bc0c4794d6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
snuyanzin opened a new pull request, #23885: URL: https://github.com/apache/flink/pull/23885 ## What is the purpose of the change The PR is about to replace deprecated `StreamTableEnvironment#toAppendStream` with `StreamTableEnvironment#toDataStream` as mentioned in javadoc