dawidwys merged PR #23884:
URL: https://github.com/apache/flink/pull/23884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1424168387
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/CalculatedQueryOperation.java:
##
@@ -37,6 +38,8 @@ public class CalculatedQueryOpe
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1424166313
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/QueryOperationSqlExecutionTest.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache So
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1424162329
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -120,7 +120,9 @@ public EnumSet s
twalthr commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1424080884
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/CalculatedQueryOperation.java:
##
@@ -37,6 +38,8 @@ public class CalculatedQueryOper
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423942467
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/OperationUtils.java:
##
@@ -43,9 +43,7 @@ public class OperationUtils {
* @re
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423825439
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/DistinctQueryOperation.java:
##
@@ -45,6 +45,13 @@ public String asSummaryString()
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423704726
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/QueryOperationSqlExecutionTest.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache So
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423705492
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/QueryOperationTestPrograms.java:
##
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Softwa
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423701999
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableApiTestStep.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Softwar
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423697501
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SourceQueryOperation.java:
##
@@ -76,6 +78,25 @@ public String asSummaryString() {
dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423683780
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/JoinQueryOperation.java:
##
@@ -106,6 +107,32 @@ public String asSummaryString() {
twalthr commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1420282783
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/DistinctQueryOperation.java:
##
@@ -45,6 +45,13 @@ public String asSummaryString() {
flinkbot commented on PR #23884:
URL: https://github.com/apache/flink/pull/23884#issuecomment-1843138896
## CI report:
* 33d967570f5b86867dc026358dbff280e09da779 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
dawidwys opened a new pull request, #23884:
URL: https://github.com/apache/flink/pull/23884
## What is the purpose of the change
Serialize `QueryOperations` into its SQL equivalents.
## Verifying this change
Added tests in `QueryOperationSqlSerializationTest`
A
15 matches
Mail list logo
