Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora merged PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#issuecomment-1847114921 @mxm I have updated the PR based on the discussion, please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#issuecomment-1845511538 thanks for the thorough review @mxm I will add validation for the path and improve the comments/docs as discussed tomorrow -- This is an automated message from the Apach

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1419027783 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1419022782 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @@ p

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1419018998 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @@ p

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1419016958 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1419016181 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffResult.java: ## @@ -101,14 +101,7 @@ public String toSt

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418996423 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffResult.java: ## @@ -101,14 +101,7 @@ public String t

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418996423 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffResult.java: ## @@ -101,14 +101,7 @@ public String t

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418990597 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418991204 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418985847 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Man

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418970683 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @@ p

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418965408 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffResult.java: ## @@ -101,14 +101,7 @@ public String toSt

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418960497 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418959147 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418958103 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java: ## @@ -28,7 +28,9 @@ public enum DiffType {

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418956894 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @@ p

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418865579 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418855770 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java: ## @@ -28,7 +28,9 @@ public enum DiffType {

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418852248 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -306,6 +319,40 @

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418847581 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Man

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418846318 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/diff/DiffType.java: ## @@ -28,7 +28,9 @@ public enum DiffType {

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

mxm commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418806188 ## docs/content/docs/custom-resource/job-management.md: ## @@ -288,12 +288,33 @@ Rollback is currently only supported for `FlinkDeployments`. ## Manual

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418551584 ## docs/content/docs/custom-resource/reference.md: ## @@ -125,6 +125,7 @@ This page serves as a full reference for FlinkDeployment custom resource defi

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

1996fanrui commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418224880 ## docs/content/docs/custom-resource/reference.md: ## @@ -125,6 +125,7 @@ This page serves as a full reference for FlinkDeployment custom resource

[PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

gyfora opened a new pull request, #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724 ## What is the purpose of the change A common request is to support a streamlined, user friendly way of redeploying from a target savepoint. Previously this was only possible b