Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-31 Thread via GitHub
exceptionfactory closed pull request #9115: NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation URL: https://github.com/apache/nifi/pull/9115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-23 Thread via GitHub
exceptionfactory commented on PR #9115: URL: https://github.com/apache/nifi/pull/9115#issuecomment-2307742322 Thanks for following up @simonbence. That's a good point about values already being sorted. The other reference you noted is for NiFi Registry, which is a different class. With the

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-23 Thread via GitHub
simonbence commented on PR #9115: URL: https://github.com/apache/nifi/pull/9115#issuecomment-2306606535 Hi @exceptionfactory ! For full disclosure, it looks like there is already an ordering within the mapping process: [here](https://github.com/apache/nifi/blob/7ade77ac22fc2e5bbd3815

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-22 Thread via GitHub
exceptionfactory commented on code in PR #9115: URL: https://github.com/apache/nifi/pull/9115#discussion_r1727428229 ## nifi-commons/nifi-security-identity/src/test/java/org/apache/nifi/authorization/util/IdentityMappingUtilTest.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-22 Thread via GitHub
simonbence commented on code in PR #9115: URL: https://github.com/apache/nifi/pull/9115#discussion_r1727393737 ## nifi-commons/nifi-security-identity/src/test/java/org/apache/nifi/authorization/util/IdentityMappingUtilTest.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apach

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-22 Thread via GitHub
simonbence commented on code in PR #9115: URL: https://github.com/apache/nifi/pull/9115#discussion_r1727385859 ## nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java: ## @@ -140,8 +141,12 @@ public int compare(IdentityMap

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-08-13 Thread via GitHub
exceptionfactory commented on PR #9115: URL: https://github.com/apache/nifi/pull/9115#issuecomment-2286737178 @simonbence Just following up on this, glad to help bring this to completion, so let me know if you have any questions about the comments provided earlier. -- This is an automate

Re: [PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-07-27 Thread via GitHub
exceptionfactory commented on code in PR #9115: URL: https://github.com/apache/nifi/pull/9115#discussion_r1693961683 ## nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java: ## @@ -140,8 +141,12 @@ public int compare(Ident

[PR] NIFI-13409 Enforcing lexiographical order of the identity mappings to match documentation [nifi]

2024-07-26 Thread via GitHub
simonbence opened a new pull request, #9115: URL: https://github.com/apache/nifi/pull/9115 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-13409) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tra