[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

2021-05-28 Thread GitBox
dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r641833458 ## File path: solr/core/src/test/org/apache/solr/cloud/api/collections/SimpleCollectionCreateDeleteTest.java ## @@ -110,7 +110,7 @@ public void testDeleteAlsoDe

[jira] [Created] (SOLR-15445) ManagedResourceStorage should use ConfigSetService more to not assume ZK

2021-05-28 Thread David Smiley (Jira)
David Smiley created SOLR-15445: --- Summary: ManagedResourceStorage should use ConfigSetService more to not assume ZK Key: SOLR-15445 URL: https://issues.apache.org/jira/browse/SOLR-15445 Project: Solr

[GitHub] [solr] madrob commented on pull request #107: Address many Rawtypes warnings

2021-05-28 Thread GitBox
madrob commented on pull request #107: URL: https://github.com/apache/solr/pull/107#issuecomment-850660464 There was a merge conflict with some of Noble’s work on the XPath stuff so I wanted to wait for a merge of that, but I suppose there’s no major reason to hold up. I’ll take care of th

[GitHub] [solr] dsmiley commented on pull request #107: Address many Rawtypes warnings

2021-05-28 Thread GitBox
dsmiley commented on pull request #107: URL: https://github.com/apache/solr/pull/107#issuecomment-850658268 It'll be nice to see this changes merged... did you forget about this one @madrob? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641771214 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -70,6 +72,63 @@ public void tearDown() throws Exception { super.t

[GitHub] [solr] tomglk commented on pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-28 Thread GitBox
tomglk commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-850596379 Thank you for the great collaboration on this PR, @cpoerschke . I really did learn a lot thanks to your constructive remarks and had a lot of fun working on this. :) -- This is an

[GitHub] [solr] gerlowskija commented on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

2021-05-28 Thread GitBox
gerlowskija commented on pull request #81: URL: https://github.com/apache/solr/pull/81#issuecomment-850584543 > Any of the remaining APIs would be great if the offer still stands - maybe ADDREPLICAPROPERTY and/or DELETEREPLICAPROPERTY ? Returning to this now - if I don't finish conve

[jira] [Updated] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-28 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-12697: --- Fix Version/s: 8.9 main (9.0) Resolution: Fixed S

[GitHub] [solr] cpoerschke commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
cpoerschke commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641713249 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -70,6 +72,63 @@ public void tearDown() throws Exception { sup

[GitHub] [solr] cpoerschke commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
cpoerschke commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641708552 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -865,7 +866,19 @@ protected void mergeIds(ResponseBuilder rb,

[GitHub] [solr] cpoerschke commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
cpoerschke commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641707464 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb

[GitHub] [solr] gerlowskija commented on a change in pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-05-28 Thread GitBox
gerlowskija commented on a change in pull request #120: URL: https://github.com/apache/solr/pull/120#discussion_r641534935 ## File path: solr/contrib/blob-repository/src/java/org/apache/solr/blob/backup/BlobBackupRepository.java ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apa

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353435#comment-17353435 ] ASF subversion and git services commented on SOLR-12697: Commit 0

[GitHub] [solr] muse-dev[bot] commented on a change in pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-28 Thread GitBox
muse-dev[bot] commented on a change in pull request #139: URL: https://github.com/apache/solr/pull/139#discussion_r641608294 ## File path: solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java ## @@ -328,4 +406,56 @@ private void executeCommand(String u

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353394#comment-17353394 ] ASF subversion and git services commented on SOLR-12697: Commit 3

[GitHub] [solr] cpoerschke merged pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-28 Thread GitBox
cpoerschke merged pull request #123: URL: https://github.com/apache/solr/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [solr] janhoy commented on pull request #139: SOLR-15423 JWTAuthPlugin support for custom truststore

2021-05-28 Thread GitBox
janhoy commented on pull request #139: URL: https://github.com/apache/solr/pull/139#issuecomment-850459590 I just integrated mock-oauth2-server, and finally was able to verify that you can configure JWTAuthPlugin with a PEM file and it is accepted by the mock server. Still have some cleanu

[jira] [Resolved] (SOLR-15090) Allow backups to GCS (Google Cloud Storage)

2021-05-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-15090. Fix Version/s: 8.9 Resolution: Fixed I've merged the 8.9 backport; closing now as a

[jira] [Commented] (SOLR-15090) Allow backups to GCS (Google Cloud Storage)

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353327#comment-17353327 ] ASF subversion and git services commented on SOLR-15090: Commit 5

[jira] [Commented] (SOLR-15090) Allow backups to GCS (Google Cloud Storage)

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353321#comment-17353321 ] ASF subversion and git services commented on SOLR-15090: Commit e

[jira] [Created] (SOLR-15444) Document the SwedishMinimalStemmer

2021-05-28 Thread Jira
Jan Høydahl created SOLR-15444: -- Summary: Document the SwedishMinimalStemmer Key: SOLR-15444 URL: https://issues.apache.org/jira/browse/SOLR-15444 Project: Solr Issue Type: Task Security L

[jira] [Resolved] (SOLR-15439) Upgrade jose4j to v0.7.7

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15439. Fix Version/s: main (9.0) Resolution: Fixed Thanks for the review [~dsmiley] > Upgrade jose

[jira] [Commented] (SOLR-15439) Upgrade jose4j to v0.7.7

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353314#comment-17353314 ] ASF subversion and git services commented on SOLR-15439: Commit f

[GitHub] [solr] janhoy merged pull request #154: SOLR-15439 Upgrade jose4j to v0.7.7

2021-05-28 Thread GitBox
janhoy merged pull request #154: URL: https://github.com/apache/solr/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[jira] [Commented] (SOLR-15397) Expose zookeeper status in the exporter

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353313#comment-17353313 ] ASF subversion and git services commented on SOLR-15397: Commit 9

[jira] [Commented] (SOLR-15397) Expose zookeeper status in the exporter

2021-05-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353312#comment-17353312 ] ASF subversion and git services commented on SOLR-15397: Commit e

[GitHub] [solr] janhoy merged pull request #153: SOLR-15397 Remove "exemplar" setting for the new zookeeper grafana graph

2021-05-28 Thread GitBox
janhoy merged pull request #153: URL: https://github.com/apache/solr/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[jira] [Commented] (SOLR-15442) Syncronize the port and host variables for Solr

2021-05-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353250#comment-17353250 ] Jan Høydahl commented on SOLR-15442: Jetty is dictating some of this. I believe that

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641405433 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -865,7 +866,19 @@ protected void mergeIds(ResponseBuilder rb, Shar

[jira] [Created] (SOLR-15443) Atomic Update of parent document in nested documents fails and needs solr restart

2021-05-28 Thread Chandramohan (Jira)
Chandramohan created SOLR-15443: --- Summary: Atomic Update of parent document in nested documents fails and needs solr restart Key: SOLR-15443 URL: https://issues.apache.org/jira/browse/SOLR-15443 Project

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641305470 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licensed t

[GitHub] [solr] tkaessmann commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tkaessmann commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641323199 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licens

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641322937 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licensed t

[GitHub] [solr] tkaessmann commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tkaessmann commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641323199 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licens

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-28 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641322937 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licensed t