[
https://issues.apache.org/jira/browse/SOLR-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394499#comment-17394499
]
Mark Robert Miller commented on SOLR-15512:
---
I ran into a stall here but will b
Jdurham2843 commented on a change in pull request #243:
URL: https://github.com/apache/solr/pull/243#discussion_r683834131
##
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java
##
@@ -276,14 +282,12 @@ public void setMetrics(Map> metrics) {
public Tu
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394402#comment-17394402
]
Mark Robert Miller edited comment on SOLR-15428 at 8/6/21, 12:21 AM:
--
[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394402#comment-17394402
]
Mark Robert Miller commented on SOLR-15428:
---
Nitsan Wakart was looking at the J
Jdurham2843 commented on pull request #243:
URL: https://github.com/apache/solr/pull/243#issuecomment-893870111
I'll look into handling those as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Jdurham2843 commented on a change in pull request #243:
URL: https://github.com/apache/solr/pull/243#discussion_r683834131
##
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java
##
@@ -276,14 +282,12 @@ public void setMetrics(Map> metrics) {
public Tu
ben-manes commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683832835
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -176,33 +193,92 @@ public V get(K key) {
return cache.getIfPresent(key)
HoustonPutman commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-893863775
Oh another thing I changed locally that has worked out well:
Instead of using a custom header `x_is_directory`, I set the content-type of
directory objects to `applicatio
ben-manes commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683821705
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -190,73 +191,72 @@ public V get(K key) {
return cache.getIfPresent(key)
[
https://issues.apache.org/jira/browse/SOLR-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett resolved SOLR-14716.
--
Fix Version/s: main (9.0)
Resolution: Fixed
I fixed this in the work on SOLR-144
[
https://issues.apache.org/jira/browse/SOLR-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394293#comment-17394293
]
Cassandra Targett commented on SOLR-15239:
--
All the subtasks here are done, but
madrob commented on pull request #214:
URL: https://github.com/apache/solr/pull/214#issuecomment-893787889
Do we need to include a JFR or async-profiler recording profile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683771913
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -176,33 +193,92 @@ public V get(K key) {
return cache.getIfPresent(key);
madrob commented on pull request #243:
URL: https://github.com/apache/solr/pull/243#issuecomment-893768746
> fieldNames and fieldLabels are not copied via the copy constructor, nor
via clone and merge
probably should handle that here
--
This is an automated message from the Apache
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683729013
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -190,73 +191,72 @@ public V get(K key) {
return cache.getIfPresent(key);
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394253#comment-17394253
]
Cassandra Targett commented on SOLR-15556:
--
There's a very early version of what
ben-manes commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683680979
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -190,73 +191,72 @@ public V get(K key) {
return cache.getIfPresent(key)
[
https://issues.apache.org/jira/browse/SOLR-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394234#comment-17394234
]
Cassandra Targett commented on SOLR-12018:
--
This has been open for a while just
[
https://issues.apache.org/jira/browse/SOLR-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh resolved SOLR-14866.
Resolution: Duplicate
This has been fixed already!
> Ref Guide: make table widths automati
[
https://issues.apache.org/jira/browse/SOLR-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394227#comment-17394227
]
David Eric Pugh commented on SOLR-14866:
Definitly! This is great work you have
[
https://issues.apache.org/jira/browse/SOLR-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett resolved SOLR-12742.
--
Resolution: Won't Fix
This has been removed from Solr so no doc improvements are needed
[
https://issues.apache.org/jira/browse/SOLR-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394225#comment-17394225
]
Cassandra Targett commented on SOLR-14866:
--
[~epugh], I forgot this issue and re
[
https://issues.apache.org/jira/browse/SOLR-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17394221#comment-17394221
]
Timothy Potter commented on SOLR-9853:
--
Taking a look at this, seems doable for basic
[
https://issues.apache.org/jira/browse/SOLR-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-9853:
-
Labels: RobustSQL (was: )
> Solr JDBC does not return multiValue fields or text typed fields
> --
[
https://issues.apache.org/jira/browse/SOLR-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter reassigned SOLR-9853:
Assignee: Timothy Potter
> Solr JDBC does not return multiValue fields or text typed fields
HoustonPutman merged pull request #293:
URL: https://github.com/apache/solr-operator/pull/293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
HoustonPutman closed issue #268:
URL: https://github.com/apache/solr-operator/issues/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
HoustonPutman commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-893609933
Sorry was actually going to comment today. I have some local changes that
generally make the experience better, in my opinion. Will probably push soon,
but the biggest change i
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-893590872
@gerlowskija My estimate at this point is that about 75-80% of comments have
been addressed? @HoustonPutman and I have been resolving comments that are now
fixed, so I'm mainly going
gerlowskija edited a comment on issue #301:
URL: https://github.com/apache/solr-operator/issues/301#issuecomment-893584633
I've attached a rough PR that shows how this could be done. Below are an
example 'solrcloud' and 'solrbackup' that use the proposed functionality:
**SolrCloud**
gerlowskija commented on issue #301:
URL: https://github.com/apache/solr-operator/issues/301#issuecomment-893584633
I've attached a rough PR that shows how this could be done. Below are an
example 'solrcloud' and 'solrbackup' that use the proposed functionality:
**SolrCloud**
```
gerlowskija opened a new pull request #302:
URL: https://github.com/apache/solr-operator/pull/302
This commit adds first-pass support for exposing Solr's
GcsBackupRepository through our operator configuration. This WIP
support has a number of caveats and downsides that'll need agreed
gerlowskija commented on issue #301:
URL: https://github.com/apache/solr-operator/issues/301#issuecomment-893547108
Some questions this raises:
- should backup mechanisms be mutually exclusive in a given 'solrcloud'
definition, or should we allow users to configure multiple and choos
gerlowskija opened a new issue #301:
URL: https://github.com/apache/solr-operator/issues/301
Currently the 'solrbackup' resource assumes that users want backups stored
"locally" (i.e. stored on a PV or mounted drive using Solr's
LocalFileSystemRepository). These local backups can then opt
gerlowskija commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-893534199
@HoustonPutman am I right in thinking that most (but not all?) of your
comments have been addressed at this point? I'm a little unclear on what's
still outstanding for me to sta
thelabdude commented on a change in pull request #247:
URL: https://github.com/apache/solr/pull/247#discussion_r683537838
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java
##
@@ -283,8 +283,9 @@ public void open() throws IOException {
thelabdude commented on a change in pull request #247:
URL: https://github.com/apache/solr/pull/247#discussion_r683505909
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java
##
@@ -283,8 +283,9 @@ public void open() throws IOException {
madrob commented on a change in pull request #247:
URL: https://github.com/apache/solr/pull/247#discussion_r683476249
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java
##
@@ -283,8 +283,9 @@ public void open() throws IOException {
madrob commented on a change in pull request #247:
URL: https://github.com/apache/solr/pull/247#discussion_r683476249
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java
##
@@ -283,8 +283,9 @@ public void open() throws IOException {
madrob commented on a change in pull request #238:
URL: https://github.com/apache/solr/pull/238#discussion_r683420360
##
File path: solr/core/src/test/org/apache/solr/handler/ReplicationTestHelper.java
##
@@ -0,0 +1,317 @@
+package org.apache.solr.handler;
+
+import org.apache.
spyk commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683387756
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##
@@ -292,10 +291,10 @@ private static float scoreNode(float[]
madrob commented on a change in pull request #247:
URL: https://github.com/apache/solr/pull/247#discussion_r682942562
##
File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java
##
@@ -278,6 +265,24 @@ protected String translateComparison(RexNode node) {
markrmiller commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r683078542
##
File path: solr/benchmark/build.gradle
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
thelabdude merged pull request #246:
URL: https://github.com/apache/solr/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
cpoerschke commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683304620
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##
@@ -292,10 +291,10 @@ private static float scoreNode(f
epugh commented on pull request #159:
URL: https://github.com/apache/solr/pull/159#issuecomment-892617936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
cpoerschke commented on a change in pull request #243:
URL: https://github.com/apache/solr/pull/243#discussion_r683291659
##
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java
##
@@ -276,14 +282,12 @@ public void setMetrics(Map> metrics) {
public Tup
alessandrobenedetti commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683276114
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##
@@ -292,10 +291,10 @@ private static float sc
madrob commented on pull request #243:
URL: https://github.com/apache/solr/pull/243#issuecomment-892961555
This LGTM, @cpoerschke did you have thoughts on additional documentation
around this change?
--
This is an automated message from the Apache Git Service.
To respond to the message,
thelabdude commented on a change in pull request #247:
URL: https://github.com/apache/solr/pull/247#discussion_r682971005
##
File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java
##
@@ -278,6 +265,24 @@ protected String translateComparison(RexNode node) {
sonatype-lift[bot] commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r683075217
##
File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java
##
@@ -0,0 +1,370 @@
+/*
+ * Licensed to the Apache Software Found
tboeghk commented on pull request #159:
URL: https://github.com/apache/solr/pull/159#issuecomment-892623271
Yes (I'm 95% sure): The macros don't get expanded on the shard. With the fix
above the configuration is not picked up on the shard and the macros should
stay expanded. Do we need ano
madrob commented on a change in pull request #238:
URL: https://github.com/apache/solr/pull/238#discussion_r682950270
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java
##
@@ -61,6 +64,17 @@
* is fully initialized and stable before proce
madrob commented on a change in pull request #225:
URL: https://github.com/apache/solr/pull/225#discussion_r682949171
##
File path: solr/core/src/test/org/apache/solr/search/FuzzySearchTest.java
##
@@ -51,6 +52,7 @@ public void setupCollection() throws Exception {
}
@Te
cpoerschke commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683304620
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##
@@ -292,10 +291,10 @@ private static float scoreNode(f
cpoerschke commented on a change in pull request #243:
URL: https://github.com/apache/solr/pull/243#discussion_r683291659
##
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java
##
@@ -276,14 +282,12 @@ public void setMetrics(Map> metrics) {
public Tup
alessandrobenedetti commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683276722
##
File path:
solr/contrib/ltr/src/test-files/modelExamples/multipleadditivetreesmodel_split_at_threshold.json
##
@@ -0,0 +1,23 @@
+{
+"class"
alessandrobenedetti commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683276722
##
File path:
solr/contrib/ltr/src/test-files/modelExamples/multipleadditivetreesmodel_split_at_threshold.json
##
@@ -0,0 +1,23 @@
+{
+"class"
alessandrobenedetti commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r683276114
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##
@@ -292,10 +291,10 @@ private static float sc
59 matches
Mail list logo
