[GitHub] [solr] Olivigarden opened a new pull request #278: SOLR-15607: Invert indent UI behaviour

2021-08-30 Thread GitBox
Olivigarden opened a new pull request #278: URL: https://github.com/apache/solr/pull/278 https://issues.apache.org/jira/browse/SOLR-15607 # Description Updated the indent off checkbox on the query UI to instead be indent on and enabled by default. Always pass indent param to

[GitHub] [solr-operator] thelabdude commented on a change in pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-08-30 Thread GitBox
thelabdude commented on a change in pull request #312: URL: https://github.com/apache/solr-operator/pull/312#discussion_r698805209 ## File path: controllers/solrcloud_controller.go ## @@ -960,80 +950,166 @@ func (r *SolrCloudReconciler) indexAndWatchForTLSSecret(mgr ctrl.Manag

[GitHub] [solr-operator] thelabdude commented on a change in pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-08-30 Thread GitBox
thelabdude commented on a change in pull request #312: URL: https://github.com/apache/solr-operator/pull/312#discussion_r698804396 ## File path: controllers/controller_utils_test.go ## @@ -184,46 +182,6 @@ func expectDeployment(t *testing.T, g *gomega.GomegaWithT, requests cha

[jira] [Assigned] (SOLR-15607) Invert indent switch behaviour for clarity

2021-08-30 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-15607: -- Assignee: David Eric Pugh > Invert indent switch behaviour for clarity > -

[jira] [Created] (SOLR-15607) Invert indent switch behaviour for clarity

2021-08-30 Thread Olivia Falk (Jira)
Olivia Falk created SOLR-15607: -- Summary: Invert indent switch behaviour for clarity Key: SOLR-15607 URL: https://issues.apache.org/jira/browse/SOLR-15607 Project: Solr Issue Type: Improvement

[GitHub] [solr-operator] HoustonPutman commented on issue #223: Solr Operator compatibility with Istio

2021-08-30 Thread GitBox
HoustonPutman commented on issue #223: URL: https://github.com/apache/solr-operator/issues/223#issuecomment-908658951 Both prerequisites are now in. The v0.4.0 release should solve this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [solr-operator] HoustonPutman closed issue #223: Solr Operator compatibility with Istio

2021-08-30 Thread GitBox
HoustonPutman closed issue #223: URL: https://github.com/apache/solr-operator/issues/223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #311: Add ability to specify ZK Config values.

2021-08-30 Thread GitBox
HoustonPutman merged pull request #311: URL: https://github.com/apache/solr-operator/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman closed issue #290: Allow configuration of zookeeper cluster configs via values.yaml

2021-08-30 Thread GitBox
HoustonPutman closed issue #290: URL: https://github.com/apache/solr-operator/issues/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr] madrob commented on a change in pull request #254: Solr 15581

2021-08-30 Thread GitBox
madrob commented on a change in pull request #254: URL: https://github.com/apache/solr/pull/254#discussion_r698717978 ## File path: solr/benchmark/src/java/org/apache/solr/bench/generators/StringsDSL.java ## @@ -0,0 +1,305 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (SOLR-15599) Upgrade AWS SDK from v1 to v2 for the S3 Repository

2021-08-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406839#comment-17406839 ] ASF subversion and git services commented on SOLR-15599: Commit 5

[GitHub] [solr] HoustonPutman merged pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-30 Thread GitBox
HoustonPutman merged pull request #271: URL: https://github.com/apache/solr/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (SOLR-15599) Upgrade AWS SDK from v1 to v2 for the S3 Repository

2021-08-30 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406837#comment-17406837 ] Houston Putman commented on SOLR-15599: --- Tested this with S3Mock and AWS S3, so it

[GitHub] [solr-operator] HoustonPutman merged pull request #316: s/his/this typo(?) fix in solr-cloud-crd.md

2021-08-30 Thread GitBox
HoustonPutman merged pull request #316: URL: https://github.com/apache/solr-operator/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] alextu commented on a change in pull request #277: SOLR-15603: Activate Gradle build cache

2021-08-30 Thread GitBox
alextu commented on a change in pull request #277: URL: https://github.com/apache/solr/pull/277#discussion_r698588029 ## File path: solr/solr-ref-guide/build.gradle ## @@ -215,20 +216,21 @@ check.dependsOn checkLocalJavadocLinksSite, checkSite // Hook site building to assemble

[GitHub] [solr] alextu commented on a change in pull request #277: SOLR-15603: Activate Gradle build cache

2021-08-30 Thread GitBox
alextu commented on a change in pull request #277: URL: https://github.com/apache/solr/pull/277#discussion_r698581182 ## File path: solr/solr-ref-guide/build.gradle ## @@ -184,6 +184,7 @@ ext { group "Documentation" description "Builds the ${details.desc}" +

[GitHub] [solr] alextu commented on a change in pull request #277: SOLR-15603: Activate Gradle build cache

2021-08-30 Thread GitBox
alextu commented on a change in pull request #277: URL: https://github.com/apache/solr/pull/277#discussion_r698578438 ## File path: build.gradle ## @@ -20,7 +20,7 @@ import java.time.format.DateTimeFormatter plugins { id "base" - id "com.palantir.consistent-versions" ver

[GitHub] [solr-site] HoustonPutman merged pull request #37: Merge main into production

2021-08-30 Thread GitBox
HoustonPutman merged pull request #37: URL: https://github.com/apache/solr-site/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [solr] dweiss commented on a change in pull request #277: SOLR-15603: Activate Gradle build cache

2021-08-30 Thread GitBox
dweiss commented on a change in pull request #277: URL: https://github.com/apache/solr/pull/277#discussion_r698541218 ## File path: build.gradle ## @@ -20,7 +20,7 @@ import java.time.format.DateTimeFormatter plugins { id "base" - id "com.palantir.consistent-versions" ver

[jira] [Commented] (SOLR-15603) Activate Gradle build cache

2021-08-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406753#comment-17406753 ] Dawid Weiss commented on SOLR-15603: Where is that pull request you mentioned? I don'

[jira] [Commented] (SOLR-15603) Activate Gradle build cache

2021-08-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406754#comment-17406754 ] Dawid Weiss commented on SOLR-15603: I see the PR now; came with a delay for some rea

[GitHub] [solr] HoustonPutman commented on a change in pull request #248: SOLR-6156: Fix NullPointerException if group.field grouping is used with rows=0 and timeAllowed

2021-08-30 Thread GitBox
HoustonPutman commented on a change in pull request #248: URL: https://github.com/apache/solr/pull/248#discussion_r698537736 ## File path: solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java ## @@ -216,6 +225,9 @@ private void searchWithTimeLimiter(Query que

[GitHub] [solr] alextu opened a new pull request #277: SOLR-15603: Activate Gradle build cache

2021-08-30 Thread GitBox
alextu opened a new pull request #277: URL: https://github.com/apache/solr/pull/277 https://issues.apache.org/jira/browse/SOLR-15603 # Description Activate gradle local build cache to take advantage of re-using past build executions on a single machine, it improves

[jira] [Commented] (SOLR-15603) Activate Gradle build cache

2021-08-30 Thread Alexis Tual (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406748#comment-17406748 ] Alexis Tual commented on SOLR-15603: Just a bit of background, I've investigated solr

[GitHub] [solr] spyk commented on a change in pull request #242: SOLR-15569: Split on the right subtree when node value == threshold on MultipleAdditiveTreesModel

2021-08-30 Thread GitBox
spyk commented on a change in pull request #242: URL: https://github.com/apache/solr/pull/242#discussion_r698497679 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java ## @@ -292,10 +291,10 @@ private static float scoreNode(float[]

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-30 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r698422058 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -91,6 +95,63 @@ public void init(NamedList args) { public String

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-30 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r698414812 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -342,7 +342,7 @@ private Path checkPathIsSafe(Path pathToCheck) throws IOExc

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-30 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r698411663 ## File path: solr/core/src/java/org/apache/solr/schema/SchemaManager.java ## @@ -428,17 +428,22 @@ private ManagedIndexSchema getFreshManagedSchema(SolrCore co

[GitHub] [solr] epugh commented on a change in pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-30 Thread GitBox
epugh commented on a change in pull request #264: URL: https://github.com/apache/solr/pull/264#discussion_r698409242 ## File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java ## @@ -195,7 +223,16 @@ private InputStream readSchemaLocally() { In

[jira] [Commented] (SOLR-15602) Upgrade gradle to 7.2

2021-08-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406660#comment-17406660 ] Dawid Weiss commented on SOLR-15602: PR link: https://github.com/apache/solr/pull/275

[jira] [Assigned] (SOLR-15602) Upgrade gradle to 7.2

2021-08-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned SOLR-15602: -- Assignee: Dawid Weiss > Upgrade gradle to 7.2 > - > > Key:

[GitHub] [solr] asalamon74 commented on pull request #24: SOLR-15111 Use JDK8 Base64 instead of own implementation

2021-08-30 Thread GitBox
asalamon74 commented on pull request #24: URL: https://github.com/apache/solr/pull/24#issuecomment-908188338 @janhoy Added the CHANGES.txt entry. I executed `./gradlew check` as far as I know it executes the tests. -- This is an automated message from the Apache Git Service. To respond t